Page MenuHomePhabricator
Create Task
Maniphest T16409

DisplayPositionEvent can have inconsistent state
Closed, ResolvedPublic
Actions

Description

The mitk::DisplayPositionEvent can be initialised by a display position, and the world position is calculated at the first request. However, if the display position is changed through a setter, the world position is not recalculated.

Event Timeline

espak added projects: MITK, Bugzilla.Nov 12 2013, 9:16 PM
espak added a subscriber: espak.Nov 12 2013, 9:39 PM

Pull request sent:
https://github.com/MITK/MITK/pull/39

espak added a comment.Nov 14 2013, 5:05 PM

I noticed the same error in mitk::KeyEvent. It would be worth checking the other event types, too.

espak added a comment.Dec 11 2013, 11:43 AM

Any update on this?

I want to update our fork after the new MITK release and want to revert our patches that have already be merged to the upstream master, so that we can be as close to the upstream as possible.

We test the patch on the three main platforms, with no problem.

nolden added a subscriber: nolden.Dec 11 2013, 1:17 PM

Sorry, the patch was not included in the 2013-12 release.

espak added a comment.Mar 3 2014, 12:22 PM

Could it be included in the 2014-03 release?

Thanks!

• git-user added a subscriber: • git-user.Mar 5 2014, 2:58 PM

User webechr has pushed new remote branch:

bug-16409-InconsistentDisplayPosition
• git-user added a comment.Mar 5 2014, 3:18 PM

User webechr has pushed new remote branch:

bug-16409-InconsistentDisplayPosition-Int
• webechr added a subscriber: • webechr.Mar 7 2014, 10:56 AM

Added core change request.

• webechr added a comment.Mar 10 2014, 10:18 AM

[ee6357]: Merge branch 'bug-16409-InconsistentDisplayPosition-Int'

Merged commits:

2014-03-05 15:18:12 Christian Weber [dac416]
Remove wrong member from being set,

2014-03-05 15:00:07 Christian Weber [1bad57]
Merge branch 'bug-16409-InconsistentDisplayPosition' into bug-16409-InconsistentDisplayPosition-Int

2014-03-05 14:59:14 Christian Weber [033ceb]
Adapt KeyEvent as well

2014-03-05 14:58:22 Christian Weber [1a41d3]
Display event world position recalculated if display position changed
Signed-off-by: Miklos Espal <'m.espak@ucl.ac.uk'>

kislinsk edited projects, added MITK (2014-03); removed MITK.Aug 1 2016, 10:48 PM
MITK · MIC · IMSY · DKFZ