Page MenuHomePhabricator

openCherry Qt4 InterativeSegmentation metabug
Closed, ResolvedPublic

Description

Anything that relates to porting the InterativeSegmentation to openCherry/Qt4.

Related Objects

Event Timeline

Moved most of the source files into the internal folder (in rev. 16330). Please check if the organization in internal/external files is correct.

The interactive segmentation view has rendering problems when it's vertical size is too small. The child widgets could be placed in a QScrollArea to provide scrollbars.

Shouldn`t we put all views a priori in a QScrollArea. As long as they don`t need additional space, ni scrollbars would be visible. I would prefer that solution.

Some TODOs for me or anyone:

  • ToolGUI classes of from

    qt4/src/Bundles/org.mitk.gui.qt.interactivesegmentation/src/internal

    are NOT specific to InteractieSegmentation; should rather be placed in Q4mitk
  • new/load/save button icons don't show up in Linux yet
  • for consistency and for placement of tools and tool GUIs in a common DLL, tool GUIs should also be instantiated through itk::ObjectFactory

Functionality is out of sync with Qt3 version. There were several recent changes regarding PACS integration to the Qt3 version.

There is T1858 (InteractiveSegmentation files in Q4mitk) for most issues of comment #5, so let's move the discussion there.

I kept the SVN digest containing your (Daniels) changes for the PACS integration. I did not start to sync the code because I was hoping you could take over that job ;-)

Daniel seems not to be on CC, so adding him. Please have a look at my previous comment.

Fixed some layout issues in revision 16581.

Exchanged the segmentation new/delete/load/save buttons with Tango icons in revision 16582.

After discussion, I changed the tool GUI creation back to ITKObjectFactory, placed the corresponding files in Q4mitk, added their register calls in QmitkRegisterClasses etc.

Committed in revision 16587.

Bug is now an open source and assigned to Mr Maleike for he cares about the integration in openCherry.

Please have a look in the class QmitkSlicesInterpolator. This class is always initialized with one specific multiwidget:
void Initialize(mitk::ToolManager* toolManager, QmitkStdMultiWidget* multiWidget);
After initialization, the multiwidget cannot be (ex)changed- as the new platform may have multiple widgets, this has to be redesigned.

I opened a new specific T2080. This metabug can be closed, since it is meta and most work is done. Further work should be documented in specific bugs.

Merging "applicazion modules" component with "ExtApp plugins"