Page MenuHomePhabricator

A Warning in the header for MikronTracking prevents compiling
Closed, WontfixPublic

Description

Problems with warning as errors. Either fix the warning or make an exception that this warning is not treated as an error.
This was tested with Windows 32 bit.

Event Timeline

User franza has pushed new remote branch:

bug-17463-DisableWaringsAsErrorsForRelease2014-03

[b159ba]: Merge branch 'bug-17463-DisableWaringsAsErrorsForRelease2014-03'

Merged commits:

2014-03-11 16:53:45 Alfred Franz [592e77]
disabled WARNINGS_AS_ERRORS for IGT because MicronTracker doesn't work (see T17463 for details)

Consultation with Sascha:
generally, one should see which kind of warnings are created by the external library and then selectively exclude them from causing errors in the cmake file. This of course should only be done if the warnings are presumably uncritical (e.g. unused variable).

However, this approach is not feasible for tracking devices as users of IGT can in principle connect arbitrary tracking devices and testing all of them for the type of warnings etc. is not possible.

This means for IGT it would be best to deactivate warnings c.f. external libraries from causing errors. Sascha said this is not straightforward and would need investigation. Will create separate feature request for this.

It seems as there is no suitable solution for this problem at the moment. So I we disable "warnings as errors" for the IGT module until there is a solution.

I will close this bug...