Page MenuHomePhabricator

Segmentation wipe tool does not remove segmentation
Closed, ResolvedPublic

Description

Segmentation wipe tool does not remove a segmentation but instead extends the segmentation. It seems to have the same behavior as the paint tool. The inverse behavior is expected.

Event Timeline

What happens if you press and hold Ctrl during painting/wiping? This is supposed to invert the current tool.

(In reply to Stefan Kislinskiy from comment #1)

What happens if you press and hold Ctrl during painting/wiping? This is
supposed to invert the current tool.

The paint tool works as expected in both modes (Ctrl pressed, Ctrl not pressed).
The inversion itself also works for the wipe tool. But the initial configuration of the wipe tool seems to be wrong:

  • Ctrl not pressed: draws pixels
  • Ctrl pressed: erases pixels

This is exactly what the paint tool does in both modes. I expect the paint tool's inverse behavior for the wipe tool.

Can't reproduce it anymore after master update.

Re-opened bug.
Found steps to reproduce:

  • Select wipe tool
  • Increase tool size
  • Press 'Strg' and hold pressed
  • Move mouse (draws segmentation)
  • Release 'Strg'
  • Click left mouse button

From now on the wipe tool adds segmentations without pressing 'Strg'.

User kolbch has pushed new remote branch:

bug-18240-PaintBrushToolStatemachineCorrections

The statemachine was broken:

ctrl+moving the mouse started the action "Move" which creates a feedback contour instead of just moving the cursor

the transition from inverted to neutral by pressing the left mouse button didn't invoke the "InvertLogic" action

[8f8438]: Merge branch 'bug-18240-PaintBrushToolStatemachineCorrections'

Merged commits:

2014-10-29 16:33:43 Christoph Kolb [a99208]
fix order of actions and add previously undefined transition


2014-10-29 16:05:05 Christoph Kolb [83b9ce]
use correct mousemove events and state transitions

[86cf71]: Merge branch 'bug-18240-PaintBrushToolStatemachineCorrections'

Merged commits:

2014-10-29 18:04:10 Christoph Kolb [14c31b]
COMP: temporary test deactivation until new mitk-data is uploaded

[33fd36]: Merge branch 'bug-18240-PaintBrushToolStatemachineCorrections'

Merged commits:

2014-10-29 18:10:30 Christoph Kolb [40c517]
reactivate wipe tool interaction test

[32353a]: Merge branch 'bug-18240-PaintBrushToolStatemachineCorrections'

Merged commits:

2014-10-30 11:42:33 Christoph Kolb [ba8c01]
COMP: temporary fix by reordering test calls