Page MenuHomePhabricator

kirchnth (Thomas Kirchner)
Not So Nice Person

Projects

User Details

User Since
Aug 1 2016, 12:10 PM (190 w, 6 d)

Recent Activity

Nov 19 2019

kirchnth closed T19099: 2D Streaming in mitkWorkbench/BlueBerry (?) as Resolved.

This has been closed years ago - not sure why it has been reopened.

Nov 19 2019, 4:45 PM · Bugzilla, MITK

Nov 12 2019

kirchnth triaged T26808: mitkPhotoacousticVolumeTest fails on Ubuntu (only) as Normal priority.
Nov 12 2019, 5:48 PM · MITK, Photoacoustics
kirchnth closed T26798: mitkPAFilterServiceTest fails as Resolved.
Nov 12 2019, 5:45 PM · MITK, Photoacoustics

Nov 11 2019

kirchnth committed rMITK8a6a7a858b95: Merge branch 'T26759-radiusfixforrealz' (authored by kirchnth).
Merge branch 'T26759-radiusfixforrealz'
Nov 11 2019, 7:02 PM
kirchnth committed rMITK5e48a9541d24: Merge branch 'master' of https://phabricator.mitk.org/source/mitk (authored by kirchnth).
Merge branch 'master' of https://phabricator.mitk.org/source/mitk
Nov 11 2019, 7:02 PM
kirchnth committed rMITKa0185365fe79: fixed usedLines on GPU + minor cleanup (authored by kirchnth).
fixed usedLines on GPU + minor cleanup
Nov 11 2019, 6:58 PM
kirchnth committed rMITK52ea3168637f: elementPositions[] went out of range causing weird apparent apodization (authored by kirchnth).
elementPositions[] went out of range causing weird apparent apodization
Nov 11 2019, 5:29 PM

Nov 8 2019

kirchnth committed rMITK49ac2ed488ee: rewrote that code because we couldn't understand it - there are still issues WIP (authored by kirchnth).
rewrote that code because we couldn't understand it - there are still issues WIP
Nov 8 2019, 6:49 PM
kirchnth committed rMITKd66b6b5b92dc: this should fix the test issue by replication of the behavior of GPU code on… (authored by kirchnth).
this should fix the test issue by replication of the behavior of GPU code on…
Nov 8 2019, 3:13 PM
kirchnth added a reverting change for rMITKc5c54c6401e3: something we tried out - but it broke apodization: rMITK7d111b31db9b: Revert "something we tried out - but it broke apodization".
Nov 8 2019, 3:13 PM
kirchnth committed rMITK7d111b31db9b: Revert "something we tried out - but it broke apodization" (authored by kirchnth).
Revert "something we tried out - but it broke apodization"
Nov 8 2019, 3:13 PM
kirchnth committed rMITKc5c54c6401e3: something we tried out - but it broke apodization (authored by kirchnth).
something we tried out - but it broke apodization
Nov 8 2019, 1:05 PM
kirchnth committed rMITKf3ffab2e6e6a: minor leftover gui issue (authored by kirchnth).
minor leftover gui issue
Nov 8 2019, 9:51 AM
kirchnth added a reverting change for rMITK712937da269b: this fixes a minor leftover style issue in the plugin: rMITK1eadc1a7d2ca: Revert "this fixes a minor leftover style issue in the plugin".
Nov 8 2019, 9:51 AM
kirchnth committed rMITK1eadc1a7d2ca: Revert "this fixes a minor leftover style issue in the plugin" (authored by kirchnth).
Revert "this fixes a minor leftover style issue in the plugin"
Nov 8 2019, 9:51 AM
kirchnth committed rMITK712937da269b: this fixes a minor leftover style issue in the plugin (authored by kirchnth).
this fixes a minor leftover style issue in the plugin
Nov 8 2019, 9:51 AM
kirchnth triaged T26798: mitkPAFilterServiceTest fails as High priority.

sorry that this took me a month to get to

Nov 8 2019, 9:35 AM · MITK, Photoacoustics
kirchnth added a comment to T26798: mitkPAFilterServiceTest fails.

this is due to radius behavior changes

Nov 8 2019, 9:34 AM · MITK, Photoacoustics
kirchnth created T26798: mitkPAFilterServiceTest fails.
Nov 8 2019, 9:33 AM · MITK, Photoacoustics

Nov 7 2019

kirchnth placed T23189: Saving large (nrrd) files is ridiculously slow due to compression up for grabs.
Nov 7 2019, 5:30 PM · MITK
kirchnth closed T26683: make ippai modularerer as Wontfix.
Nov 7 2019, 5:28 PM · CAMI, Photoacoustics
kirchnth closed T26797: PA Beamforming Plugin redesign as Resolved.
Nov 7 2019, 5:13 PM · Photoacoustics, MITK
kirchnth committed rMITKd3cd783b76af: Merge branch 'T26797-redesignPAplugin' (authored by kirchnth).
Merge branch 'T26797-redesignPAplugin'
Nov 7 2019, 3:56 PM
kirchnth committed rMITK5fc6c8f501a8: some more tooltips and minor changes (authored by kirchnth).
some more tooltips and minor changes
Nov 7 2019, 3:55 PM
kirchnth committed rMITK0cfd3226413b: redesigned UI for PA image processing and set new sensible defaults and… (authored by kirchnth).
redesigned UI for PA image processing and set new sensible defaults and…
Nov 7 2019, 3:21 PM
kirchnth added a comment to T26797: PA Beamforming Plugin redesign.

Pushed new branch T26797-redesignPAplugin.

Nov 7 2019, 3:21 PM · Photoacoustics, MITK
kirchnth triaged T26797: PA Beamforming Plugin redesign as Wishlist priority.
Nov 7 2019, 12:47 PM · Photoacoustics, MITK
kirchnth closed T26796: PA Beamforming writes the bf result of the first Slice in all Slices as Resolved.
Nov 7 2019, 12:44 PM · Photoacoustics, MITK
kirchnth closed T26785: camiPhotoacousticsWorkstation build config does not build Commandline Tool as Resolved.
Nov 7 2019, 12:43 PM · MITK, Photoacoustics
kirchnth committed rMITK3899f0a19eb9: camiPhotoacousticsWorkstation buildconfig does not build the relevant command… (authored by kirchnth).
camiPhotoacousticsWorkstation buildconfig does not build the relevant command…
Nov 7 2019, 12:43 PM

Nov 6 2019

kirchnth committed rMITK40e7fb0dd829: Merge branch 'T26796-openclindexfix' (authored by kirchnth).
Merge branch 'T26796-openclindexfix'
Nov 6 2019, 6:21 PM
kirchnth committed rMITK58735c09042a: fixed an index that caused reading from slice 0 always (authored by kirchnth).
fixed an index that caused reading from slice 0 always
Nov 6 2019, 6:20 PM
kirchnth added a comment to T26796: PA Beamforming writes the bf result of the first Slice in all Slices.

Pushed new branch T26796-openclindexfix.

Nov 6 2019, 6:20 PM · Photoacoustics, MITK
kirchnth committed rMITK542c14204f31: the slice index was missing in DAS.cl for curved arrays ... fixed that oversight (authored by kirchnth).
the slice index was missing in DAS.cl for curved arrays ... fixed that oversight
Nov 6 2019, 6:13 PM
kirchnth added a comment to T26796: PA Beamforming writes the bf result of the first Slice in all Slices.

Pushed new branch T26796-opencloversightfixed.

Nov 6 2019, 6:13 PM · Photoacoustics, MITK
kirchnth added a comment to T26796: PA Beamforming writes the bf result of the first Slice in all Slices.

traced the error to the DAS.cl

Nov 6 2019, 5:43 PM · Photoacoustics, MITK
kirchnth updated subscribers of T26796: PA Beamforming writes the bf result of the first Slice in all Slices.
Nov 6 2019, 5:21 PM · Photoacoustics, MITK
kirchnth triaged T26796: PA Beamforming writes the bf result of the first Slice in all Slices as High priority.
Nov 6 2019, 5:19 PM · Photoacoustics, MITK
kirchnth added a revision to T26785: camiPhotoacousticsWorkstation build config does not build Commandline Tool: Unknown Object (Differential Revision).
Nov 6 2019, 4:17 PM · MITK, Photoacoustics
kirchnth committed rMITKbf78254487a4: included command line tools in build configuration (authored by kirchnth).
included command line tools in build configuration
Nov 6 2019, 2:57 PM
kirchnth added a comment to T26785: camiPhotoacousticsWorkstation build config does not build Commandline Tool.

Pushed new branch T26785-incluceCLtoolsInBuildConfig.

Nov 6 2019, 2:57 PM · MITK, Photoacoustics
kirchnth added a project to T26785: camiPhotoacousticsWorkstation build config does not build Commandline Tool: MITK.
Nov 6 2019, 2:57 PM · MITK, Photoacoustics
kirchnth added a comment to T26795: scrolling in a 2d render window scrolls simultaneously in all three directions .

also occurs in clean build - in addition: opening the Workbench for the first time after build causes a crash

Nov 6 2019, 2:35 PM · Noteworthy, MITK
kirchnth added a comment to T26795: scrolling in a 2d render window scrolls simultaneously in all three directions .

note that I did not use a clean build

Nov 6 2019, 2:30 PM · Noteworthy, MITK
kirchnth triaged T26795: scrolling in a 2d render window scrolls simultaneously in all three directions as High priority.
Nov 6 2019, 2:29 PM · Noteworthy, MITK

Oct 28 2019

kirchnth committed rMITKad875063ff2b: Merge branch 'T26759-quick-conversion-fix' (authored by kirchnth).
Merge branch 'T26759-quick-conversion-fix'
Oct 28 2019, 2:57 PM
kirchnth committed rMITKc436f649e29a: caused gcc warning (authored by kirchnth).
caused gcc warning
Oct 28 2019, 2:56 PM

Sep 18 2019

kirchnth closed T26690: Photoacoustic Image Processing has WarningsAsErrors with gcc as Resolved.

this should do it

Sep 18 2019, 6:09 PM · Photoacoustics, MITK
kirchnth committed rMITKfc81837e4f63: Merge branch 'T26690-fixPAgccWarningsInCommandLineToolToo' (authored by kirchnth).
Merge branch 'T26690-fixPAgccWarningsInCommandLineToolToo'
Sep 18 2019, 6:00 PM
kirchnth added a comment to T26690: Photoacoustic Image Processing has WarningsAsErrors with gcc.

Pushed new branch T26690-fixPAgccWarningsInCommandLineToolToo.

Sep 18 2019, 5:59 PM · Photoacoustics, MITK
kirchnth committed rMITK3d0bcd2006c5: Merge branch 'T26690-fixPAgccWarnings' (authored by kirchnth).
Merge branch 'T26690-fixPAgccWarnings'
Sep 18 2019, 5:38 PM
kirchnth added a comment to T26690: Photoacoustic Image Processing has WarningsAsErrors with gcc.

Pushed new branch T26690-fixPAgccWarnings.

Sep 18 2019, 5:37 PM · Photoacoustics, MITK
kirchnth triaged T26690: Photoacoustic Image Processing has WarningsAsErrors with gcc as High priority.
Sep 18 2019, 4:31 PM · Photoacoustics, MITK

Sep 17 2019

kirchnth added a comment to T26683: make ippai modularerer.

nvmd about making deeplearning dependencies optional - seems like this is not practical

Sep 17 2019, 3:42 PM · CAMI, Photoacoustics
kirchnth triaged T26683: make ippai modularerer as Normal priority.
Sep 17 2019, 2:34 PM · CAMI, Photoacoustics

Mar 13 2019

kirchnth closed T25122: PA Bandpass shifts images for each slice a bit more as Invalid.
Mar 13 2019, 2:53 PM · MITK, Photoacoustics
kirchnth moved T25714: Write volume reconstruction from wip to Backlog on the Photoacoustics board.
Mar 13 2019, 2:51 PM · CAMI, Photoacoustics

Sep 17 2018

kirchnth added a comment to T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04].

is the local oigtl zipped source files in that last commit

Sep 17 2018, 2:16 PM · Photoacoustics, Restricted Project, IGT, MITK

Sep 14 2018

kirchnth committed rMITKd78ede1444c1: new ansatz to fix T24778 oitgl release 3 doesnt install as is (but only on… (authored by kirchnth).
new ansatz to fix T24778 oitgl release 3 doesnt install as is (but only on…
Sep 14 2018, 4:00 PM
kirchnth added a comment to T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04].

Pushed new branch T24778--update-oigtl-to-current-master.

Sep 14 2018, 3:59 PM · Photoacoustics, Restricted Project, IGT, MITK

Sep 13 2018

kirchnth moved T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04] from Backlog to wip on the Photoacoustics board.
Sep 13 2018, 2:07 PM · Photoacoustics, Restricted Project, IGT, MITK

Sep 7 2018

kirchnth added a comment to T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04].

@franza yes i had the same problem - i did not get around to have a close look at it yet :/

Sep 7 2018, 12:36 PM · Photoacoustics, Restricted Project, IGT, MITK

Aug 13 2018

groehl awarded T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04] a The World Burns token.
Aug 13 2018, 1:31 PM · Photoacoustics, Restricted Project, IGT, MITK
groehl awarded T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04] a The World Burns token.
Aug 13 2018, 1:30 PM · Photoacoustics, Restricted Project, IGT, MITK

Jul 24 2018

kirchnth moved T25122: PA Bandpass shifts images for each slice a bit more from Backlog to wip on the Photoacoustics board.
Jul 24 2018, 1:48 PM · MITK, Photoacoustics

Jul 23 2018

kirchnth added a parent task for T24679: Motion compensation for PAUS imaging: Unknown Object (Maniphest Task).
Jul 23 2018, 8:13 PM · MITK, Photoacoustics
kirchnth added a parent task for T25122: PA Bandpass shifts images for each slice a bit more: Unknown Object (Maniphest Task).
Jul 23 2018, 8:12 PM · MITK, Photoacoustics
kirchnth triaged T25122: PA Bandpass shifts images for each slice a bit more as Normal priority.
Jul 23 2018, 8:11 PM · MITK, Photoacoustics
kirchnth added a comment to T24679: Motion compensation for PAUS imaging.

@adler is this finished and merged back to the master?

Jul 23 2018, 3:01 PM · MITK, Photoacoustics
kirchnth closed T23538: Annotation Rendering Tests fail as Resolved.

old and obsolete task

Jul 23 2018, 2:53 PM · Restricted Project, MITK

Jul 11 2018

kirchnth committed rMITK3125db623bed: fixed build warnings/errors for gcc (authored by kirchnth).
fixed build warnings/errors for gcc
Jul 11 2018, 4:21 PM

Jul 2 2018

kirchnth committed rMITK3c252649449d: Merge branch 'T25018-memoryfix' (authored by kirchnth).
Merge branch 'T25018-memoryfix'
Jul 2 2018, 2:21 PM
kirchnth committed rMITKa9db46002c1d: this fixes a memory leak (authored by kirchnth).
this fixes a memory leak
Jul 2 2018, 2:20 PM

Jun 25 2018

kirchnth added a comment to T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04].

@kislinsk can you upload https://github.com/openigtlink/OpenIGTLink/archive/v3.0.tar.gz under the name OpenIGTLink-release-3.0.tar.gz please?
cf. T24971

Jun 25 2018, 6:54 PM · Photoacoustics, Restricted Project, IGT, MITK
kirchnth lowered the priority of T24971: .zip files do not extract in superbuild (Windows non-NTFS file system) from High to Low.

fixed it there but i'll leave it open because it remains a general issue

Jun 25 2018, 3:26 PM · Restricted Project, IGT, MITK
kirchnth updated subscribers of T24971: .zip files do not extract in superbuild (Windows non-NTFS file system).
Jun 25 2018, 3:10 PM · Restricted Project, IGT, MITK
kirchnth renamed T24971: .zip files do not extract in superbuild (Windows non-NTFS file system) from openCV does not extract in superbuild (Windows) to .zip files do not extract in superbuild (Windows non-NTFS file system).
Jun 25 2018, 3:10 PM · Restricted Project, IGT, MITK
kirchnth added a comment to T24971: .zip files do not extract in superbuild (Windows non-NTFS file system).

with the .tar.gz and new hash it works

Jun 25 2018, 3:09 PM · Restricted Project, IGT, MITK
kirchnth claimed T24971: .zip files do not extract in superbuild (Windows non-NTFS file system).

yep those seem to work
also: apparently this issue occurs when building on non-NTFS disks i.e. exFAT (testing now but we might think about only having .tar.gz files on thirdparty)

Jun 25 2018, 3:02 PM · Restricted Project, IGT, MITK
kirchnth added a comment to T24971: .zip files do not extract in superbuild (Windows non-NTFS file system).

Note that the issue seems to occur for .zip files from thirdparty in general - but not on all windows machines
the .tar.gz files all work fine

Jun 25 2018, 2:55 PM · Restricted Project, IGT, MITK
kirchnth added a comment to T24971: .zip files do not extract in superbuild (Windows non-NTFS file system).

Note that giving new tasks a high priority most probably means that it is important enough that you work on it instead of expecting someone will do so. So go ahead. :-)

Jun 25 2018, 2:52 PM · Restricted Project, IGT, MITK

Jun 19 2018

kirchnth added a parent task for T24908: Add hardware signal delay compensation to Photoacoustics Algorithms Module: Unknown Object (Maniphest Task).
Jun 19 2018, 9:01 PM · MITK, Photoacoustics
kirchnth committed rMITKa1bf947fe208: Merge branch 'T24921-fixOOM' (authored by kirchnth).
Merge branch 'T24921-fixOOM'
Jun 19 2018, 7:30 PM
kirchnth committed rMITK14601dd242e1: changed to more default default values (authored by kirchnth).
changed to more default default values
Jun 19 2018, 5:32 PM
kirchnth committed rMITK6d8e179747c3: Fixed the Bandpass Frequencies to have the correct meaning and range Added a… (authored by kirchnth).
Fixed the Bandpass Frequencies to have the correct meaning and range Added a…
Jun 19 2018, 5:28 PM
kirchnth committed rMITK4d86c7a00cc9: Merge branch 'master' of https://phabricator.mitk.org/source/mitk into T24921… (authored by kirchnth).
Merge branch 'master' of https://phabricator.mitk.org/source/mitk into T24921…
Jun 19 2018, 5:28 PM
kirchnth committed rMITKaf3940244436: fixes gcc compile warnings (initialization) (authored by kirchnth).
fixes gcc compile warnings (initialization)
Jun 19 2018, 2:28 PM

Jun 8 2018

kirchnth committed rMITK71faba58d154: Merge branch 'T24740-PhotoacousticsAlgorithms-Tests' (authored by kirchnth).
Merge branch 'T24740-PhotoacousticsAlgorithms-Tests'
Jun 8 2018, 4:38 PM
kirchnth closed T24740: Write tests for PhotoacousticsAlgorithms as Resolved.

fixed that band pass re-sampling and will now merge it into master.

Jun 8 2018, 3:42 PM · Photoacoustics, MITK
kirchnth committed rMITK69f2056cf13b: fixed the check power of two check and resampling for the band pass filter also… (authored by kirchnth).
fixed the check power of two check and resampling for the band pass filter also…
Jun 8 2018, 3:37 PM

Jun 7 2018

kirchnth committed rMITK47fd4fbb5097: removed refactoring errors (authored by kirchnth).
removed refactoring errors
Jun 7 2018, 4:50 PM
kirchnth added a comment to T24740: Write tests for PhotoacousticsAlgorithms.
[529.464] Instantiating BandpassFilter...
[529.464] Instantiating BandpassFilter...[Done]
[532.181] SingleVoxel: 0.514558
[532.181] HighPass: 0
[532.181] LowPass: 1e+06
[532.181] cutoffPixelHighPass: 0
[532.181] cutoffPixelLowPass: 1023.5
[532.771] Destructed BandpassFilter.
[532.771] [PhotoacousticFilterService] destructed filter service
terminate called after throwing an instance of 'itk::ExceptionObject'
  what():  /home/thomaskirchner/projects/refac/mitk-superbuild/ep/src/ITK/Modules/Core/Common/src/itkMultiThreader.cxx:399:
itk::ERROR: MultiThreader(0x7efc8800bec0): Exception occurred during SingleMethodExecute
/home/thomaskirchner/projects/refac/mitk/Modules/PhotoacousticsAlgorithms/include/../ITKFilter/ITKUltrasound/itkVnlFFT1DRealToComplexConjugateImageFilter.hxx:66:
itk::ERROR: VnlFFT1DRealToComplexConjugateImageFilter(0x7efc88012890): Illegal Array DIM for FFT
Jun 7 2018, 4:49 PM · Photoacoustics, MITK

May 29 2018

kirchnth committed rMITK1f437c4ead6a: fixed faulty function call in PA plugin (authored by kirchnth).
fixed faulty function call in PA plugin
May 29 2018, 4:30 PM
kirchnth committed rMITKd7b75b31e65b: fixes for linux gpu implementations (authored by kirchnth).
fixes for linux gpu implementations
May 29 2018, 4:00 PM

May 25 2018

kirchnth committed rMITK84f74a33b297: switched openigtlink lib used to release 3 and dealt with the ensuing build… (authored by kirchnth).
switched openigtlink lib used to release 3 and dealt with the ensuing build…
May 25 2018, 4:13 PM
kirchnth added a comment to T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04].

Pushed new branch T24778-update-oigtl-to-v3.

May 25 2018, 4:12 PM · Photoacoustics, Restricted Project, IGT, MITK

May 15 2018

kirchnth triaged T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04] as High priority.
May 15 2018, 3:43 PM · Photoacoustics, Restricted Project, IGT, MITK
kirchnth added a comment to T24333: Noteworthy new features since MITK 2016.11.

T22228 is a new plugin with a lot of beamforming functionality for photoacoustics and ultrasound

May 15 2018, 2:22 PM · MITK (2018-04)

Apr 19 2018

kirchnth closed T24688: Memory leak while cropping in PA image processing as Resolved.
Apr 19 2018, 7:18 PM · Photoacoustics, MITK
kirchnth committed rMITK9cc018487fcb: Merge branch 'T24688-leak-quick-fix' (authored by kirchnth).
Merge branch 'T24688-leak-quick-fix'
Apr 19 2018, 7:17 PM