Page MenuHomePhabricator

Eigen build fails for VS 2013 is CMake version is too old
Closed, ResolvedPublic

Description

The Eigen CMake configuration may fail if the CMake version is too old. This bug occurs with Visual Studio 2013.

Resolution: Set CMake minimum required version for MSVS 2013 to CMake 3.02

Event Timeline

User fetzer has pushed new remote branch:

bug-18302-cmake-configure-error-for-vs-2013

[a9e8f2]: Merge branch 'bug-18302-cmake-configure-error-for-vs-2013'

Merged commits:

2014-10-17 13:19:09 Andreas Fetzer [1074cd]
Added regex for comparison


2014-10-17 13:05:39 Andreas Fetzer [e1a285]
Added check for Visual Studio 2013 and setting required CMake version to 3.0.2 in that case

User goch has pushed new remote branch:

bug-18302-correct-cmake-version

[2302bf]: Merge branch 'bug-18302-correct-cmake-version'

Merged commits:

2014-10-20 10:19:32 Caspar Goch [18dce7]
Set valid minimum version

I'm getting now other errors on configuration, seems to be some side-effect of a new CMake policy:

http://www.cmake.org/cmake/help/v3.0/policy/CMP0045.html

For some reasons it fails with a non-existent CoreApp target error in top-level CMakeLists.txt. It should only warn, and does so for other missing targets. Maybe a CMake bug or strange effect. I will fix it for this one, but maybe we can look for all the warnings on non-existing targets and fix them.

[6716b3]: Merge branch 'bug-18302-cmake-configure-error-for-vs-2013'

Merged commits:

2014-10-25 03:01:57 Marco Nolden [0934e6]
Fixed non-existing target configuration error for CMake 3 / VS 2013

Ok, my fix is really just a quick fix to suppress the error, I did not check why the target doesn't exist.

Since we changed our Eigen dependency to just the header part of this library (and the according CMake script is very basic now), I guess CMake 3 is not longer a requirement for MSVC 2013 and the initial bug fix could be reverted. Marco, can you check if works with CMake 2.8.* again?

I did a quick check and it seems to work. So you could change the minimum required version again but the quick fix should stay since people will probably start using CMake 3 soon. But I could also live with leaving it in the current state, since it only affect VS2013 users and forces them to use a faster CMake version ;)

[48d085]: Merge branch 'bug-18302-cmake-configure-error-for-vs-2013'

Merged commits:

2014-10-28 10:49:48 Andreas Fetzer [3cf245]
Changed minimum required cmake version in case of VS 2013 back to 2.8.9 since the Eigen issue is fixed with T18050