Page MenuHomePhabricator

DICOM plugin fails an assertion about missing icons
Closed, ResolvedPublic

Description

In debug mode I start the workbench and click on the DICOM icon. The stack trace shows that it fails during the creation of a ctkFileDialog object, deep in Qt.

see attachment.

I found only this, slightly related: https://bugs.kde.org/show_bug.cgi?id=324177

Does our icon theme have a name?

I did not test on linux.

assert.jpg (305×483 px, 38 KB)

Event Timeline

The reason for this seems to be a missing "folder" icon in our themes. Qt implicitly uses it for the file dialog.

User goch has pushed new remote branch:

bug-18392-add-missing-icon

[fb0d96]: Merge branch 'bug-18392-add-missing-icon'

Merged commits:

2014-11-05 10:33:30 Caspar Goch [8b4e17]
Add folder icons

As an aside, the icon themes currently bundled with MITK are named "tango" and "awesome" respectively.

Icons are located in Plugins/org.mitk.gui.qt.ext/resources/icons/<themename>

I can not reproduce it anymore, so I think so. Closing.

Reopening. Doesn't work on Windows in debug mode as an assertion fails regarding an empty theme name.

ASSERT: "!themeName.isEmpty()" in file image\qiconloader.cpp, line 238

Can you tell which icon it expects?

go-up
view-list-icons
view-list-details

[37f1fc]: Merge branch 'bug-18392-add-missing-icon'

Merged commits:

2014-11-05 23:27:59 Caspar Goch [6a53c0]
Added even more icons

Both themes do not provide the required list icons. For font awesome I used some of the other list icons. The tango project does not, unfortunately contain any list icons, so I created some according to the tango colour scheme. These we might want to replace with some drawn by someone with actual artistic talent and more time.

Does it work now?

I'll check later, thank you.

BTW: Last night I recognized that the Workbench has a strange application icon in the taskbar (Windows). 4 red dots like the 4-side of a dice.

This should not be caused by the icon theme as the application icon is set differently, but I will take a look in the code.

Stefan, your issue might potentially be related to [1].

Is the icon in the top left corner still correct and only the icon in the taskbar shows this strange behaviour?

[1] http://stackoverflow.com/questions/1551605/how-to-set-applications-taskbar-icon-in-windows-7

Sorry, nevermind. It's the Strawberry Perl icon which is used for the command line window since I installed Perl... :-)