Status | Assigned | Task | ||
---|---|---|---|---|
Restricted Maniphest Task | ||||
Resolved | None | T18603 Make MITK compatible with VTK 6.2 |
Event Timeline
It would be nice to have it in the release, but there is a potential showstopper:
http://vtk.org/Bug/view.php?id=14598
Sascha already commented in VTK's gerrit review system about the proposed changes and currently it seems VTK is not planning to fix this before 6.2. Since our superbuild uses "make install" for the external projects we would need some workaround. For general compatibility checks, release build work though.
I tried a bit to fix this in VTK, but this does *not* work (in GUISupport/Qt/PluginInstall.cmake.in), since this is used to generate a post_install script in which generator expressions are not replaced:
FILE(INSTALL DESTINATION "${VTK_INSTALL_QT_PLUGIN_DIR}" TYPE SHARED_LIBRARY
FILES "${VTK_LIB_DIR}${VTK_LIBSUBDIR}/@CMAKE_SHARED_LIBRARY_PREFIX@QVTKWidgetPlugin@CMAKE_SHARED_LIBRARY_SUFFIX@$<$<CONFIG:Debug>:d>")
The VTK we are currently using has the same issue. Our patch just "disables" the install command for the VTK Qt designer plug-in. This was a quick and dirty "solution".
Everything works, except for mitkFiberExtractionTest:
334: check inside mask extraction[7.500] Unequal number of points in fiber 8!
334: [7.500] 2 vs. 3
334: [FAILED]
334: +--> in [...]/Testing/mitkFiberExtractionTest.cpp, line 103, expression is false: "inside->Equals(testFibs)"
1/1 Test #334: mitkFiberExtractionTest ..........***Failed 7.53 sec
Peter, could you check this?
because of very minor fixes in mitkSurfaceVtkMapper3D:
replace vtkOpenGLPolyDataMapper with vtkPainterPolyDataMapper
[b2666e]: Merge branch 'bug-18603-MigrateToVTK6-2'
Merged commits:
2015-03-11 21:29:21 Christoph Kolb [1396f0]
new testdata for fiberextractiontest
2015-03-06 16:40:09 Christoph Kolb [2d2b6f]
vtk 6.2 changes in diffusionImaging
2015-03-06 16:06:09 Christoph Kolb [b8e926]
set correct MD5 hash for vtk 6.2.0
2015-03-06 15:50:14 Christoph Kolb [8da18d]
set vtk to version 6.2.0 and fix errors
[23f0ee]: Merge branch 'bug-18603-MigrateToVTK6-2'
Merged commits:
2015-03-18 14:53:10 Christoph Kolb [e27e40]
COMP: disable mitkSurfaceDepthSortingTest in windows
[62d635]: COMP Merge branch 'bug-18603-comp-fix'
Merged commits:
2015-03-18 15:07:57 Andreas Fetzer [703b9b]
COMP Fixed CMake error
2015-03-18 15:05:33 Andreas Fetzer [e48513]
Merge remote-tracking branch 'origin/master' into bug-18603-comp-fix
2015-03-18 13:47:38 Andreas Fetzer [b97587]
Merge branch 'master' of mitk.org:MITK
2015-03-15 17:57:42 Andreas Fetzer [6fea51]
Merge branch 'bug-18845-fixes-for-cmake32'
2015-03-15 17:56:53 Andreas Fetzer [81dada]
Merge branch 'master' of mitk.org:MITK
2015-03-11 17:22:01 Andreas Fetzer [4a579f]
Merge branch 'bug-18831-compile-error-in-mbilog-mac'
2015-03-11 17:21:44 Andreas Fetzer [6e50c5]
Merge branch 'master' of mitk.org:MITK
[a2045d]: COMP Merge branch 'bug-18603-comp-fix'
Merged commits:
2015-03-18 15:40:04 Andreas Fetzer [1ad172]
COMP fixed AddCustomModuleTest for windows