Page MenuHomePhabricator
Create Task
Maniphest T19229

Destruction in berryHelpPluginActivator broken - assertion fails
Closed, ResolvedPublic
Actions

Description

I am getting an assertion failure "Cannot send events to objects owned by a different thread. ..." from Qt when quitting mitkWorkbench after having opened the help (via the F1 menu entry).

This is during the destruction of the berryQHelpEngineWrapper which is executing in a different thread (as far as I got it). Such objects should not be deleted like this but using QObject's deleteLater.

QScopedPointer offers a template parameter to specify the usage of deleteLater.

I already fixed the code locally, will publish the branch right away.

error_help_close.pg.JPG (328×511 px, 41 KB)

Event Timeline

maleike added projects: MITK, Bugzilla.Aug 12 2015, 12:07 PM
• git-user added a subscriber: • git-user.Aug 12 2015, 12:10 PM

User maleike has pushed new remote branch:

bug-19229-berryHelpPluginActivator-deleteLater
maleike added a subscriber: maleike.Aug 12 2015, 12:13 PM

[e1c0de]: Merge branch 'bug-19229-berryHelpPluginActivator-deleteLater'

Merged commits:

2015-08-12 11:54:21 Daniel Maleike [dcb5e2]
Use deleteLater() on helpEngine. Avoids a crash.

• cordes added a subscriber: • cordes.Aug 12 2015, 4:31 PM

On Qt4 the instruction QScopedPointerDeleteLater is not available. I reopened the bug.

maleike added a comment.Aug 12 2015, 4:44 PM

Jonas, I don't have a Qt4 environment at hand. As you observed this, I assume you do?

I'd suggest a "#ifdef Qt4 .." and then try something like

Object* o = pointer.take();
o->deleteLater();

(in the destructor of the activator class where destruction would otherwise happen automatically via the QScopedPointer)

Could you perhaps try this, please?

• git-user added a comment.Aug 12 2015, 7:19 PM

User cordes has pushed new remote branch:

bug-19229-fixberryHelpPluginActivatorQScoppedPointerDeleteLater
• cordes added a comment.Aug 12 2015, 7:20 PM

Hey Daniel, I couldn't reproduce the assertion on osx.
But I pushed a branch with the proposed fix.

Maybe you can take a short look at it. If it's okay I'll merge it asap.

• cordes added a comment.Aug 13 2015, 11:31 AM

[7128fa]: Merge branch 'bug-19229-fixberryHelpPluginActivatorQScoppedPointerDele

Merged commits:

2015-08-12 19:21:16 Jonas Cordes [f85a28]
Manual call of deleteLater (Qt4 fix)

• cordes added a comment.Aug 13 2015, 11:34 AM

Hey Daniel, I had to merge it now & thanks for the suggestion!

kislinsk edited projects, added MITK (2015-05-2); removed MITK.Aug 1 2016, 10:49 PM
MITK · MIC · IMSY · DKFZ