Page MenuHomePhabricator
Create Task
Maniphest T19460

Images imported via the MITK DICOM Browser cannot be renamed
Closed, WontfixPublic
Actions

Description

Consider the following two workflows:

I)

  1. Open MITK Workbench
  2. Load a Dicom image via drag&drop
  3. Double-click it in the datamanager

II)

  1. Open MITK Workbench
  2. Load a Dicom image via the DICOM Browser
  3. Double-click it in the datamanager

One would assume:
a) They will have the same default name before renaming
b) One will be able to rename both after the double click

This is not so. Instead the names will be different and I is renamable, II is not. This is due to
QVariant QmitkDataStorageTreeModel::data( const QModelIndex & index, int role ) const

where it is checked whether the node has
dicom.series.SeriesDescription
dicom.study.StudyDescription
dicom.patient.PatientsName

if that is the case the displayed node name is build from them and not editable (II). If not (I, as the properties are added to the BaseData instead of the DataNode) the generated name is used. For (II) the name property is not used at all. You can still change the displayed name by editing the dicom. properties, this is however not desirable.

Event Timeline

• goch added projects: MITK, Bugzilla.Dec 2 2015, 3:48 PM
• goch added a subscriber: • goch.Dec 2 2015, 4:25 PM

The original reason for having a non-renamable node was based on the idea that the dicom information provides a description that uniquely identifies that particular image data. There should not be a need to change that identifier.

However:

The result should be the same following I or II, this has to be fixed

Renaming should not be necessary, that also means that it should be possible to distinguish different data. Currently the Comboboxes show only the text to the first new line, which is not enough.
We also might want to keep the original information accessible and make clear the name in the data manager is just some display name/label (e.g. it turns a different color if it has been changed).

This should probably be discussed in the MITK meeting.

• goch added a comment.Dec 15 2015, 11:44 AM

It was decided that the label in the datamanager should just be a "display label", and thus should always be editable. However for the dicom information not to be lost:

a) A way should be implemented to see selected dicom information at a glance ( T19476 )

b) The display label should be constructed from selected the dicom information ( T19477 )

kislinsk closed this task as Wontfix.Jun 20 2018, 6:27 AM
kislinsk claimed this task.
kislinsk added a subscriber: kislinsk.
This task was automatically closed because it wasn't updated at least since July 2016 (over 2 years). Please re-open this task if you think that it is still relevant. This most probably means that you will resolve it.
MITK · MIC · IMSY · DKFZ