Page MenuHomePhabricator

Adapt C3js to make it more general
Closed, ResolvedPublic

Description

In T19972, there were done quite some changes in DIPP with the existing C3js Module.
Key changes:

  • x/y values given as parameter instead of image
  • many API changes to customize chart (e.g. labels)
  • new chart: Pie Chart

Integrate the changes back in MITK in the C3js Module and adapt dependencies (Statistics/Histogram plugin) accordingly.

Event Timeline

hentsch renamed this task from Integrate Chart changes to C3js to Adapt C3js to make it more general.May 8 2017, 2:17 PM
hentsch updated the task description. (Show Details)
hentsch added a subscriber: kislinsk.

waiting for @kislinsk feedback

Already had a first look. While it works and it is indeed more general as the first version, I'm not very happy with the interface/design of the classes. It's quite hard to understand, internal stuff is exposed, and it has a monolithic character. But no worries, I'll come up with something more constructive soon. :D

Got feedback from @kislinsk to change a bit the public functions and do polish.
Create a new integration-branch from master as quite some changes were done meanwhile.

feedback from @kirchnth branch doesn't build on Ubuntu

smartpointer conversion errors e.g.

[...]/Plugins/org.mitk.gui.qt.measurementtoolbox/src/internal/QmitkImageStatisticsView.cpp:185:56: error: conversion from 'itk::Statistics::Histogram<double>::Pointer {aka itk::SmartPointer<itk::Statistics::Histogram<double> >}' to non-scalar type 'itk::Statistics::Histogram<double>::ConstPointer {aka itk::SmartPointer<const itk::Statistics::Histogram<double> >}' requested
         this->m_CalculationThread->GetTimeStepHistogram(timestep);

I'm sure, not everything is perfect, but as version 1.0, its suitable

fixed some gcc warnings as errors - i still cant actually see a chart under ubuntu

I will investigate the Ubuntu problems

Chart works on my virtual machine (Ubuntu 16.04 with Qt 5.7)
@kirchnth tries again with Qt 5.7.

feedback from @kirchnth: it does work with Qt 5.7.
Leave it like this until now.
Advise from @kislinsk: Analyze shortly why it does not show chart on Ubuntu with Qt 5.6. Otherwise, set minimal Qt version to 5.7.