Page MenuHomePhabricator
Create Task
Maniphest T24011

ImageStatisticsView crashes after calculating image statistics
Closed, ResolvedPublic
Actions

Description

To reproduce:

  • open MITK and start the statistics plugin view.
  • load a DICOM image in the data manager
  • click on the data manager to trigger the statistics calculation

MITK crashes at void QmitkChartWidget::Impl::ClearData()in QmitkChartWidget.cpp when de-registering data from the web channel.
Message is: ASSERT: "m_connectionsCounter.contains(object)" in file c:\users\qt\work\qt\qtwebchannel\src\webchannel\signalhandler_p.h, line 299

Found this: https://bugreports.qt.io/browse/QTBUG-60250, which leads to https://codereview.qt-project.org/#/c/192174/

This does not happen with the MITK of other users.
Used current master and an older one from end of November. Qt version is 5.7.1

Revisions and Commits

rMITK MITK
rMITK7dfd74b4c38b Fixed T24011. Histogram is only shown if Qt 5.10 is used. Otherwise, an error…

Related Objects

Event Timeline

kalali triaged this task as Normal priority.Jan 5 2018, 3:05 PM
kalali created this task.
kalali mentioned this in T23972: Image statistics view does not work.Jan 5 2018, 5:38 PM
hentsch added a subscriber: hentsch.Jan 8 2018, 10:23 AM
kalali added a comment.Jan 8 2018, 10:25 AM

Happens currently only in debug configuration.

kalali mentioned this in T23919: Changing raw pointer to smart pointer in MITK chart.Jan 8 2018, 10:46 AM
kalali added a comment.Jan 8 2018, 11:03 AM

However, in both configurations the following message is printed to the console: onmessage is not a callable property of qt.webChannelTransport.

hentsch added a comment.Jan 10 2018, 3:40 PM

Confirmed (with random image).
Also crashed in debug with the same assert.
I assume, it's a Qt bug. Let's find someone with a newer Qt version.

hentsch added a comment.Jan 10 2018, 3:54 PM

It works with Qt 5.10, so it's apparently a Qt bug that has been fixed in Qt 5.9.
As the minimum Qt version is currently 5.6.0, we check for Qt version in measurementtoolbox plugin and won't build it if <Qt 5.9 is used.

hentsch claimed this task.Jan 10 2018, 4:07 PM
hentsch added a comment.Jan 11 2018, 2:57 PM

We don't check in measurements plugin, but in MitkChart, as the problem occured there with the QWebEngineView

hentsch added a subscriber: • hempe.Jan 12 2018, 9:11 AM

@hempe I think you also reported the bug some time ago. We finally have a solution 😸, but be aware that you have to upgrade to Qt 5.9 or newer if merged to master to use MitkChart.

hentsch added a comment.Jan 12 2018, 11:05 AM

Well, the bug is not resolved in Qt 5.9 and 5.9.1

• hempe added a comment.Jan 12 2018, 1:05 PM

It works for me. I have Qt 5.9.1 Visual Studio 2017 and Windows 10.

hentsch added a comment.Jan 12 2018, 1:40 PM

Pushed new branch T24011-imageStatisticsCrash.

hentsch added a comment.Jan 12 2018, 1:53 PM

Qt 5.9.3 doesn't work for me either.

hentsch removed hentsch as the assignee of this task.Jan 12 2018, 2:07 PM
hentsch added a comment.Jan 16 2018, 8:39 AM

Qt 5.10 does work. Finally.
Best option is to set Qt 5.10 as minimal version for MitkChart.
Bonus: we also can merge T22518 to master

hentsch added a subscriber: • kleina.Jan 16 2018, 8:39 AM
hentsch added a subscriber: • goch.Jan 19 2018, 9:31 AM

Spoke with @goch. He suggested to make MitkChart module optional.
Then, we would have to build two versions of the image statistics plugin:

  • for MitkChart with >=Qt 5.10
  • without MitkChart (histogram as table?)
hentsch added a subscriber: • ciccares.Jan 19 2018, 9:31 AM
hentsch claimed this task.Jan 19 2018, 10:22 AM
hentsch added a project: Restricted Project.
• goch added a comment.Jan 19 2018, 10:55 AM

Just to clarify, two versions of the plugin means just two different histogram widgets in the statistics view.

hentsch closed this task as Resolved by committing rMITK7dfd74b4c38b: Fixed T24011. Histogram is only shown if Qt 5.10 is used. Otherwise, an error….Jan 19 2018, 3:36 PM
hentsch mentioned this in rMITK2e4791397e38: Merge branch 'master' into T24011-imageStatisticsCrash.
hentsch mentioned this in rMITKb423c15bc345: Merge branch 'T24011-imageStatisticsCrash'.
hentsch added a commit: rMITK7dfd74b4c38b: Fixed T24011. Histogram is only shown if Qt 5.10 is used. Otherwise, an error….
hentsch mentioned this in rMITKde85ba32ca85: Merge branch 'T24011-imageStatisticsCrash'.Jan 22 2018, 3:00 PM
hentsch mentioned this in T23130: Statistics histogram not displayed under linux.Feb 1 2018, 1:41 PM
MITK · MIC · IMSY · DKFZ