Page MenuHomePhabricator

Datamanager property editing
Closed, ResolvedPublic

Assigned To
None
Authored By
zelzer
Sep 23 2009, 1:57 PM
Referenced Files
F322: propertyEditing.txt
Oct 5 2009, 11:46 AM
F321: datamanager_qmitk.patch
Sep 23 2009, 2:23 PM
F320: datamanager_qmitk.patch
Sep 23 2009, 1:58 PM

Description

Michi, can you please review the attached patch, which contains the following changes:

  • enable single click cell editing
  • use checkboxes instead of comboboxes for boolean properties
  • set the minimum and maximum values of spinboxes for integer properties

Event Timeline

zelzer added a subscriber: zelzer.

patch for better(?) editing behaviour

Changing editing triggers:

the properties table did not set any triggers, so the default was used (which seems to be DoubleClicked). The patch set the same triggers for both tables now:

setEditTriggers(QAbstractItemView::DoubleClicked | QAbstractItemView::SelectedClicked | QAbstractItemView::EditKeyPressed);

Maybe this is a good compromise?

i`ll check it. one slight change: added numeric limits min max values also for doublespinbox

One additional idea: We could make the editing behaviour a DataManager preference, where the user could enable or disable "single click editing".

Changerequest specification

About testing of item 1.: I guess you just forgot to write that you will start the application and verify that property editing works as expected :-)

[SVN revision 19457]
FIX (#2512): Reworked on property editing. Now properties may be edited using a single click. However, this behaviour may be changed by a preference in the DataManager Preference Page. Added numeric limits for SpinBoxes in QmitkPropertiesTableModel. Added an Exit action in the Main Window. Added a toolbar for the views in the main Window.

Is this really 3m3 relevant? Property list should not appear in 3m3 application, only changing of color and name in tree view. Please comment and check bug dependencies

removed dependency. bug is fixed anyway

Merging "applicazion modules" component with "ExtApp plugins"