Page MenuHomePhabricator

[ModelFitInspector] Performance if multiple bookmark points are added
Open, NormalPublic

Description

The update rate of the chartWidget drops considerably if multiple bookmark point (>3) are added and image positions are changed.
It it because of plotly/MitkChart issues? Or repeatedly called functions in ModelFitInspectorView?

Event Timeline

hentsch triaged this task as Normal priority.May 29 2019, 10:42 AM
hentsch created this task.

Substential amount of time is lost in the QmitChart widget between the emit signal on the c++ side and the JavaScript-Event, so in the web channel. As each trace/curve triggers its own signal that quickly piles up to a considerably latency.

We should investigate that. Either test the channel blocking/unblocking ability if it helps to communicate blockwise and not for each curve. If that does not help, we might need to rework the data structure and communication style to reduce the number of webchannels interactions.

Minimize web channel usage in the old implementation to reduce the delay to an acceptable amount.
If blocking realy helps must be evaluated.

But I think a rework is needed in the end to get a realy smooth experience. In the end we should update manipulate the complete list of traces on the c++ side with a dirty flags, signal if everyhting is ready and then go through the whole registeredObject in one function instead of many single function calls...

kislinsk added a project: Auto-closed.
kislinsk added a subscriber: kislinsk.

Hi there! ๐Ÿ™‚

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. ๐Ÿš‘

Best wishes,
The MITK devs

floca removed a project: Auto-closed.
floca claimed this task.

After we have moved to Qt6, we then have QtCharts to our disposal and migrate to that.

I was to quick. QtCharts is no solution due to license conflict. :(