Page MenuHomePhabricator

Refactor Measurement plugin to use the new node selection widgets
Closed, ResolvedPublic

Description

In order to fully utilize the new selection concept, the QmitkMeasurementView will be changed to use the new single node selection widget.

Revisions and Commits

Event Timeline

kalali triaged this task as Normal priority.Feb 3 2020, 6:09 PM
kalali created this task.

The QmitkMeasurementView is able to show multiple selections of PlanarFigures (lines, polygons) along with their geometric information. Currently our selection widgets do not support a nice way to group geometric information with selected nodes.

Suggestion: Assuming the QmitkMeasurementView is used to create a limited amount of planar figures for geometric information we could always show the information of each planar figure instead of showing only those that are selected.
Using the new selection concept we could at least filter those planar figures that are child nodes of the currently selected reference node.

kalali added a revision: Restricted Differential Revision.Feb 4 2020, 1:00 PM

I would handle it that way (and close to your assumption):

  1. The selection widget should have the purpose of an refernce image node.
    1. Therefore change the hint into "Select a reference image".
    2. And I would set the predicate to not select Planar figures but only images/masks...
  2. If a parent node is selected, only PlanarFigures of this parent node are shown.
  3. If no parent node is selected, all PlanarFigures are shown.

Following feature would be then missing compared to your draft:

  • Selected planar figure is highlighted (triggered by the SelectionWidget)
  • Jump to selected planar figure (triggered by the SelectionWidget)

As these are no regression to the original, I would put them into an extra task, that integrate such featured without the need of a data manager. E.g. the list of planarfigures in the measurement view could be directly clicked/selected to trigger such behaviors. E.G. by Impementing a special DatastorageView for showing the planar figures with there data and also allow the selection, would be a good idea.

Ok, so I updated the diff to include the suggestions (which includes your point 1 here).
For the filtering / highlighting, list view on planar figures I will open task to keep things cleanly separated. Here we will only fix the selection widget.

For the filtering / highlighting, list view on planar figures I will open task to keep things cleanly separated. Here we will only fix the selection widget.

This approach makes sense and is fine for me.
What planar figures are currently shown. After this task. All? All child figures? Only one?
Depending on that, the new task would have a different priority. The last option would be an obvious regression so the priority to fix it before a releas would become certaintly higher.

What planar figures are currently shown. After this task. All? All child figures? Only one?
Depending on that, the new task would have a different priority. The last option would be an obvious regression so the priority to fix it before a releas would become certaintly higher.

Currently the selection of the planar figures has not been changed, so they are shown as they are selected inside the data manager. The newly opened task will allow to select the nodes without the data manager.