Page MenuHomePhabricator
Create Task
Maniphest T27229

[ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel
Closed, ResolvedPublic
Actions

Description

Status: Currently the copy to clipboard of statistics table and histogram in the StatisticsView behave differently: The histogram is copied in such a way that it is directly usable in Excel. Content of statistics table is not.

Reason:

  1. Histogram uses tabulator as column seperator
  2. Histogram regards the locale while converting the values to string (e.g. on German system the decimal seperator is , and not .).

I would propose to align both widget and to ensure, for a better UX, to behave like the histogram widget (tab as separator and locale aware number conversion).

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITK5728c2c3af66 Added locale awareness for string conversion
Restricted Differential RevisionrMITKcdddd7f1427d Fixed review remarks
Restricted Differential RevisionrMITK5683b5cfa036 fixed gcc errors
Restricted Differential RevisionrMITKb5b4fabf24ad Added locale awareness for string conversion
Restricted Differential RevisionrMITK7982aa6e060f Format clipboard statistics data
Restricted Differential RevisionrMITKd0415d55e1de Rename member variables, remove extra whitespace
Restricted Differential RevisionrMITK58f58183c54d Clear clipboard before use
Restricted Differential RevisionrMITK3e0e315eaccc Change column delimiter to tab

Related Objects
Search...

StatusAssignedTask
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedflocaT27229 [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel

Event Timeline

floca triaged this task as Normal priority.Mar 12 2020, 4:38 PM
floca created this task.
kalali added a subscriber: kalali.Mar 13 2020, 1:37 PM

There is also something wrong when having multiple images with masks (commas are put at the end of the mask-values):

Images/Masks, Mean, Median, StandardDeviation, RMS, Max, MaxPosition, Min, MinPosition, #Voxel, Volume [mm^3], Skewness, Kurtosis, Uniformity, Entropy, MPP, UPP, Variance

1
seg1, 255, 255, 0, 255, 255, 3 2 0, 255, 1 -2147483648 -2147483648, 17, 17, -nan(ind), -nan(ind), 1, 0, 255, 1, 0, , , , , , , , , , , , , , , , ,
kalali added a comment.Mar 13 2020, 2:08 PM

How did you encounter the different decimal separator?

kalali renamed this task from ImageStatistic: copy to clipboard from statistic table should be directly usabel in Excel to [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel.Mar 13 2020, 2:10 PM
kalali updated the task description. (Show Details)
kalali updated the task description. (Show Details)Mar 13 2020, 2:12 PM
kalali added a revision: Restricted Differential Revision.Mar 13 2020, 2:23 PM
floca claimed this task.Mar 13 2020, 2:56 PM
In T27229#196527, @kalali wrote:

How did you encounter the different decimal separator?

By copying the content of stats table and histogram to excel. Reason ist that histogram uses QString::arg to convert doubles locale sensitive. The stats widget does not. But this problem roots alread in a stats helper class, because it always converts the values into strings befor passing them to the model. This implies a deeper rework I already have started. I will base it on your work as soon as D264 is merged.

There is also something wrong when having multiple images with masks (commas are put at the end of the mask-values):

Yes, there is something wrotten in the collector class that should iterate over the model. I will have a look when I rework the rest of the model.

kalali added a commit: rMITK3e0e315eaccc: Change column delimiter to tab.Mar 13 2020, 3:27 PM
kalali added a commit: rMITK58f58183c54d: Clear clipboard before use.
kalali added a commit: rMITKd0415d55e1de: Rename member variables, remove extra whitespace.
kalali added a commit: rMITK7982aa6e060f: Format clipboard statistics data.
kalali removed floca as the assignee of this task.Mar 13 2020, 3:29 PM
kalali assigned this task to floca.

Sorry.

floca added a revision: Restricted Differential Revision.Mar 16 2020, 4:55 PM
floca added a comment.Mar 16 2020, 4:56 PM

Pushed new branch T27229-Add_locale_awareness.

floca added a commit: rMITKb5b4fabf24ad: Added locale awareness for string conversion.Mar 16 2020, 4:56 PM
floca added a commit: rMITK5683b5cfa036: fixed gcc errors.Mar 16 2020, 5:25 PM
floca added a project: Restricted Project.Mar 18 2020, 10:36 AM

Das war von mir, weil ich es ja dann übernehmen wollte ;)

floca moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Mar 18 2020, 10:36 AM
floca closed this task as Resolved.Mar 26 2020, 10:17 PM
floca reopened this task as Open.Mar 28 2020, 11:23 AM

Mixed things up my commits if this branch are not yet in the master. Must still be reviewed and merged.

floca edited projects, added MITK (v2021.02); removed MITK.Mar 28 2020, 11:23 AM
floca added a commit: rMITKcdddd7f1427d: Fixed review remarks.Mar 30 2020, 6:01 PM
floca added a parent task: Restricted Maniphest Task.Mar 31 2020, 9:10 PM
kislinsk moved this task from Backlog to MaaS on the MITK (v2021.02) board.Apr 2 2020, 2:52 PM
floca mentioned this in rMITKa388260014ac: Merge branch 'master' into T27229-Add_locale_awareness.Apr 2 2020, 5:15 PM
floca added a commit: rMITK5728c2c3af66: Added locale awareness for string conversion.
floca closed this task as Resolved.Apr 2 2020, 5:17 PM
floca moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 8 2020, 10:36 AM
floca added a project: Noteworthy.May 8 2020, 8:53 PM
floca mentioned this in T27486: Prepare changelog and migration guide for upcoming master merge.Jun 22 2020, 9:57 PM
MITK · MIC · IMSY · DKFZ