Page MenuHomePhabricator
Create Task
Maniphest T27578

2021.1 Linux installer does not work on Fedora
Closed, ResolvedPublic
Actions

Description

The 2018.04 linux installer still linked against libwrap0.so which isn't necessary anymore. Since this library (TCP wrappers) is very outdated it has been removed from some distributions completely. For 2020 we should ensure we don't link against it accidentially through some third party library.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITK20ed344cb5d6 Remove TCP Wrappers (libwrap) dependency

Related Objects

Event Timeline

nolden triaged this task as High priority.Jul 20 2020, 3:45 PM
nolden created this task.
nolden added a parent task: T28000: MITK v2021.02.Jan 27 2021, 9:00 AM
nolden renamed this task from Make sure libwrap isn't linked anymore to 2021.1 Linux installer does not work on Fedora.Jan 27 2021, 9:18 AM

Ok, I just re-checked: Ubuntu 20.04 still has librwrap installed , so installer works. For Fedora there is no workaround , so either

  • we accept the installers are not working there and document this as a know issus
  • we also provide installers build on Fedora (has to be tested but should be feasible)
  • we fix this bug
nolden raised the priority of this task from High to Unbreak Now!.Jan 27 2021, 9:18 AM
nolden added a comment.Jan 27 2021, 9:22 AM

Additional comment: the missing library doesn't prevent the Workbench from starting, but some/all DICOM functionality is missing which can be confusing

kislinsk edited projects, added Next Milestone, MITK; removed MITK (v2021.02).Jan 27 2021, 3:13 PM
kislinsk removed a parent task: T28000: MITK v2021.02.
kislinsk lowered the priority of this task from Unbreak Now! to High.Apr 6 2021, 4:21 PM
kislinsk edited projects, added MITK (v2021.10); removed MITK, Next Milestone.
kislinsk edited projects, added MITK (v2022.04); removed MITK (v2021.10).Nov 10 2021, 4:32 PM
kislinsk edited projects, added Next Milestone, MITK; removed MITK (v2022.04).Apr 29 2022, 1:38 PM
floca edited projects, added MITK (v2022.10); removed MITK.May 12 2022, 5:31 PM
kislinsk mentioned this in T29236: Check for prerequisites and give meaningful hints for missing packages.Jul 22 2022, 10:25 AM
kislinsk added a comment.Sep 12 2022, 8:30 AM

I would recommend to file a ticket in the DCMTK bug tracker since it is a dependency of dcmnet.

kislinsk lowered the priority of this task from High to Normal.Sep 12 2022, 8:30 AM
kislinsk added a comment.Sep 12 2022, 11:55 AM

Looking closer into the issue I wonder why it should not work without TCP Wrappers. It is an optional dependency of DCMTK which, regarding to storescp, adds two access control cmd-line arguments that we are not using anyway as far as I can see. So maybe it is just an issue since we so an explicit requirement check and then of course DO link against it. If we would explicitly disable it in DCMTK and remove the check in our CMake script, it should probably work already,

kislinsk added a comment.Sep 12 2022, 12:10 PM

Pushed new branch to rMITK MITK: bugfix/T27578-RemoveTCPWrappersDependency.

kislinsk added a revision: Restricted Differential Revision.Sep 12 2022, 12:12 PM
kislinsk removed a project: Next Milestone.Sep 13 2022, 9:35 AM
kislinsk mentioned this in rMITKd4ce642978a6: Merge branch 'bugfix/T27578-RemoveTCPWrappersDependency' into develop.Sep 14 2022, 5:57 AM
kislinsk added a commit: rMITK20ed344cb5d6: Remove TCP Wrappers (libwrap) dependency.
kislinsk added a comment.Sep 14 2022, 5:58 AM

Deleted branch from rMITK MITK: bugfix/T27578-RemoveTCPWrappersDependency.

kislinsk closed this task as Resolved.Sep 14 2022, 5:59 AM
kislinsk claimed this task.

I tested the fixed installer in a Fedora VM and it worked as expected.

kislinsk mentioned this in T29327: 2022 Week 40 (Very Early October).Oct 6 2022, 5:46 AM
MITK · MIC · IMSY · DKFZ