Reproduce:
- Create segmentation
- Perform Otsu (Preview plus selection)
- Try again with other number
-> Nothing happens, no new preview
Description
Description
Revisions and Commits
Revisions and Commits
| rMITK MITK | |||
| rMITKa06cec482e85 Fixed T28243 | |||
| rMITKe2f7714da3d1 Fixed T28243 | |||
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Resolved | kislinsk | T28000 MITK v2021.02 | ||
| Resolved | floca | T28243 [Segmentation] 3D Otsu does not show preview for a second time |
Event Timeline
Comment Actions
IMO not severe for the upcoming release since Otsu is not often used and it is not a show stopper...
Comment Actions
I remember that I had a discussion about this with @floca, he recently did a lot of changes to the seg tools: https://phabricator.mitk.org/D450?vs=on&id=2056#change-lAwYLYHZrN5g
Here he added a condition to only calculate a preview if some settings have changed. Maybe there was a property missing? (check esp. lines 77, 78, 79 in void QmitkOtsuTool3DGUI::OnPreviewBtnClicked()).
Edit
I raised two concerns for the corresponding code changes (commits) - that's just my first assumption.
Comment Actions
yes the logic is flaut. I was not carefull enough when I a changed line 77ff in QmitkOtsuTool3DGUI.cpp
it is
if (!m_FirstPreviewComputation || (tool->GetNumberOfRegions() == static_cast<unsigned int>(m_Controls.m_Spinbox->value()) && tool->GetUseValley() == m_Controls.m_ValleyCheckbox->isChecked() && tool->GetNumberOfBins() == static_cast<unsigned int>(m_Controls.m_BinsSpinBox->value()))) return;
it should be
if (!m_FirstPreviewComputation && (tool->GetNumberOfRegions() == static_cast<unsigned int>(m_Controls.m_Spinbox->value()) && tool->GetUseValley() == m_Controls.m_ValleyCheckbox->isChecked() && tool->GetNumberOfBins() == static_cast<unsigned int>(m_Controls.m_BinsSpinBox->value()))) return;