Page MenuHomePhabricator

Support building with Qt 5.15
Closed, ResolvedPublic

Description

This is not a fully tested Qt 5.15 support, but build support .

Revisions and Commits

rMITK MITK
Restricted Differential Revision

Related Objects

StatusAssignedTask
Resolvedkislinsk
Resolvedkislinsk

Event Timeline

I was hoping a bit to include it in the release, if the release would e.g. be used for kaapana containers for a longer time this could be helpful at some point. But of course it's not strictly necessary.

I don't know why this was not linked automatically: https://phabricator.mitk.org/D469

I don't know why this was not linked automatically: https://phabricator.mitk.org/D469

I guess because the task number is nowhere in you commit message or your diff description.

I was hoping a bit to include it in the release, if the release would e.g. be used for kaapana containers for a longer time this could be helpful at some point. But of course it's not strictly necessary.

I can understand the reasoning. But adding this feature last minute would basically mean to move the release again and also to test again. And we should realy try to get into the time based pattern.

Additionally, if I have understood it correctly we have currently a crash problem with Qt 5.15, we habe no solution yet and do not know the implication. So just getting this diff through won't really change anything in my opinion. All kaapana containers that need the UI/Qt are still screwed.

Therefore I would strongly opt for keeping it out of the current release branch (as it is a feature) and pack it together with DICOM seg stuff and alike into the next release.

kislinsk added a revision: Restricted Differential Revision.Feb 10 2021, 1:09 PM
kislinsk claimed this task.
kislinsk edited projects, added MITK (v2021.02); removed Next Milestone, MITK.
kislinsk added a subscriber: kislinsk.

Is it really a minor change and we include it in the current release, but still we should not yet officially announce support of system Qt5.