Remove "Frontal" and "Transversal" as view direction from the code base
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kalali
	Jun 3 2022, 6:57 PM

Description

mitk::SliceNavigationController::Frontal should be replaced with Coronal. In combination with the parent task the question is, if we remove mitk::SliceNavigationController::ViewDirection completely.

mitk::PlaneGeometry::Frontal should be replaced with Coronal. In combination with the parent task the question is, if we remove mitk::PlaneGeometry::PlaneOrientation completely.

Transversal is occasionally used as a string or inside comments.

API breaking changes

mitk::SliceNavigationController::Frontal was renamed to mitk::SliceNavigationController::Coronal
mitk::PlaneGeometry::Frontal was renamed to mitk::PlaneGeometry::Coronal

mitk::MorphologicalDimensions::Sagital was renamed to mitk::MorphologicalDimensions::Sagittal
mitk::StructuralElementType::Ball_Sagital was renamed to mitk::StructuralElementType::Ball_Sagittal
mitk::StructuralElementType::Cross_Sagital was renamed to mitk::StructuralElementType::Cross_Sagittal

Revisions and Commits

rMITK MITK
	Restricted Differential Revision	rMITK685cdc749582 Remove saggital as view direction
	Restricted Differential Revision	rMITK1e23ae1959dd Remove misspelled "sagital" in miscellaneous files
	Restricted Differential Revision	rMITK772a10a533b7 Remove misspelled "saggital" in miscellaneous files
	Restricted Differential Revision	rMITKe777f82bd510 Remove transversal as view direction
	Restricted Differential Revision	rMITKd3295d276ced Remove misspelled "transveral" in miscellaneous files
	Restricted Differential Revision	rMITK7cca15c7b8fa Remove "transversal" in miscellaneous files
	Restricted Differential Revision	rMITKf53a78a4336a Remove frontal as view direction
	Restricted Differential Revision	rMITKc39d8481663f Remove "frontal" in miscellaneous files
	Restricted Differential Revision	rMITK9f214872926c Remove "frontal" from plane geometry
	Restricted Differential Revision	rMITK1bdf7f649480 Remove "frontal" from slice navigation controller

Related Objects
Search...

		Status	Assigned	Task
		Resolved	kalali	T26543 Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations
		Resolved	kalali	T29207 Remove "Frontal" and "Transversal" as view direction from the code base

Event Timeline

kalali triaged this task as Low priority.Jun 3 2022, 6:57 PM

kalali created this task.

kalali updated the task description. (Show Details)Jun 9 2022, 12:53 PM

kalali mentioned this in T29210: Clarify / remove axis-labeling for anatomical planes.Jun 10 2022, 12:21 PM

kalali added a revision: Restricted Differential Revision.Jun 10 2022, 1:02 PM

kalali renamed this task from Remove "Frontal" as view direction from the code base to Remove "Frontal" and "Transversal" as view direction from the code base.Jun 10 2022, 1:04 PM

kalali updated the task description. (Show Details)

kalali added a revision: Restricted Differential Revision.Jun 10 2022, 1:14 PM

kalali added a revision: Restricted Differential Revision.Jun 13 2022, 11:43 AM

kalali moved this task from Backlog to Cycle on the MITK (v2022.10) board.Jun 13 2022, 11:50 AM

kalali removed a project: Request for Discussion.

kalali added a commit: rMITK1bdf7f649480: Remove "frontal" from slice navigation controller.Jun 29 2022, 9:23 AM

kalali added a commit: rMITK9f214872926c: Remove "frontal" from plane geometry.

kalali added a commit: rMITKc39d8481663f: Remove "frontal" in miscellaneous files.

kalali added a commit: rMITKf53a78a4336a: Remove frontal as view direction.

kalali updated the task description. (Show Details)Jun 29 2022, 9:26 AM

kalali added a project: Breaking Change.

kalali added a commit: rMITK7cca15c7b8fa: Remove "transversal" in miscellaneous files.Jun 29 2022, 9:28 AM