Page MenuHomePhabricator
Create Task
Maniphest T29317

Clean up DICOM Browser plugin
Open, NormalPublic
Actions

Description

While investigating T24398 I noticed that the code quality of the DICOM Browser plugin is pretty bad. It needs a thorough clean-up.

Related Objects
Search...

StatusAssignedTask
 OpenNoneT24398 Dicom plugin: Retrieve does not work
 OpenNoneT29317 Clean up DICOM Browser plugin

Event Timeline

kislinsk triaged this task as Normal priority.Sep 28 2022, 9:37 AM
kislinsk created this task.
kislinsk added a comment.EditedSep 28 2022, 9:40 AM

Here's the first batch of clean-up action. Needs to be continued!

Pushed new branch to rMITK MITK: bugfix/T29317-CleanUpDICOMBrowser.

kislinsk mentioned this in T24398: Dicom plugin: Retrieve does not work.Feb 28 2023, 8:23 AM
floca added a comment.Feb 28 2023, 8:47 AM

Should we integrate that in develop? Or any reason to wait?

kislinsk added a comment.Feb 28 2023, 10:00 AM

From a first glimpse it really needs to be continued before merging. Can't make much sense right now out of mitk::StoreSCPLauncherBuilder in parallel to QmitkStoreSCPLauncher::Params. Have to take a closer look.

kislinsk edited projects, added MITK (v2023.12); removed Next Milestone, MITK.May 17 2023, 2:57 PM
kislinsk edited projects, added MITK (v2024.06); removed MITK (v2023.12).Dec 5 2023, 10:38 AM
MITK · MIC · IMSY · DKFZ