Page MenuHomePhabricator
Create Task
Maniphest T29526

[Segmentation] Workbench crashes when closing render window part with active tool
Closed, ResolvedPublic
Actions

Description

The workbench crashes if a segmentation tool is active and the workbench is closed.
This happens because the ActiveToolChanged is called if the active tool changes. The destructor of the Segmentation View is called when the workbench is closed and the tool active tool is deactivated.
At that time the render window part is not available anymore and the access to this class instance inside QmitkSegmentationView::ActiveToolChanged leads to a crash.

To reproduce:

  1. open MITK, load an image
  2. close the Standard Display, open the MxN Display
  3. open the segmentation plugin view and create a new segmentation node
  4. activate a tool and close the workbench via "x"

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITK303cdff5e506 Fixed T29526
Restricted Differential RevisionrMITK88164071fbca Fixed T29526

Related Objects

Event Timeline

kalali triaged this task as Normal priority.Apr 19 2023, 6:45 PM
kalali created this task.
kalali updated the task description. (Show Details)Apr 19 2023, 7:30 PM
kalali added a comment.EditedApr 20 2023, 11:00 AM

In general this might be a problem also for other views because closing the workbench removes the render window part listener: m_RenderWindowListeners.remove(renderWindowListener) in QmitkViewCoordinator::PartClosed. This leads to the issue that the Segmentation view does not listen to the render window part being closed anymore.
Thus in the current scenario the render window part is NOT set to nullptr in the Segmentation view and in turn an invalid access is made when destroying the Segmentation view.

kalali claimed this task.Apr 20 2023, 11:00 AM
kalali edited projects, added MITK (v2023.04); removed MITK.
kalali moved this task from Backlog to Cycle on the MITK (v2023.04) board.
kalali removed kalali as the assignee of this task.Apr 26 2023, 5:35 PM
kalali moved this task from Cycle to mxn MultiWidget on the MITK (v2023.04) board.
kislinsk edited projects, added MITK (v2023.12); removed MITK (v2023.04).May 17 2023, 2:55 PM
kislinsk moved this task from Backlog to Segmentation on the MITK (v2023.12) board.May 17 2023, 3:06 PM
floca moved this task from Segmentation to Cycle on the MITK (v2023.12) board.Jul 4 2023, 5:02 PM
kislinsk edited projects, added MITK (v2024.06); removed MITK (v2023.12).Dec 5 2023, 10:38 AM
kislinsk moved this task from Backlog to Cycle on the MITK (v2024.06) board.
floca raised the priority of this task from Normal to Unbreak Now!.Apr 2 2024, 7:12 PM
floca added a project: Request for Discussion.
floca added a subscriber: floca.

Discussion: How important is that?

floca edited projects, added Missing Info; removed Request for Discussion.Apr 3 2024, 11:19 AM

does it still happen?

s434n removed a project: Missing Info.Apr 4 2024, 2:07 PM

Yes, this still happens as described above.

floca claimed this task.May 7 2024, 2:59 PM
kislinsk added a revision: Restricted Differential Revision.May 7 2024, 3:36 PM
floca closed this task as Resolved by committing rMITK88164071fbca: Fixed T29526.May 7 2024, 6:28 PM
floca added a commit: rMITK88164071fbca: Fixed T29526.
floca added a commit: rMITK303cdff5e506: Fixed T29526.
kislinsk mentioned this in T30470: 2024 Week 24 (Mid June).Jun 14 2024, 12:43 AM
MITK · MIC · IMSY · DKFZ