Page MenuHomePhabricator

s434n (Stephen Schaumann)
User

Projects

User Details

User Since
Feb 18 2021, 3:37 PM (31 w, 1 d)

Recent Activity

Thu, Sep 23

kalali awarded T26485: [Segmentation] PACS mode is active while segmentation is drawn a Party Time token.
Thu, Sep 23, 2:39 PM · MITK (v2021.10)
s434n closed T26485: [Segmentation] PACS mode is active while segmentation is drawn as Resolved.

With both subtasks done, we have successfully implemented the main goal of this task. The remaining bug that deactivating a segmentation tool resets the interaction to an earlier state (the one at which the tool was activated) has been split off into T28630 because it is not critical and can be easily handled with the new feature of deactivating PACS tools.

Thu, Sep 23, 11:51 AM · MITK (v2021.10)
s434n committed rMITKe7f6648cd685: Correct handling of PACS mode when using ImageCropper (authored by s434n).
Correct handling of PACS mode when using ImageCropper
Thu, Sep 23, 10:56 AM
s434n closed T28629: [ImageCropper] PACS mode is active while bounding box is drawn as Resolved by committing rMITKe7f6648cd685: Correct handling of PACS mode when using ImageCropper.
Thu, Sep 23, 10:56 AM · MITK (v2021.10)
s434n committed rMITK6974be056a90: remove unused print statements (authored by s434n).
remove unused print statements
Thu, Sep 23, 10:56 AM
s434n committed rMITK216b2b1041da: generalize disabling/enabling crosshair to PACS scheme (authored by s434n).
generalize disabling/enabling crosshair to PACS scheme
Thu, Sep 23, 10:56 AM
s434n committed rMITK090557c6d3d6: handle DisplayActionEventBroadcasts in disabling/enabling of crosshair (authored by s434n).
handle DisplayActionEventBroadcasts in disabling/enabling of crosshair
Thu, Sep 23, 10:56 AM

Wed, Sep 15

s434n added a revision to T28629: [ImageCropper] PACS mode is active while bounding box is drawn: Unknown Object (Differential Revision).
Wed, Sep 15, 2:45 PM · MITK (v2021.10)
s434n merged task T28278: Image cropper doesn't work with PACS like mouse interaction into T28629: [ImageCropper] PACS mode is active while bounding box is drawn.
Wed, Sep 15, 12:49 PM · Next Milestone, MITK
s434n merged T28278: Image cropper doesn't work with PACS like mouse interaction into T28629: [ImageCropper] PACS mode is active while bounding box is drawn.
Wed, Sep 15, 12:49 PM · MITK (v2021.10)

Fri, Sep 10

s434n added a comment to T24368: Interaction scheme has different level of interaction.

The proposed change goes kind of in the opposite direction of recent changes that were made, specifically in D531 and part of D532. If the approach of D535 is to be continued, it would need to take into account D532, in which an additional PACS scheme was introduced that leaves the left mouse button unused.
I would personally prefer the direction we have been taking now, splitting up the config files into smaller chunks. This reduces code redundancy, instead of having almost identical config files many times.
Also, in my opinion the approach of D531 makes a lot of sense for overlapping interactions. It allows to change only the aspects of interaction that are necessary while staying oblivious to the current interaction (MITK default, with swivel, PACS, ...). If we want to use full configs, one would need any variation of each scheme for each situation where alterations may be necessary. For example 2D segmentation tools require the left mouse button, so any possible interaction scheme needs to have a corresponding version where the left mouse button is unused. If a tool requires something new, like the right mouse button, new config files have to be implemented for every existing interaction scheme instead of just one file that will be appended.

Fri, Sep 10, 3:59 PM · MITK

Aug 25 2021

s434n closed T28631: [PACS] Allow disabling of PACS tools, a subtask of T26485: [Segmentation] PACS mode is active while segmentation is drawn, as Resolved.
Aug 25 2021, 5:29 PM · MITK (v2021.10)
s434n closed T28631: [PACS] Allow disabling of PACS tools as Resolved.
Aug 25 2021, 5:29 PM · MITK (v2021.10)
s434n triaged T28677: [PACS] Disabling and reenabling PACS like interaction resets functionality but not UI as Low priority.
Aug 25 2021, 4:44 PM · MITK
s434n added a comment to T28629: [ImageCropper] PACS mode is active while bounding box is drawn.

Possible duplicate of T28278? That task's description is not very clear about the problem, but could be referencing the same thing

Aug 25 2021, 4:30 PM · MITK (v2021.10)
s434n committed rMITK16844f3905fc: Allow disabling of PACS tools by manually ensuring exclusivity (authored by s434n).
Allow disabling of PACS tools by manually ensuring exclusivity
Aug 25 2021, 4:12 PM
s434n committed rMITKd5dffec8590d: Set width of PACS toolbar to fixed size to avoid changing render window size (authored by s434n).
Set width of PACS toolbar to fixed size to avoid changing render window size
Aug 25 2021, 4:12 PM
s434n committed rMITKb9777d160b30: manually implement optional-exclusive behavior of PACS tools (authored by s434n).
manually implement optional-exclusive behavior of PACS tools
Aug 25 2021, 4:12 PM
s434n committed rMITK0d2e45aed5ee: split crosshair-specific part of PACS config into separate file (authored by s434n).
split crosshair-specific part of PACS config into separate file
Aug 25 2021, 4:12 PM

Aug 17 2021

s434n added a revision to T28631: [PACS] Allow disabling of PACS tools: Unknown Object (Differential Revision).
Aug 17 2021, 11:12 AM · MITK (v2021.10)

Aug 13 2021

s434n committed rMITK234cb93299fe: Fixed T28667 Generalize overwriting of interaction configs when using tools (authored by s434n).
Fixed T28667 Generalize overwriting of interaction configs when using tools
Aug 13 2021, 10:06 AM
s434n closed T28667: [Segmentation] Generalize overwriting of interaction configs when using tools, a subtask of T28629: [ImageCropper] PACS mode is active while bounding box is drawn, as Resolved.
Aug 13 2021, 10:06 AM · MITK (v2021.10)
s434n closed T28667: [Segmentation] Generalize overwriting of interaction configs when using tools as Resolved by committing rMITK234cb93299fe: Fixed T28667 Generalize overwriting of interaction configs when using tools.
Aug 13 2021, 10:06 AM · MITK (v2021.10)
s434n closed T28667: [Segmentation] Generalize overwriting of interaction configs when using tools, a subtask of T26485: [Segmentation] PACS mode is active while segmentation is drawn, as Resolved.
Aug 13 2021, 10:06 AM · MITK (v2021.10)
s434n committed rMITKaf17da8dcab9: replace setting hardcoded interaction config with adding config containing only… (authored by s434n).
replace setting hardcoded interaction config with adding config containing only…
Aug 13 2021, 10:06 AM

Aug 11 2021

s434n added a comment to T28631: [PACS] Allow disabling of PACS tools.

As of now, we will remain with Qt 5.12 for a while, since it is a well maintained long-term version

Aug 11 2021, 1:06 PM · MITK (v2021.10)
s434n added a parent task for T28667: [Segmentation] Generalize overwriting of interaction configs when using tools: T28629: [ImageCropper] PACS mode is active while bounding box is drawn.
Aug 11 2021, 12:27 PM · MITK (v2021.10)
s434n added a subtask for T28629: [ImageCropper] PACS mode is active while bounding box is drawn: T28667: [Segmentation] Generalize overwriting of interaction configs when using tools.
Aug 11 2021, 12:27 PM · MITK (v2021.10)
s434n removed a project from T26485: [Segmentation] PACS mode is active while segmentation is drawn: Request for Discussion.
Aug 11 2021, 11:13 AM · MITK (v2021.10)
s434n removed a project from T28631: [PACS] Allow disabling of PACS tools: Request for Discussion.
Aug 11 2021, 11:13 AM · MITK (v2021.10)
s434n moved T28631: [PACS] Allow disabling of PACS tools from Backlog to MITK Meeting on the Request for Discussion board.
Aug 11 2021, 11:05 AM · MITK (v2021.10)
s434n committed rMITK8186562db1a4: Fixed T28492 PACS interaction getting stuck from modifier keys (authored by s434n).
Fixed T28492 PACS interaction getting stuck from modifier keys
Aug 11 2021, 10:12 AM
s434n closed T28492: Renderer interaction hangs in PACS mode when using keyboard modifiers as Resolved by committing rMITK8186562db1a4: Fixed T28492 PACS interaction getting stuck from modifier keys.
Aug 11 2021, 10:12 AM · MITK
s434n committed rMITK44e79ace0a12: introduce statemachine reset for unmodified PACS movement (authored by s434n).
introduce statemachine reset for unmodified PACS movement
Aug 11 2021, 10:12 AM

Aug 10 2021

s434n added a subtask for T26485: [Segmentation] PACS mode is active while segmentation is drawn: T28667: [Segmentation] Generalize overwriting of interaction configs when using tools.
Aug 10 2021, 1:28 PM · MITK (v2021.10)
s434n added a parent task for T28667: [Segmentation] Generalize overwriting of interaction configs when using tools: T26485: [Segmentation] PACS mode is active while segmentation is drawn.
Aug 10 2021, 1:28 PM · MITK (v2021.10)
s434n triaged T28667: [Segmentation] Generalize overwriting of interaction configs when using tools as Normal priority.
Aug 10 2021, 1:28 PM · MITK (v2021.10)

Aug 3 2021

s434n added a revision to T28492: Renderer interaction hangs in PACS mode when using keyboard modifiers: Unknown Object (Differential Revision).
Aug 3 2021, 10:34 AM · MITK

Aug 2 2021

s434n claimed T28492: Renderer interaction hangs in PACS mode when using keyboard modifiers.

The cause for this problem lies in missing state-transitions of the interaction state-machine. DisplayConfigPACS.xml defines the events based on which the state-machine in DisplayInteraction.xml acts. For modifier-based interactions, a MousePressEvent / MouseReleaseEvent in combination with a modifier-key are responsible to transition into / out of the corresponding state ("move", "zoom", ...). When the modifier-key is released BEFORE releasing the mouse button, the second event is never triggered, causing the state machine to get stuck in that specific state, which blocks most other interactions.

Aug 2 2021, 1:46 PM · MITK

Jul 28 2021

s434n added a project to T28631: [PACS] Allow disabling of PACS tools: Request for Discussion.
Jul 28 2021, 10:57 AM · MITK (v2021.10)

Jul 26 2021

s434n added a comment to T28631: [PACS] Allow disabling of PACS tools.

It seems this idea is currently not directly implementable, in the way of clicking a button again to deactivate it. In the constructor of QmitkInteractionSchemeToolBar.cpp the line m_ActionGroup->setExclusive(true); guarantees that exactly one option is selected at any time. Since Qt 5.14 there is the option to set an ExclusionPolicy of ExclusionOptional, which accomplishes exactly what was thought of in this task. As this is not available yet, one would either need to manually implement the desired behavior of activating/deactivating actions, or wait until perhaps a newer version of Qt is used.

Jul 26 2021, 12:28 PM · MITK (v2021.10)

Jul 22 2021

s434n committed rMDea103af79f1d: update ColorBarAnnotation test reference image (authored by s434n).
update ColorBarAnnotation test reference image
Jul 22 2021, 10:50 AM

Jul 19 2021

s434n committed rMITK649973ed18dd: T28267 set colorbar placement to correct height (authored by s434n).
T28267 set colorbar placement to correct height
Jul 19 2021, 2:18 PM
s434n committed rMITKbf0fdf5cd2bb: Merge remote-tracking branch 'origin/develop' into bugfix/T28267-colorbar… (authored by s434n).
Merge remote-tracking branch 'origin/develop' into bugfix/T28267-colorbar…
Jul 19 2021, 2:18 PM
s434n committed rMITK4af9caf0b882: set colorbar placement to correct height (authored by s434n).
set colorbar placement to correct height
Jul 19 2021, 2:17 PM

Jul 15 2021

s434n added a subtask for T26485: [Segmentation] PACS mode is active while segmentation is drawn: T28631: [PACS] Allow disabling of PACS tools.
Jul 15 2021, 5:07 PM · MITK (v2021.10)
s434n added a parent task for T28631: [PACS] Allow disabling of PACS tools: T26485: [Segmentation] PACS mode is active while segmentation is drawn.
Jul 15 2021, 5:07 PM · MITK (v2021.10)
s434n triaged T28631: [PACS] Allow disabling of PACS tools as Normal priority.
Jul 15 2021, 5:05 PM · MITK (v2021.10)
s434n triaged T28630: [Segmentation] Deactivating tool resets interactions to earlier state as Low priority.
Jul 15 2021, 4:59 PM · MITK
s434n updated subscribers of T28629: [ImageCropper] PACS mode is active while bounding box is drawn.
Jul 15 2021, 4:30 PM · MITK (v2021.10)
s434n triaged T28629: [ImageCropper] PACS mode is active while bounding box is drawn as Normal priority.
Jul 15 2021, 4:30 PM · MITK (v2021.10)

Jul 7 2021

s434n added a comment to T28481: [Checklist] [Test data] Define publicly available user test data.

So far, I have not heard from anybody about the message I sent around. I wanted to send another reminder of it soon, in case some people just forgot

Jul 7 2021, 11:11 AM · MITK (v2021.10)

Jul 6 2021

s434n claimed T26485: [Segmentation] PACS mode is active while segmentation is drawn.
Jul 6 2021, 10:32 AM · MITK (v2021.10)

Jul 5 2021

s434n added a comment to T26485: [Segmentation] PACS mode is active while segmentation is drawn.

André, Amir and I discussed the problem a bit and found multiple problems and ideas. The general question is: what is the intended behavior? Some options are:

  1. only one interaction can be active at any time. This would mean activating a segmentation tool would deactivate any PACS functionality and vice versa. Not really what we want, since it prohibits using regular MITK interaction behavior (e.g. zooming with the right mouse button) while segmenting
  2. only one left-mouse-button interaction is active at any time. Activating a segmentation tool would automatically disable left-mouse-button usage for display purposes
  3. multiple interactors can operate on the same events, i.e. PACS + segmentation at the same time is intended behavior, if the user wishes to do so. To make this useful, it should be possible to deactivate PACS interaction, either by allowing to click a button again to deselect it or by providing an additional button that does nothing on left clicks.
Jul 5 2021, 5:18 PM · MITK (v2021.10)
s434n added a comment to T26485: [Segmentation] PACS mode is active while segmentation is drawn.

The problem really seems to be the disabling / resetting of interactors that was mentioned in an earlier comment, even with the fix that corrects the resetting when the tool is deactivated again. Correct usage would be:

  1. moving around the gui, using PACS
  2. selecting a segmentation tool (which deactivates other interactors)
  3. only using the segmentation tool, without changing the view
  4. deactivating the segmentation tool (and thus reenabling previous interactors)
  5. -> everything works as intended

When a PACS tool is selected after step 2, this messes up the active interaction and after the segmentation tool is deactivated it resets to what was previously selected, before the tool was activated.

Jul 5 2021, 1:19 PM · MITK (v2021.10)

Jun 28 2021

s434n added a comment to T26485: [Segmentation] PACS mode is active while segmentation is drawn.

Some additional observations:

  • The behavior works as expected when selecting the segmentation tool AFTER changing the PACS action. Only when selecting a new PACS action while the segmentation tool is still active, they both act simultaneously
  • When some PACS action (action 1) is selected, then a segmentation tool is selected, the PACS action is changed (to action 2), and the segmentation tool is deselected again, PACS action 1 will be active but action 2 is marked in the sidebar as selected
Jun 28 2021, 11:47 AM · MITK (v2021.10)
s434n added a comment to T27571: Multilabel segmentation does not work with US DICOM images.

I was not able to reproduce this bug on Windows with the v2021.02 release as well as the current develop branch

Jun 28 2021, 10:49 AM · MITK (v2021.10), Missing Info, Restricted Project

Jun 15 2021

s434n added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

I was able to reproduce the bug for all morphological operations (Dilation, Erosion, ...) and also in all orientations (axial, coronal, sagittal). Other segmentation utilities all work without problem.

Jun 15 2021, 4:13 PM · Cleared, MITK (v2021.10)

Jun 2 2021

s434n added a comment to T28514: [Multilabel Segmentation] Changing visibility of labels on higher layers does not trigger update.

It seems to be the same bug, I just failed to find the existing task. Since I found it in the last Release version, the bugfix was just not included yet, but the problem is still solved. I guess this task can be closed then

Jun 2 2021, 3:58 PM · MITK
s434n claimed T28481: [Checklist] [Test data] Define publicly available user test data.
Jun 2 2021, 3:43 PM · MITK (v2021.10)

Jun 1 2021

s434n triaged T28515: [Statistics] Difference in behavior between the two data selection methods as Low priority.
Jun 1 2021, 2:48 PM · MITK
s434n triaged T28514: [Multilabel Segmentation] Changing visibility of labels on higher layers does not trigger update as Normal priority.
Jun 1 2021, 2:37 PM · MITK
s434n closed T28472: [Geldosimetry] Add editing options to calibration table as Resolved.
Jun 1 2021, 2:20 PM · Restricted Project, Restricted Project

May 26 2021

s434n triaged T28510: [Segmentation Utilities] Switched definitions in documentation as Normal priority.
May 26 2021, 5:19 PM · MITK

May 17 2021

s434n claimed T28472: [Geldosimetry] Add editing options to calibration table.
May 17 2021, 12:21 PM · Restricted Project, Restricted Project

May 7 2021

s434n added a comment to T28481: [Checklist] [Test data] Define publicly available user test data.

I've started a draft for a message to send around, found here if you want to have a look or add something: https://hub.dkfz.de/s/HzpkipeWRkq3K8K

May 7 2021, 3:11 PM · MITK (v2021.10)

Apr 30 2021

s434n added a parent task for T28472: [Geldosimetry] Add editing options to calibration table: Unknown Object (Maniphest Task).
Apr 30 2021, 9:53 AM · Restricted Project, Restricted Project
s434n triaged T28472: [Geldosimetry] Add editing options to calibration table as Normal priority.
Apr 30 2021, 9:53 AM · Restricted Project, Restricted Project

Mar 30 2021

s434n triaged T28424: Increase consistentcy of RT dose iso-color preset customization as Low priority.
Mar 30 2021, 9:48 AM · MITK

Mar 12 2021

s434n closed T28322: [Screenshot Maker] 3D Multiplanar screenshot does not return view to initial position as Resolved.
Mar 12 2021, 2:17 PM · MITK
s434n added a revision to T28322: [Screenshot Maker] 3D Multiplanar screenshot does not return view to initial position: Unknown Object (Differential Revision).
Mar 12 2021, 2:15 PM · MITK
s434n committed rMITKf80ac56d3cd7: Rotate camera back after multiplanar screenshot (authored by s434n).
Rotate camera back after multiplanar screenshot
Mar 12 2021, 2:10 PM
s434n committed rMITK70a48431c3c8: Rotate camera back after multiplanar screenshot (authored by s434n).
Rotate camera back after multiplanar screenshot
Mar 12 2021, 2:09 PM

Mar 1 2021

s434n added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

I got the same result as kislinsk, the crash only occurs when the documentation is open and not in the background

Mar 1 2021, 4:07 PM · MITK

Feb 19 2021

s434n triaged T28322: [Screenshot Maker] 3D Multiplanar screenshot does not return view to initial position as Low priority.
Feb 19 2021, 1:59 PM · MITK
s434n triaged T28321: [Measurement] Control points can not be moved twice without moving the mouse away as Low priority.
Feb 19 2021, 1:44 PM · MITK
s434n triaged T28320: [Segmentation] Region growing does not work if seed point is already inside a segmentation as Normal priority.
Feb 19 2021, 10:39 AM · Missing Info, MITK (v2021.10), Request for Discussion