Page MenuHomePhabricator

s434n (Stephen Schaumann)
User

Projects (6)

User Details

User Since
Feb 18 2021, 3:37 PM (93 w, 4 d)

Recent Activity

Tue, Nov 29

s434n moved T29392: [Segmentation] Add dedicated writer to store multi-label images in nifti from Backlog to In candidates on the MITK (v2023.04) board.
Tue, Nov 29, 1:44 PM · MITK (v2023.04), Next Milestone
s434n edited projects for T29392: [Segmentation] Add dedicated writer to store multi-label images in nifti, added: MITK (v2023.04); removed MITK.
Tue, Nov 29, 1:44 PM · MITK (v2023.04), Next Milestone
s434n moved T29415: [mxn multi widget] Allow mxn windows to show 3D view from Backlog to In candidates on the MITK (v2023.04) board.
Tue, Nov 29, 1:41 PM · MITK (v2023.04)
s434n edited projects for T29415: [mxn multi widget] Allow mxn windows to show 3D view, added: MITK (v2023.04); removed MITK.
Tue, Nov 29, 1:41 PM · MITK (v2023.04)
s434n moved T28800: [Segmentation] Threshold tool updates after each digit if typed in manually from In candidates to Segmentation on the MITK (v2023.04) board.
Tue, Nov 29, 1:38 PM · MITK (v2023.04), Checklist, Request for Discussion
s434n moved T28800: [Segmentation] Threshold tool updates after each digit if typed in manually from Backlog to In candidates on the MITK (v2023.04) board.
Tue, Nov 29, 1:38 PM · MITK (v2023.04), Checklist, Request for Discussion
s434n moved T16132: Allow segmentation with several images from Backlog to In candidates on the MITK (v2023.04) board.
Tue, Nov 29, 1:34 PM · MITK (v2023.04), Request for Discussion, Bugzilla
s434n committed rMITK92cc8b65aa6a: Implement center of mass calculation when label is clicked (authored by s434n).
Implement center of mass calculation when label is clicked
Tue, Nov 29, 1:22 PM
s434n committed rMITK75e3e8a413aa: switch calculation to itk LabelGeometryImageFilter (authored by s434n).
switch calculation to itk LabelGeometryImageFilter
Tue, Nov 29, 1:22 PM
s434n closed T29354: Double-clicking a label jumps to the label but not its centroid as Resolved by committing rMITK92cc8b65aa6a: Implement center of mass calculation when label is clicked.
Tue, Nov 29, 1:22 PM · MITK (v2023.04)
s434n committed rMITK7df0109a22ec: implement center of mass calculation (authored by s434n).
implement center of mass calculation
Tue, Nov 29, 1:22 PM
s434n closed T29312: Add support for using layers other than layer 0 of the current LabelSetImage, a subtask of T29309: [GrowCut] Further remarks regarding GrowCut, as Resolved.
Tue, Nov 29, 1:19 PM · MITK
s434n closed T29312: Add support for using layers other than layer 0 of the current LabelSetImage as Resolved.

I'm not sure where exactly this was introduced (maybe in D739), but seems to already be working now.

Tue, Nov 29, 1:19 PM · MITK (v2023.04)

Fri, Nov 25

s434n moved T29284: Refactor segmentation plugin user manual documentation from Backlog to Segmentation on the MITK (v2023.04) board.
Fri, Nov 25, 12:04 PM · MITK (v2023.04)
s434n merged task T16153: [Segmentation] Jump to center of mass of segmentation on click into T29354: Double-clicking a label jumps to the label but not its centroid.
Fri, Nov 25, 11:57 AM · MITK (v2023.04), Bugzilla
s434n merged T16153: [Segmentation] Jump to center of mass of segmentation on click into T29354: Double-clicking a label jumps to the label but not its centroid.
Fri, Nov 25, 11:57 AM · MITK (v2023.04)

Tue, Nov 22

s434n triaged T29415: [mxn multi widget] Allow mxn windows to show 3D view as Normal priority.
Tue, Nov 22, 12:39 PM · MITK (v2023.04)

Wed, Nov 16

s434n removed a parent task for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Wed, Nov 16, 1:21 PM · MITK (v2023.04)
s434n removed a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Wed, Nov 16, 1:21 PM · MITK
s434n added a parent task for T29392: [Segmentation] Add dedicated writer to store multi-label images in nifti: T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash.
Wed, Nov 16, 11:43 AM · MITK (v2023.04), Next Milestone
s434n added a subtask for T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash: T29392: [Segmentation] Add dedicated writer to store multi-label images in nifti.
Wed, Nov 16, 11:43 AM · MITK
s434n triaged T29392: [Segmentation] Add dedicated writer to store multi-label images in nifti as Normal priority.
Wed, Nov 16, 11:43 AM · MITK (v2023.04), Next Milestone
s434n updated subscribers of T29391: [Segmentation] Prevent multi-label images to be saved as unsupported image formats.
Wed, Nov 16, 11:38 AM · MITK
s434n added a parent task for T29391: [Segmentation] Prevent multi-label images to be saved as unsupported image formats: T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash.
Wed, Nov 16, 11:38 AM · MITK
s434n added a subtask for T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash: T29391: [Segmentation] Prevent multi-label images to be saved as unsupported image formats.
Wed, Nov 16, 11:38 AM · MITK
s434n triaged T29391: [Segmentation] Prevent multi-label images to be saved as unsupported image formats as Unbreak Now! priority.
Wed, Nov 16, 11:37 AM · MITK

Tue, Nov 8

s434n removed a project from T29098: [3D Segmentation] UL Threshold Tool - 0 intensity value not include in slider range?: Missing Info.

I just had another look at this. I was able to reproduce the bug this time. It seems that this problem only arises if the image holds floating point values, not when all values are integers.

Tue, Nov 8, 6:05 PM · MITK (v2023.04), Checklist

Mon, Nov 7

s434n added a revision to T29354: Double-clicking a label jumps to the label but not its centroid: Unknown Object (Differential Revision).
Mon, Nov 7, 3:44 PM · MITK (v2023.04)

Nov 3 2022

s434n claimed T29354: Double-clicking a label jumps to the label but not its centroid.
Nov 3 2022, 4:41 PM · MITK (v2023.04)
s434n closed T29286: Rework segmentation checklist for new live wire and lasso tool as Resolved.
Nov 3 2022, 12:13 PM · MITK (v2022.10)

Nov 2 2022

s434n added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

Deleted branch from rMITK MITK: feature/T28578-MxN-development.

Nov 2 2022, 10:56 AM · MITK
s434n closed T29344: Image Rendering - No difference between "Jet" and "Jet Transparent" as Resolved.
Nov 2 2022, 10:32 AM · Cleared, Checklist, MITK (v2022.10)

Oct 25 2022

s434n added a comment to T29336: Changing theme in Preferences has no effect..

I also can't reproduce this on Windows 10, changing the theme works as expected. So probably really a Mac OS specific issue.

Oct 25 2022, 2:44 PM · MITK, Checklist
s434n closed T29343: Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading as Resolved.
Oct 25 2022, 2:35 PM · Cleared, Checklist, MITK (v2022.10)

Oct 24 2022

s434n renamed T29343: Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading from Image Rendering - Loaded image is zoomed into in one view and normal in the other views to Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading.
Oct 24 2022, 12:53 PM · Cleared, Checklist, MITK (v2022.10)
s434n claimed T29343: Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading.
Oct 24 2022, 9:21 AM · Cleared, Checklist, MITK (v2022.10)

Oct 21 2022

s434n committed rMITKbed03667f06b: Avoid crashes at extreme level window ranges (authored by s434n).
Avoid crashes at extreme level window ranges
Oct 21 2022, 11:40 AM
s434n committed rMITK29d874a94745: mention hardcoded level window bounds in documentation (authored by s434n).
mention hardcoded level window bounds in documentation
Oct 21 2022, 11:40 AM
s434n closed T29341: Moving the LevelWindow slider too many times at extreme ranges makes MITK crash. as Resolved by committing rMITKbed03667f06b: Avoid crashes at extreme level window ranges.
Oct 21 2022, 11:40 AM · Cleared, Checklist, MITK (v2022.10)
s434n committed rMITK60cbc66d92d1: switch to ScalarType and update casts (authored by s434n).
switch to ScalarType and update casts
Oct 21 2022, 11:40 AM
s434n committed rMITK374a30152be0: avoid crashes at extreme level window ranges (authored by s434n).
avoid crashes at extreme level window ranges
Oct 21 2022, 11:40 AM

Oct 20 2022

s434n added a comment to T29344: Image Rendering - No difference between "Jet" and "Jet Transparent".

From testing, it seems to work correctly in one direction. Everything below the level window is transparent (i.e. black) while everything above the level window is dark red, as the maximum end of the colormap. If this is the desired behavior, it works for me. If we want the upper part to also be transparent, then it is not quite right yet.

Oct 20 2022, 1:04 PM · Cleared, Checklist, MITK (v2022.10)
s434n committed rMITKc13753a00f9f: fix wrong call by timestep instead of timepoint (authored by s434n).
fix wrong call by timestep instead of timepoint
Oct 20 2022, 12:14 PM
s434n closed T29330: Picking Tool shows peculiar behaviour in relabel mode for dynamic Segmentations. as Resolved by committing rMITKc13753a00f9f: fix wrong call by timestep instead of timepoint.
Oct 20 2022, 12:14 PM · Cleared, Checklist, MITK (v2022.10)
s434n committed rMITK90431e83523d: fix wrong call by timestep instead of timepoint (authored by s434n).
fix wrong call by timestep instead of timepoint
Oct 20 2022, 12:14 PM
s434n added a revision to T29330: Picking Tool shows peculiar behaviour in relabel mode for dynamic Segmentations.: Unknown Object (Differential Revision).
Oct 20 2022, 11:13 AM · Cleared, Checklist, MITK (v2022.10)

Oct 19 2022

s434n added a comment to T29343: Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading.

I think there may have been a misunderstanding in this task. With the current description, I am not able to reproduce the problem (zoomed in image when loading).
From the mentioned checklist, I understand it that the tester zoomed in himself, as the checklist recommends, to see if the crosshair is aligned with the pixels. The comment only says "Problem with the brain image. The other are working. Attachment 1", so I assume the image is only to illustrate this.
So the only problem is that brain.nrrd is not pixel-aligned automatically when loaded, only after doing a reinit. I think this step in the checklist is worded a bit unclear anyway, so it's probably best to just improve that instruction and I think that's it.

Oct 19 2022, 12:16 PM · Cleared, Checklist, MITK (v2022.10)

Oct 17 2022

s434n added a project to T29340: Colored pixels remain unchanged, even when sliding the Level Window slider to low numbers: Request for Discussion.
Oct 17 2022, 4:43 PM · Next Milestone, Missing Info, Checklist

Oct 14 2022

s434n added a revision to T29341: Moving the LevelWindow slider too many times at extreme ranges makes MITK crash.: Unknown Object (Differential Revision).
Oct 14 2022, 6:02 PM · Cleared, Checklist, MITK (v2022.10)

Oct 13 2022

s434n added a comment to T29340: Colored pixels remain unchanged, even when sliding the Level Window slider to low numbers.

As far as I can tell, this is the expected behavior. Any voxel that has a (greyscale) value above the level-window range is shown completely white. The colors only extend this to multiple channels, but the behavior is still the same. So with very low level-window, the colors are expected to stay visible very strongly

Oct 13 2022, 10:51 AM · Next Milestone, Missing Info, Checklist
s434n claimed T29341: Moving the LevelWindow slider too many times at extreme ranges makes MITK crash..
Oct 13 2022, 10:42 AM · Cleared, Checklist, MITK (v2022.10)
s434n added a comment to T29341: Moving the LevelWindow slider too many times at extreme ranges makes MITK crash..

I recreated the problem by loading any image (the described ones work, as well as just Pic3D.nrrd) and moving the level windows really far (either by dragging the bar to one direction, or moving it back and forth to the upper and lower bounds), to values around the scale of 4e+38. At that point, the workbench just freezes and stops responding.

Oct 13 2022, 10:41 AM · Cleared, Checklist, MITK (v2022.10)
s434n removed a project from T29346: Level Window Checklist - Level Window slider inconsistent upper/lower bound behavior on mouse clicks.: Checklist.

Since this cannot be reproduced right now, we assume this was caused by user error, maybe clicking at the wrong location. For the upcoming release there won't be anything done about this.
In the long-term, we will have to think about if we want to try and improve level window UX, especially in regard to the MxN multi-widget view (T28578) which may need fundamental changes.

Oct 13 2022, 10:25 AM · MITK (v2023.04), Cleared

Oct 5 2022

s434n committed rMITKf6b7afa5f4a1: Remove output from changing livewire points (authored by s434n).
Remove output from changing livewire points
Oct 5 2022, 2:50 PM
s434n committed rMITK9564fecd9f40: remove output from changing livewire points (authored by s434n).
remove output from changing livewire points
Oct 5 2022, 2:50 PM

Sep 23 2022

s434n closed T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool , a subtask of T29132: [MultiLabel Segmentation] Define desired behavior of fill / erase tool, as Resolved.
Sep 23 2022, 3:01 PM · MITK (v2022.10)
s434n closed T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool as Resolved.

I have updated the checklist according to the documented / actual function of the two tools.
However, I had to add a note regarding the "remove everything" functionality of the erase tool, which currently does not work correctly (?) when a segmented region touches the boundary of the image (see T29078 example 2).

Sep 23 2022, 3:01 PM · MITK (v2022.10)
s434n claimed T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool .
Sep 23 2022, 12:23 PM · MITK (v2022.10)

Sep 19 2022

s434n committed rMITK26df569787e2: Fix typos (authored by s434n).
Fix typos
Sep 19 2022, 11:05 AM
s434n committed rMITKb4c69945ef44: fix typos and remove misspelled unused code (authored by s434n).
fix typos and remove misspelled unused code
Sep 19 2022, 11:05 AM

Sep 16 2022

s434n closed T29287: Rework segmentation checklist for new modes of the picking tool as Resolved.
Sep 16 2022, 1:55 PM · MITK (v2022.10)
s434n claimed T29287: Rework segmentation checklist for new modes of the picking tool.
Sep 16 2022, 12:41 PM · MITK (v2022.10)

Sep 13 2022

s434n added a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29299: [mxn multi widget] Allow drag 'n drop in render window specific data inspector.
Sep 13 2022, 1:06 PM · MITK (v2023.04)
s434n added a parent task for T29299: [mxn multi widget] Allow drag 'n drop in render window specific data inspector: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Sep 13 2022, 1:06 PM · MITK
s434n triaged T29299: [mxn multi widget] Allow drag 'n drop in render window specific data inspector as Normal priority.
Sep 13 2022, 1:06 PM · MITK
s434n added a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29298: [mxn multi widget] Add context menu to render window specific data inspector.
Sep 13 2022, 1:03 PM · MITK (v2023.04)
s434n added a parent task for T29298: [mxn multi widget] Add context menu to render window specific data inspector: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Sep 13 2022, 1:03 PM · MITK
s434n triaged T29298: [mxn multi widget] Add context menu to render window specific data inspector as Normal priority.
Sep 13 2022, 1:02 PM · MITK
s434n added a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Sep 13 2022, 12:46 PM · MITK
s434n added a parent task for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Sep 13 2022, 12:46 PM · MITK (v2023.04)
s434n triaged T29297: [mxn multi widget] Optimize data accessibility inside render windows as Normal priority.
Sep 13 2022, 12:46 PM · MITK (v2023.04)

Aug 25 2022

s434n added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

Pushed new branch to rMITK MITK: feature/T28578-MxN-development.

Aug 25 2022, 7:18 PM · MITK

Jul 7 2022

s434n closed T29213: [Levelwindow] Preset definition does not allow floating point numbers as Resolved.
Jul 7 2022, 11:49 AM · MITK (v2022.10)
s434n committed rMITK4d8943c91982: standardize setting of level window values (authored by s434n).
standardize setting of level window values
Jul 7 2022, 11:48 AM
s434n committed rMITKe6954ab13033: Standardize setting of level window values (authored by s434n).
Standardize setting of level window values
Jul 7 2022, 11:48 AM

Jun 29 2022

s434n claimed T29213: [Levelwindow] Preset definition does not allow floating point numbers.
Jun 29 2022, 1:58 PM · MITK (v2022.10)

Jun 24 2022

s434n reassigned T28464: [Segmentation] New Add/Remove tool from s434n to floca.
Jun 24 2022, 5:57 PM · MITK (v2022.10)

Jun 23 2022

s434n added a comment to T28464: [Segmentation] New Add/Remove tool.

@s434n Have claimed it for finding the error* (good job by the way). Then you can unclaim it now.
Or will you work on that issue further?

Jun 23 2022, 12:00 PM · MITK (v2022.10)

Jun 8 2022

s434n closed T28297: Add Stitching MiniApp to installer as Resolved.
Jun 8 2022, 9:48 AM · MITK (v2022.10), Restricted Project, Cleared

Jun 3 2022

s434n committed rMITK1ba516a4379a: Add Stitching MiniApp to installer (authored by s434n).
Add Stitching MiniApp to installer
Jun 3 2022, 3:33 PM
s434n committed rMITK9a85a34c7b92: add stitching miniapp to workbench release config (authored by s434n).
add stitching miniapp to workbench release config
Jun 3 2022, 3:33 PM
s434n added a revision to T28297: Add Stitching MiniApp to installer: Unknown Object (Differential Revision).
Jun 3 2022, 12:46 PM · MITK (v2022.10), Restricted Project, Cleared
s434n claimed T28297: Add Stitching MiniApp to installer.
Jun 3 2022, 12:12 PM · MITK (v2022.10), Restricted Project, Cleared

May 30 2022

s434n closed T29093: [Image Cropper] Warning of rotated geometry not removed after reinit as Resolved.
May 30 2022, 11:02 AM · MITK (v2022.10), Checklist
s434n committed rMITKa064dfe2cc72: Make rotated geometry warning in Image Cropper more consistent (authored by s434n).
Make rotated geometry warning in Image Cropper more consistent
May 30 2022, 10:45 AM
s434n committed rMITKf6981649b07a: Make image selection node predicate filter for images (authored by s434n).
Make image selection node predicate filter for images
May 30 2022, 10:45 AM
s434n committed rMITK369093860612: fix typo (authored by s434n).
fix typo
May 30 2022, 10:45 AM
s434n committed rMITK489a2cf76cb9: Improve rotated image warning (authored by s434n).
Improve rotated image warning
May 30 2022, 10:44 AM
s434n committed rMITK1f7fb3f693ca: only update rotated geometry warning when selected image changes (authored by s434n).
only update rotated geometry warning when selected image changes
May 30 2022, 10:44 AM

May 27 2022

s434n closed T28481: [Checklist] [Test data] Define publicly available user test data as Resolved.
May 27 2022, 1:55 PM · MITK, Next Milestone
s434n added a comment to T29093: [Image Cropper] Warning of rotated geometry not removed after reinit.

After looking into the code, it seems to me that the warning is just formulated wrongly. A simple reinit will not make the bounding box for a rotated image pixel-aligned. Implementing this would take some time and require a lot of reworking the bounding shape interaction. As this is not currently requested, we will keep things as they are and only update the warning text so it won't be misleading.

May 27 2022, 1:13 PM · MITK (v2022.10), Checklist

May 18 2022

s434n claimed T28464: [Segmentation] New Add/Remove tool.
May 18 2022, 11:37 AM · MITK (v2022.10)

May 17 2022

s434n claimed T29093: [Image Cropper] Warning of rotated geometry not removed after reinit.
May 17 2022, 11:23 AM · MITK (v2022.10), Checklist
s434n added a comment to T28808: [Properties] Some Pointset 2D shape selection not shown in the image views.

I expect a circle in the cross-hairs, akin to Shape: cross or vertex. But there is None. Is this expected behaviour?

May 17 2022, 11:10 AM · MITK (v2022.10)
s434n added a comment to T29141: [Segmentation] Color change not immediately applied.

Is this the same (T29110, see description point 3) and specifically T29110#235991?
If so, I have a fix for the > layer 0 problem which can be tested and reviewed in D632.

May 17 2022, 10:49 AM · MITK (v2022.10), Checklist

May 4 2022

s434n committed rRTTB050f114a5fe9: Upgrade RTTB to ITK 5 (authored by s434n).
Upgrade RTTB to ITK 5
May 4 2022, 10:37 AM

Apr 27 2022

s434n added a comment to T29143: [MultiLabel Segmentation] Creating a segmentation "as new segmentation" fails.

I was able to reproduce the problem on the snapshot from two days ago. This new version fixes the problem for me, although the behavior is the same as @kalali described it. The newly created segmentation is a complete copy of the current one (including layers, labels, and masked regions of the labels), except for the changed region that was just segmented. I'm not sure if this is the expected behavior, but if it is everything seems to work fine.

Apr 27 2022, 11:58 AM · MITK (v2022.04)

Apr 26 2022

s434n triaged T29142: [Segmentation] Previews stay invisible if label was hidden as Low priority.
Apr 26 2022, 3:34 PM · MITK (v2022.10), Checklist
s434n triaged T29141: [Segmentation] Color change not immediately applied as Low priority.
Apr 26 2022, 3:02 PM · MITK (v2022.10), Checklist

Apr 25 2022

s434n committed rMITK213a5ab297df: avoid repetition of node name if it is already in the bounding box name (authored by s434n).
avoid repetition of node name if it is already in the bounding box name
Apr 25 2022, 3:25 PM