Page MenuHomePhabricator

Integration of an updated Feature Branch
Open, NormalPublic

Description

In the past, I have been working on the Radiomics Feature implementation and added a few bugfixes and smaller improvements to the features. However, I did not manage to merge my code prior to leaving the DKFZ and later on.

Recently, I've looked at my old branch with the plan to merge it into the main development branch. I've created a new branch and merged the old branch into it to ensure that the result is compiling and won't crash anythng. However, there were some major changes since I've left the DKFZ and I do not want accidantyl reintroduce old styles/methods/...

It would be great if someone from the active team could have a look at the branch and optiomally merge it into the main branch.

The actual branch is: T25826-RadiomicsUpdate-V4

Event Timeline

goetzm triaged this task as Normal priority.Jun 14 2023, 3:45 PM
goetzm created this task.

Didn't find any "critical" style issues. It is a single commit, right? rMITKc8283d2c7c3f: Smaller Bugfixes
You may want to search and replace "[Bb]oarder" with "[Bb]order", though, as I guess you intended to refer to "Rand" instead of "Untermieter". :)

@goetzm Thank you for the patch. We will look into it and merge it for parts that we keep (see T29649). If change your mind and want to maintain the rest of the classification code base in an extension, we can revisit it and see how we can help with merging the rest. Best Ralf