Page MenuHomePhabricator

Enable editing of PlanarPolygon
Closed, ResolvedPublic

Description

The module PlanarFigure shall be extended to allow adding and deletion of control points in ROIs (PlanarPolygon). The follwoing changes should be implemented:

1.) The state machine implemented in the class PlanarFigureInteractor needs to be extended with new states and transitions to allow adding and removing of control points in general, as described above (including the "hovering" effect of marker points when the mouse is over an existing edge of a polygon)

2.) The PlanarFigure module needs to ensure that removal and adding of control points only works for specific PlanarFigure objects. Several possibilities exist; one might be to add a parameter to PlanarFigure objects which allows / disallows adding / removing of control points. Also, a mechanism needs to be implemented to communicate the position of a marker point for adding control points.

3.) The class PlanarFigureMapper2D (responsible for drawing PlanarFigures) needs to be extended with the possibility to draw "marker points" when the mouse is over an existing edge of a polygon (on which control points can be added)

Event Timeline

[556a38]: Merge branch 'bug-7441-planarpolygon-editing-corrected'

  • bug-7441-pl

Merged commits:

2011-04-06 09:03:50 Markus Engel [789ec8]
PlanarFigureMapper can draw a preview of the control point that is to be added


2011-04-06 09:03:10 Markus Engel [aa985d]
PlanarFigureInteractor now supports inserting and deleting controlpoints

has been merged in master and is finished

[5ed02e]: Merge branch 'bug-7441-planarpolygon-editing-corrected'

  • bug-7441-pl

Merged commits:

2011-04-06 14:21:44 Markus Engel [a1f69e]
disabling adding and removing of control points if 'iseditable' is false


2011-04-06 14:14:56 Markus Engel [982e4f]
Merge branch 'bug-7633-planarfigure-statemachine-add-control-point' into bug-7441-planarpolygon-editing-corrected

  • bug-7633-planarfigure-statemachine-add-control-point: extended StateMachine.xml to support editing of PlanarFigures / Polygons

reopen for bug in interaction with some planarfigures

[dd95b6]: Merge branch 'bug-7441-planarpolygon-editing-corrected'

  • bug-7441-pl

Merged commits:

2011-04-11 14:27:26 Markus Engel [b75ce2]
correcting default property value for planarfigure interaction

reopen für Einarbeitung des Reviews

[4966bc]: Merge branch 'bug-7441-planarpolygon-editing-corrected'

  • bug-7441-pl

Merged commits:

2011-04-11 17:18:29 Markus Engel [e9885b]
fixing changes from review, removed old, commented or unncessary code

[17e85e]: Merge branch 'bug-7441-planarpolygon-editing-corrected'

  • bug-7441-pl

Merged commits:

2011-04-12 08:32:42 Markus Engel [d30a78]
removing unnecessary line that causes recursion

PlanarFigureIOTest should run again

reopen for bugfix, improving usement of boolflags to determine if editing of polygons is possible

[151890]: Merge branch 'bug-7441-planarpolygon-editing-corrected'

  • bug-7441-pl

Merged commits:

2011-04-12 17:08:42 Markus Engel [35ec16]
improving determining if inserting new points in ROI is possible

reopen for extension of documentation

[e77898]: Merge branch 'bug-7441-planarpolygon-editing-corrected'

  • bug-7441-pl

Merged commits:

2011-04-20 14:14:28 Markus Engel [98204f]
extending documentation on editing of PlanarPolygons