Page MenuHomePhabricator
Create Task
Maniphest T8506

Create unittest for class PlanarSubdivisionPolygon
Closed, ResolvedPublic
Actions

Description

Create a unittest for the class PlanarSubdivisionPolygon implemented with T8505.

Should test the correct calculation of the subdivision interpolation. All other functionalities should already be covered by the PlanarPolygon unittest. (ToDo: check if all functionalities are tested)

Related Objects
Search...

Event Timeline

saruji added projects: MITK, Bugzilla.Jun 15 2011, 12:01 PM
holfter added a subscriber: holfter.Jul 12 2011, 10:50 AM

Created unittest and copied the one from PlanarPolygon.
Additionally, the following checks are made:

  • Subdivision point generation depth (5 by default)
  • Tension parameter (0.0625 by default)
  • correct number o- Number of control points after placement
  • Test if property 'closed' is set by default
  • Number of polylines after placement subdivision points for this depth level (128)
  • Test if control points are in correct order in polyline
  • Test if subdivision points are calculated correctly (checking if subdivision point #48 actually has the coordinates that I precalculated for it)

TODO:

  • check for measurements (not working yet because measurements for PlanarSubdivisionPolygon still have to be implemented)
holfter added a comment.Jul 12 2011, 11:00 AM

unittest for PlanarSubdivisionPolygon (see T8505)

bug-8506-unittest-smooth-polygon.patch12 KBDownload

holfter added a comment.Jul 14 2011, 4:48 PM

updated patch, including fixes in planarSubdivisionPolygon.

bug-8506-unittest-smooth-polygon_NEW.patch36 KBDownload

saruji added a subscriber: saruji.Jul 18 2011, 12:56 PM

impplementiert in branch bug-8506-create-unittest-for-planarsubdivisionpolygon und
gemergt in branch bug-8505-implement-class-planarsubdivisionpolygon mit commit:
9f51fa7d8a9fc6a4eb8842792a5bd3347244c197
gemergt in master mit commit 3a68a00f9295ac0856f0454b78ebc99884de9cad

nolden added a subscriber: nolden.Jul 27 2011, 11:41 AM

Merging "applicazion modules" component with "ExtApp plugins"

saruji added a comment.Aug 9 2011, 2:40 PM

Due to changes on the class subdivision polygon the unittest needs to be modified.

saruji added a comment.Aug 9 2011, 2:50 PM

[f33ecc]: Merge branch 'bug-8506-create-unittest-for-planarsubdivisionpolygon' C

Merged commits:

2011-08-09 14:39:21 Danial Bin Mohamed Saruji [308b87]
added property initiallyplaced and set maximum numbers to 1000

MITK · MIC · IMSY · DKFZ