Page MenuHomePhabricator

Clean-up: executable bit removed from source files
Closed, WontfixPublic

Description

Hi,

I removed the executable bit from the source files using

chmod a-x | find . -executable -not -type d -name "*.someextension"

commands. Only two batch file and a ".bin" file remained there. (And the ".git/hooks/*.sample" files.)

If you want, you can merge a branch from here:
https://github.com/cim-unito/MITK/tree/bug-9-executable_bit_on_source_files

Miklos

Event Timeline

Hi Miklos,

thanks for reporting.

Executing the command "find . -type f -perm -ugo+x", I've found a lot of executable files.

I will change their flags.

Before doing something like this, we should make sure that this state is conserved, otherwise we'll get the same state in half a year from now.

Have you talked to Marco about how to configure the repository or git hooks in a way that would avoid future executable bits? Probably there is an easy way to avoid that.

Also, when merging this, it coule be useful to inform all developers to merge your bugfix branch into their current work to avoid conflicts.

Hi,

have you found any solution to prevent this problem occurring again?

I do not think that a server-side hook is possible, because the repository there is "bare", that means the source files themselves are not present, so a hook could not examine them.

Thanks,
Miklos

I close this to reduce the number of my open tickets and also because of lack of interest. There is no trivial permanent solution, and the problem does not affect the functionality, anyway.

kislinsk added a project: Bulk Edit.
kislinsk removed a project: Bulk Edit.