Page MenuHomePhabricator
Feed Advanced Search

Aug 2 2016

khlebnikov added projects to T16848: Macros expecting being within mitk namespace: MITK, Bugzilla.
Aug 2 2016, 10:10 AM · MITK (2014-06), Bugzilla
khlebnikov added a comment to T13974: Undo functionality on planar figures would be useful..

One more (tiny) thing I added today is the FinalizedPlanarFigureEvent(). It didn't change any logic inside the PlanarFigure module itself - it's just useful for me (and maybe will be useful for someone else too).

Aug 2 2016, 9:59 AM · Auto-closed, Pull Request, Bugzilla, MITK
khlebnikov added a comment to T13974: Undo functionality on planar figures would be useful..

thanks for the info. Given that there's only one two xml files that I modified, and they are also change in only one of commits, I can handle that manually.

Aug 2 2016, 9:59 AM · Auto-closed, Pull Request, Bugzilla, MITK
khlebnikov added a comment to T13974: Undo functionality on planar figures would be useful..

Ok, I guess the easiest solution would be to create the patch and then use a batch file to remove trailing whitespaces from patch files directly.

Aug 2 2016, 9:59 AM · Auto-closed, Pull Request, Bugzilla, MITK
khlebnikov added a comment to T13974: Undo functionality on planar figures would be useful..

Hi Caspar,

Aug 2 2016, 9:59 AM · Auto-closed, Pull Request, Bugzilla, MITK
khlebnikov added a comment to T13974: Undo functionality on planar figures would be useful..

Comments point-by-point

Aug 2 2016, 9:59 AM · Auto-closed, Pull Request, Bugzilla, MITK
khlebnikov added a comment to T13974: Undo functionality on planar figures would be useful..

clang format removes trailing whitespaces, so once we agree on the final shape of the contribution - I'll just clang-format the files and it won't be a problem.

Aug 2 2016, 9:59 AM · Auto-closed, Pull Request, Bugzilla, MITK
khlebnikov added a comment to T13974: Undo functionality on planar figures would be useful..

Hi Caspar,

Aug 2 2016, 9:59 AM · Auto-closed, Pull Request, Bugzilla, MITK
khlebnikov added a comment to T13974: Undo functionality on planar figures would be useful..

I somehow thought that only the last commit needs to be signed off. If every commit needs to be, then I think it will be way easier if I formatted a patch instead of pull request and added the sign off manually to each patch file.

Aug 2 2016, 9:59 AM · Auto-closed, Pull Request, Bugzilla, MITK
khlebnikov added a comment to T13948: Rework mitkSurfaceGLMapper2D.

(IMPORTANT!)
I have pushed a new change to the pull request branch. Basically, I removed the custom vtk polydata iterator as it didn't serve the purpose of saving memory (due to within-iterator cache), but caused problems with linux builds. Just changed it to a plain vector of cgal triangles - this is both fast and reliable.

Aug 2 2016, 9:59 AM · Bugzilla, MITK
khlebnikov added a comment to T13948: Rework mitkSurfaceGLMapper2D.

Additionally, fixed some memory leaks.
Commit pushed to branch.

Aug 2 2016, 9:59 AM · Bugzilla, MITK
khlebnikov added a comment to T13948: Rework mitkSurfaceGLMapper2D.

Hi guys. I made a pull request https://github.com/MITK/MITK/pull/73
There, the AABB_Tree provided by CGAL is used to cut through the surfaces. In my tests, this is was at least 4-5 times faster than vtkCutter. Enjoy :) And let me know if it is not working as expected.

Aug 2 2016, 9:59 AM · Bugzilla, MITK
khlebnikov added a comment to T12130: MITK main window comes top when moving mouse over it.

Hi, seems that setWindowOpacity() leads to flickering in Windows (tested with Qt 5.3.2). Instead, setting null parent helps avoiding the problem as well as the flickering.

Aug 2 2016, 9:54 AM · MITK (2015-03), Bugzilla
khlebnikov added a comment to F845: Fixed-flickering-problem.patch.

Patch with fix.

Aug 2 2016, 9:54 AM
khlebnikov added a comment to T2662: Skin feature for MITK.

Just a couple of notes.

Aug 2 2016, 9:28 AM · Bugzilla, MITK
khlebnikov added a comment to T1447: Picking of DataTreeNodes via vtkPropPicker.

Yes, I added the pickable property for all nodes that need to be picked in my "business logic" code.

Aug 2 2016, 9:19 AM · Auto-closed, MITK, Bugzilla
khlebnikov added a comment to T1447: Picking of DataTreeNodes via vtkPropPicker.

Take a look at the pull request - will this do the job?

Aug 2 2016, 9:19 AM · Auto-closed, MITK, Bugzilla
khlebnikov added a comment to T1447: Picking of DataTreeNodes via vtkPropPicker.

Hi guys, any news on this front?

Aug 2 2016, 9:19 AM · Auto-closed, MITK, Bugzilla