One more (tiny) thing I added today is the FinalizedPlanarFigureEvent(). It didn't change any logic inside the PlanarFigure module itself - it's just useful for me (and maybe will be useful for someone else too).
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Aug 2 2016
thanks for the info. Given that there's only one two xml files that I modified, and they are also change in only one of commits, I can handle that manually.
Ok, I guess the easiest solution would be to create the patch and then use a batch file to remove trailing whitespaces from patch files directly.
Hi Caspar,
Comments point-by-point
clang format removes trailing whitespaces, so once we agree on the final shape of the contribution - I'll just clang-format the files and it won't be a problem.
Hi Caspar,
I somehow thought that only the last commit needs to be signed off. If every commit needs to be, then I think it will be way easier if I formatted a patch instead of pull request and added the sign off manually to each patch file.
(IMPORTANT!)
I have pushed a new change to the pull request branch. Basically, I removed the custom vtk polydata iterator as it didn't serve the purpose of saving memory (due to within-iterator cache), but caused problems with linux builds. Just changed it to a plain vector of cgal triangles - this is both fast and reliable.
Additionally, fixed some memory leaks.
Commit pushed to branch.
Hi guys. I made a pull request https://github.com/MITK/MITK/pull/73
There, the AABB_Tree provided by CGAL is used to cut through the surfaces. In my tests, this is was at least 4-5 times faster than vtkCutter. Enjoy :) And let me know if it is not working as expected.
Hi, seems that setWindowOpacity() leads to flickering in Windows (tested with Qt 5.3.2). Instead, setting null parent helps avoiding the problem as well as the flickering.
Patch with fix.
Just a couple of notes.
Yes, I added the pickable property for all nodes that need to be picked in my "business logic" code.
Take a look at the pull request - will this do the job?
Hi guys, any news on this front?