Page MenuHomePhabricator

khlebnikov (Rostislav Khlebnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (303 w, 3 d)

Recent Activity

Aug 2 2016

khlebnikov added projects to T19392: QActions memory leak in QmitkExtWorkbenchWindowAdvisor: MITK, Bugzilla.
Aug 2 2016, 10:22 AM · Auto-closed, MITK, Bugzilla
khlebnikov added a comment to T19355: Python Library is loaded from System/Win32 instead of the one provided by MITK.

After some unsuccessful attempts with manifests, I ended up solving the problem by simply modifying the python lib and dll name to python27_mitk. Clearly, no conflict is present anymore. Let me know if you want the patch. Not sure I can separate it from my changes allowing debug config being built.

Aug 2 2016, 10:22 AM · Auto-closed, Bugzilla, MITK
khlebnikov added a comment to T19316: Crash when drag and drop nodes.

This _might_ also be the reason for this bug:
http://bugs.mitk.org/show_bug.cgi?id=18197

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19316: Crash when drag and drop nodes.

Happy to help :)

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added projects to T19316: Crash when drag and drop nodes: MITK, Bugzilla.
Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19299: SceneIORewrite: Incremental saving.

Well, the UpdateArchive is conceptually already in my pull request - the code that compares the time stamps essentially does that. However, I agree there might be a better approach to store the "state" (the time stamps and file name of the scene file). Given that this is basically per-application-instance information, we could use either a temporary external file instead of storing this state in the SceneIO itself, or, even better, use berry Preferences to store it.

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19299: SceneIORewrite: Incremental saving.

Daniel, I agree with most of what you are saying, but here are some thoughts.

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19295: SceneIORewrite: Asynchronous Serialization.

Here's a discussion that we had with Miklos Espak some time ago regarding the auto-saving and what problems might arise when implementing it. I think it's meaningful to revisit this before going to implementation.

Aug 2 2016, 10:21 AM · Auto-closed, Bugzilla, MITK
khlebnikov added a comment to T19268: Workbench crash on close.

Yes, of course. Forgot that again, apologies :)

Aug 2 2016, 10:21 AM · MITK (2016-03), Bugzilla
khlebnikov added a comment to T19268: Workbench crash on close.

Yeah, my problem disappeared with those fixes. And I also found it strange that MitkWorkbench itself is working fine. Furthermore if, for example, I loaded a project and then closed it - no crash happened upon closing my app. But as you said, the fix is simple and reasonable, so big thanks for merging it in (one less difference for my MITK fork :)).

Aug 2 2016, 10:21 AM · MITK (2016-03), Bugzilla
khlebnikov added a comment to F1267: 0001-Fixed-a-dangling-pointer.patch.

Dangling pointer fix

Aug 2 2016, 10:21 AM
khlebnikov added a comment to T19268: Workbench crash on close.

I honestly am not sure what is going on so deep in blueberry, but seemingly fixing the first problem unveiled another one. The second patch fixes that one.

Aug 2 2016, 10:21 AM · MITK (2016-03), Bugzilla
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

Could you please make a change - I think it's easier in this case.

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

Also, in release mode the test also passes fine on my machine (actually, on a different one - this time using Win7, the rest being similar).

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

I added the comments you asked for, hope they will clear some things up for the future maintainer.

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

Sounds good!

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to F1261: mitkPlaneGeometryDataMapper2D.cpp.

Commented source

Aug 2 2016, 10:21 AM
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

Your renaming patch works fine if applied after my changes as well. The last thing to do after that is to rename IntersectIntervals to SubtractIntervals.

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to F1259: patches_and_ref_image.zip.

Added smaller threshold to image comparison function

Aug 2 2016, 10:21 AM
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

iteration 4

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to F1260: patches_and_ref_image.zip.

iteration 4

Aug 2 2016, 10:21 AM
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

Ok, hopefully the final iteration.
Instead of always using plane geometry itself to determine the bounds, which is definitely different from what it was before, I finally made the version that is consistent with the 3D plane geometry data mapper:

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

Added smaller threshold to image comparison function

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

Ref image should go into MITK-Data\RenderingTestData\ReferenceScreenshots

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

I created the test and also added some changes to the mapper itself.

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

Hi Caspar,

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

undesired gaps illustration

gaps.png (459×484 px, 4 KB)

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to F1257: gaps.png.

undesired gaps illustration

Aug 2 2016, 10:21 AM
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

Do you mean creating a rendering test?

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to F1258: patches_and_ref_image.zip.

Patches and reference image

Aug 2 2016, 10:21 AM
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

patch 2/2

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

(In reply to Caspar Jonas Goch from comment #8)

Do you happen to have example data you could share?

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to F1255: 0001-Plane-geometry-data-mapper-crash-and-correctness-fix.patch.

patch 1/2

Aug 2 2016, 10:21 AM
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

patch 1/2

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to T19247: Crosshair rendering crash for small reslice rendering windows.

Well, I've written my own implementation for interval arithmetic. Applying the following two patches should bring it to the good state without using boost.

Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added a comment to F1256: 0002-Own-implementation-of-interval-arithmetic-needed.patch.

patch 2/2

Aug 2 2016, 10:21 AM
khlebnikov added projects to T19226: Incremental saving of MITK project files: MITK, Bugzilla.
Aug 2 2016, 10:21 AM · Bugzilla, MITK
khlebnikov added projects to T19070: Crash in BlueBerry preferences: MITK, Bugzilla.
Aug 2 2016, 10:20 AM · Bugzilla, MITK
khlebnikov added projects to T18930: Change from vtkUnstructuredGrid to vtkUnstructuredGridBase: MITK, Bugzilla.
Aug 2 2016, 10:19 AM · Auto-closed, Bugzilla, MITK
khlebnikov added a comment to F1238: 0001-Change-vtkUnstructuredGrid-to-vtkUnstructuredGridBas.patch.

patch

Aug 2 2016, 10:19 AM
khlebnikov added projects to T18864: Planar figure interaction incorrect point validity check: MITK, Bugzilla.
Aug 2 2016, 10:19 AM · MITK, Bugzilla
khlebnikov added projects to T18569: Inserting new control points to SubdivisionPolygon doesn't work: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · Bugzilla, MITK
khlebnikov added projects to T18565: Plugin names cannot contain underscore symbols: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · Bugzilla, MITK
khlebnikov added a comment to T18553: Qt5 Linux rendering - depth buffer problems.

I understand. I actually tested this on Ubuntu 14 machine and it definitely fixed the z-buffer issue that I had there - I'm not sure which GPU is there though. Similarly, it fixed the issue in Ubuntu running in virtual box.

Aug 2 2016, 10:17 AM · Bugzilla, MITK
khlebnikov added a comment to T18553: Qt5 Linux rendering - depth buffer problems.

I believe this is related to this:
https://bugreports.qt-project.org/browse/QTBUG-42360

Aug 2 2016, 10:17 AM · Bugzilla, MITK
khlebnikov added a comment to T18553: Qt5 Linux rendering - depth buffer problems.

http://public.kitware.com/pipermail/vtk-developers/2014-May/014998.html

Aug 2 2016, 10:17 AM · Bugzilla, MITK
khlebnikov added a comment to T18552: Qt5 plugins installation/packaging.

Actually it's better also to request qt.conf file, so the call is like
install_qt5_executable("bin/${MY_APP_NAME}${CMAKE_EXECUTABLE_SUFFIX}" "${Qt5Gui_PLUGINS};${Qt5Sql_PLUGINS}" "" "" "plugins", TRUE)

Aug 2 2016, 10:17 AM · Bugzilla, MITK
khlebnikov added a comment to T18552: Qt5 plugins installation/packaging.

Comma is of course redundant
install_qt5_executable("bin/${MY_APP_NAME}${CMAKE_EXECUTABLE_SUFFIX}" "${Qt5Gui_PLUGINS};${Qt5Sql_PLUGINS}" "" "" "plugins" TRUE)

Aug 2 2016, 10:17 AM · Bugzilla, MITK
khlebnikov added a comment to T18552: Qt5 plugins installation/packaging.

Also, for SVG icons to work, it is necessary to install svg plugin as well, so the line should be:

Aug 2 2016, 10:17 AM · Bugzilla, MITK
khlebnikov added projects to T18552: Qt5 plugins installation/packaging: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · Bugzilla, MITK
khlebnikov added a comment to F1196: DeployQt5.cmake.

Modified deployment script

Aug 2 2016, 10:17 AM
khlebnikov added a comment to F1197: QVTKWidget2.patch.

Replace QVTKWidget with QVTKWidget2 patch.

Aug 2 2016, 10:17 AM
khlebnikov added projects to T18553: Qt5 Linux rendering - depth buffer problems: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · Bugzilla, MITK
khlebnikov added a comment to T18533: Different lookup tables for different renderers broken (mitkImageVtkMapper2D).

For example, this is what I modified the ApplyLookuptable function to look like (see attachment).

Aug 2 2016, 10:17 AM · Auto-closed, MITK, Bugzilla
khlebnikov added a comment to T18533: Different lookup tables for different renderers broken (mitkImageVtkMapper2D).

My users did not report any problems since I've changed this in my fork.

Aug 2 2016, 10:17 AM · Auto-closed, MITK, Bugzilla
khlebnikov added a comment to T18533: Different lookup tables for different renderers broken (mitkImageVtkMapper2D).

ApplyLookuptable

Aug 2 2016, 10:17 AM · Auto-closed, MITK, Bugzilla
khlebnikov added a comment to F1194: ApplyLookuptable.cpp.

ApplyLookuptable

Aug 2 2016, 10:17 AM
khlebnikov added projects to T18533: Different lookup tables for different renderers broken (mitkImageVtkMapper2D): MITK, Bugzilla.
Aug 2 2016, 10:17 AM · Auto-closed, MITK, Bugzilla
khlebnikov added a comment to F1182: 0001-Fixed-a-crash-for-loading-images-with-active-scalars.patch.

patch

Aug 2 2016, 10:17 AM
khlebnikov added a comment to T18496: Crash while loading *.vtk Images with ITK VTKImageIO.

I think this is related: when loading a vti/vtk image with active scalar array not set, the application crashes. Attached is a simple patch. Consider it signed-off if you like to integrate it.

Aug 2 2016, 10:17 AM · Auto-closed, MITK, Bugzilla
khlebnikov added a comment to T18496: Crash while loading *.vtk Images with ITK VTKImageIO.

I think this is related: when loading a vti/vtk image with active scalar array not set, the application crashes. Attached is a simple patch. Consider it signed-off if you like to integrate it.

Aug 2 2016, 10:17 AM · Auto-closed, MITK, Bugzilla
khlebnikov added a comment to F1181: 0001-Fixed-a-crash-for-loading-images-with-active-scalars.patch.

patch

Aug 2 2016, 10:17 AM
khlebnikov added projects to T18414: Context menu item search behaves differently for single selection vs multiple selection: MITK, Bugzilla.
Aug 2 2016, 10:16 AM · MITK (v2022.10)
khlebnikov added a comment to F1176: 0001-Different-behavior-for-single-and-multiple-selection.patch.

Patch with fix.

Aug 2 2016, 10:16 AM
khlebnikov added a comment to T18124: Build debug Python on Windows.

An additional patch to resolve the name clash of debug and release PythonQt libraries.

Aug 2 2016, 10:14 AM · Bugzilla, MITK
khlebnikov added a comment to T18124: Build debug Python on Windows.

Here's a patch that contains some changes I made to build the debug version. I didn't check OpenCV so perhaps some more things need to be done, but the general gist should be clear. The patch is not based on the master, but I think resolving the conflicts should be very easy.

Aug 2 2016, 10:14 AM · Bugzilla, MITK
khlebnikov added a comment to F1144: 0001-PythonQt-debug-and-release-name-clash-resolved.patch.

patch part 2

Aug 2 2016, 10:14 AM
khlebnikov added a comment to F1143: 0001-Enabling-debug-python-build.patch.

patch

Aug 2 2016, 10:14 AM
khlebnikov added a comment to T18092: Crash on deleting planar figures from DataManager.

Guys, please refer to this e-mail of mine.
https://www.mail-archive.com/mitk-users@lists.sourceforge.net/msg05149.html

Aug 2 2016, 10:14 AM · MITK (2014-10), Bugzilla
khlebnikov added projects to T18039: Crash on picking prop assemblies: MITK, Bugzilla.
Aug 2 2016, 10:14 AM · Bugzilla, MITK
khlebnikov added a comment to T18039: Crash on picking prop assemblies.

Fixed: https://github.com/MITK/MITK/pull/76

Aug 2 2016, 10:14 AM · Bugzilla, MITK
khlebnikov added a comment to T18039: Crash on picking prop assemblies.

Fixed: https://github.com/MITK/MITK/pull/76

Aug 2 2016, 10:14 AM · Bugzilla, MITK
khlebnikov added a comment to T18025: Filtering nodes in data manager using QSortFilterProxyModel.

Hi, the bug with deleting/reordering nodes was fixed and integrated into master - see https://github.com/MITK/MITK/blob/master/Plugins/org.mitk.gui.qt.datamanager/src/QmitkDataManagerView.cpp - lines 901-906.

Aug 2 2016, 10:14 AM · Bugzilla, MITK
khlebnikov added projects to T18023: Loading of base datas is not reflected in the progress bar when loading a scene: MITK, Bugzilla.
Aug 2 2016, 10:14 AM · Bugzilla, MITK
khlebnikov added a comment to T18023: Loading of base datas is not reflected in the progress bar when loading a scene.

https://github.com/MITK/MITK/pull/74

Aug 2 2016, 10:14 AM · Bugzilla, MITK
khlebnikov added projects to T18025: Filtering nodes in data manager using QSortFilterProxyModel: MITK, Bugzilla.
Aug 2 2016, 10:14 AM · Bugzilla, MITK
khlebnikov added a comment to T18013: Replace ImageVtkMapper2D routines with vtkAlgorithm based filters.

In case anyone has similar needs, one more thing could be added. Property to instruct mitkImageVTKMapper2D to render gradient magnitude instead of an actual image without preparing full 3D gradient magnitude image. I have implementation that uses vtkImageGradientMagnitude filter and vtkImageHistogramStatistics to set the gradient magnitude to color mapping.

Aug 2 2016, 10:14 AM · Auto-closed, Bugzilla, MITK
khlebnikov added a comment to T18013: Replace ImageVtkMapper2D routines with vtkAlgorithm based filters.

In case anyone has similar needs, one more thing could be added. Property to instruct mitkImageVTKMapper2D to render gradient magnitude instead of an actual image without preparing full 3D gradient magnitude image. I have implementation that uses vtkImageGradientMagnitude filter and vtkImageHistogramStatistics to set the gradient magnitude to color mapping.

Aug 2 2016, 10:14 AM · Auto-closed, Bugzilla, MITK
khlebnikov added projects to T17755: DataManager drag-n-drop crashes on large 64-bit addresses: MITK, Bugzilla.
Aug 2 2016, 10:12 AM · Bugzilla, MITK
khlebnikov added a comment to T17623: PlanarSubdivisionPolygon is not well integrated.

Great! Thank you!

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to T17623: PlanarSubdivisionPolygon is not well integrated.

Also, yes, I need the closed curve, so for now it would be nice to have the subdivision polygon functionality.

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to T17623: PlanarSubdivisionPolygon is not well integrated.

Yes, that is completely OK. You probably look at a different user (I have two forks under "khlebnikov" and "rkhlebnikov" - there was a reason for that, but I will soon delete the fork under "khlebnikov"). So if you look at the "rkhlebnikov" fork - the branch should be there. Plus, I'm pretty sure that you can merge the pull request (as opposed to a branch): https://help.github.com/articles/merging-a-pull-request

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to T17622: PlanarFigureInteractor::SetPreviewPointPosition works incorrectly.

This bug is present in the current master branch.

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to T17623: PlanarSubdivisionPolygon is not well integrated.

I will try that out and write a comment about the outcome here.

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to F1113: PlanarSubdivisionPolygonIcon.zip.

Icon in PNG and SVG

Aug 2 2016, 10:11 AM
khlebnikov added a comment to T17622: PlanarFigureInteractor::SetPreviewPointPosition works incorrectly.

Bug is fixed in the current release

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to F1114: PlanarEllipseIcon.zip.

Ellipse icon in SVG and PNG

Aug 2 2016, 10:11 AM
khlebnikov added a comment to T17623: PlanarSubdivisionPolygon is not well integrated.

I actually use it for the cases where manual segmentation of 2D contour of a vessel is needed. Probably I could use the recently added Bezier curve planar figure for the same purpose.

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to T17623: PlanarSubdivisionPolygon is not well integrated.

Ellipse icon in SVG and PNG

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added projects to T17623: PlanarSubdivisionPolygon is not well integrated: MITK, Bugzilla.
Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to T17623: PlanarSubdivisionPolygon is not well integrated.

Pull request submitted:
https://github.com/MITK/MITK/pull/57

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to T17623: PlanarSubdivisionPolygon is not well integrated.

Also, made an icon for ellipse.

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added projects to T17622: PlanarFigureInteractor::SetPreviewPointPosition works incorrectly: MITK, Bugzilla.
Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to T17376: Visual Studio 2013 compatibility.

I have successfully imported a local directory with the DICOM editor - if this works as any kind of DICOM functionality test.

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to T17376: Visual Studio 2013 compatibility.

Pull request submitted: https://github.com/MITK/MITK/pull/47

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to T17376: Visual Studio 2013 compatibility.

Hi Marco,

Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added projects to T17376: Visual Studio 2013 compatibility: MITK, Bugzilla.
Aug 2 2016, 10:11 AM · Bugzilla, MITK
khlebnikov added a comment to T17076: Last undo operation does not trigger RequestUpdateAll.

Pull request submitted
https://github.com/MITK/MITK/pull/58

Aug 2 2016, 10:10 AM · Bugzilla, MITK
khlebnikov added projects to T17076: Last undo operation does not trigger RequestUpdateAll: MITK, Bugzilla.
Aug 2 2016, 10:10 AM · Bugzilla, MITK
khlebnikov added a comment to T16848: Macros expecting being within mitk namespace.

Pull request submitted:
http://github.com/MITK/MITK/pull/56

Aug 2 2016, 10:10 AM · MITK (2014-06), Bugzilla