Page MenuHomePhabricator
Feed All Stories

Today

floca added a comment to T27968: CTP gets stuck on large import.
  • Regarding 1: This is done to ensure that you are notfied if a problem arrises in the dcmsend step?
  • Regarding 2: Do we have a test to verify if the problem still exists before we go into production with this? @gaoh: Was this a problem on the CTP side or on the DICOM4CHE side? So, did also other PACS like orthanc had the same problem?
  • Regarding 3: This road I would only go, if we also have a test suite ready to benchmark the performance and to ensure that we don't have the same problem problem. What kind of reciever would you use here.
Fri, Nov 27, 5:32 PM · Kaapana (internal)
scholzpa created T28034: Deep Learning for Sepsis Classification on Parameter Images.
Fri, Nov 27, 3:24 PM · Restricted Project
wiesenfa claimed T28033: +scale_* seems to not work in combination with ggList objects.
Fri, Nov 27, 3:23 PM · challengeR (v1.0)
m564f committed rKAAPANAf43c3d207b62: upate readme exemplary commands (authored by m564f).
upate readme exemplary commands
Fri, Nov 27, 2:34 PM
m564f committed rKAAPANA19c57e441115: grid-network nested with postrgres db - renaming to openmined-naming (authored by m564f).
grid-network nested with postrgres db - renaming to openmined-naming
Fri, Nov 27, 2:34 PM
m564f committed rKAAPANAd5f5d9422f36: node/gateway nested with postrgres db - renaming to openmined-naming (authored by m564f).
node/gateway nested with postrgres db - renaming to openmined-naming
Fri, Nov 27, 2:34 PM
m564f committed rKAAPANA6f940ebda43e: openmined node with nested postgres db (authored by m564f).
openmined node with nested postgres db
Fri, Nov 27, 2:34 PM
m564f committed rKAAPANAc5350286c1c1: id update (authored by m564f).
id update
Fri, Nov 27, 2:34 PM
wiesenfa created T28033: +scale_* seems to not work in combination with ggList objects.
Fri, Nov 27, 1:55 PM · challengeR (v1.0)
menjivar created T28032: Data visualization.
Fri, Nov 27, 11:13 AM · Restricted Project
kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.

PACKAGE_DEPENDS now properly supports Boost, OpenMesh, OpenMP, OpenSSL, and Python3. For example:

Fri, Nov 27, 10:29 AM · Noteworthy, MITK (2020)
t391x closed T28031: Toms Test Task as Invalid.
Fri, Nov 27, 10:15 AM · Unknown Object (Project)
kislinsk committed rMITK7b7ee8878f4c: Use package depends file for OpenMP (authored by kislinsk).
Use package depends file for OpenMP
Fri, Nov 27, 9:59 AM
kislinsk committed rMITK60465748878a: Use package depends files for cpprestsdk and OpenSSL (authored by kislinsk).
Use package depends files for cpprestsdk and OpenSSL
Fri, Nov 27, 9:59 AM
kislinsk committed rMITK060a408bbbc8: Introduce TARGET_DEPENDS option (authored by kislinsk).
Introduce TARGET_DEPENDS option
Fri, Nov 27, 9:59 AM
kislinsk committed rMITK52b1bcb0fbe7: Improved Boost package depends file (authored by kislinsk).
Improved Boost package depends file
Fri, Nov 27, 9:59 AM
kislinsk committed rMITKf0334bdaacfe: Use package depends file for OpenMesh (authored by kislinsk).
Use package depends file for OpenMesh
Fri, Nov 27, 9:59 AM
kislinsk committed rMITK6aba543698a3: Remove dangling package depends file (authored by kislinsk).
Remove dangling package depends file
Fri, Nov 27, 9:59 AM
kislinsk committed rMITK5ab8273f7517: Improve Qt5 package depends file (authored by kislinsk).
Improve Qt5 package depends file
Fri, Nov 27, 9:59 AM
kislinsk committed rMITKd7ce88180b51: Improve Poco package depends file (authored by kislinsk).
Improve Poco package depends file
Fri, Nov 27, 9:59 AM
kislinsk committed rMITKa05e410e0585: Use package depends file for Python3 (authored by kislinsk).
Use package depends file for Python3
Fri, Nov 27, 9:59 AM
kislinsk committed rMITK665a1d1281a6: Improve ITK package depends file (authored by kislinsk).
Improve ITK package depends file
Fri, Nov 27, 9:59 AM
kislinsk committed rMITK6ea1fd8356da: Add Boost dependencies (authored by kislinsk).
Add Boost dependencies
Fri, Nov 27, 9:59 AM
kislinsk committed rMITKc670e289d6e7: Merge branch 'bugfix/T28002-ImprovePackageDependsFiles' into develop (authored by kislinsk).
Merge branch 'bugfix/T28002-ImprovePackageDependsFiles' into develop
Fri, Nov 27, 9:59 AM
nolden committed rMITK6eaeaca7975f: Fix uninitialized reference warning/error (authored by nolden).
Fix uninitialized reference warning/error
Fri, Nov 27, 9:21 AM
nolden committed rMITK857976ed83c8: Fix uninitialized reference warning/error (authored by nolden).
Fix uninitialized reference warning/error
Fri, Nov 27, 9:20 AM

Yesterday

eisenman moved T27420: report text from In Progress to Done on the challengeR (v1.0) board.

Compensated for 2. Text was revised in T27677.

Thu, Nov 26, 10:35 PM · challengeR (v1.0)
eisenman committed rCHALLENGEReffec2e25455: Merge branch 'feature/T27770-ImproveReportFormat' into develop (authored by eisenman).
Merge branch 'feature/T27770-ImproveReportFormat' into develop
Thu, Nov 26, 10:33 PM
eisenman committed rCHALLENGER0f1d4a7a652a: Add page breaks such that descriptions appear along with the plot (authored by eisenman).
Add page breaks such that descriptions appear along with the plot
Thu, Nov 26, 10:32 PM
nolden added a comment to T28006: MatchPointRegistration module compilation fails with Clang 11.

https://phabricator.mitk.org/D443

Thu, Nov 26, 4:20 PM · MITK
nolden added a comment to T28006: MatchPointRegistration module compilation fails with Clang 11.

I can confirm this fixes the issue, I can merge it tomorrow

Thu, Nov 26, 4:18 PM · MITK
eisenman moved T27420: report text from Backlog to In Progress on the challengeR (v1.0) board.
Thu, Nov 26, 3:38 PM · challengeR (v1.0)
neher committed rMITKDIFF7377ebb4907d: Merge branch 'T28017-VTK9' (authored by neher).
Merge branch 'T28017-VTK9'
Thu, Nov 26, 3:09 PM
neher committed rMITKDIFFf6421a87b933: cell array nextcell (authored by neher).
cell array nextcell
Thu, Nov 26, 3:09 PM
neher committed rMITKDIFF96cc00455433: update vtk connectomics (authored by neher).
update vtk connectomics
Thu, Nov 26, 3:09 PM
neher committed rMITKDIFFeef11174f790: Merge branch 'T28017-VTK9' (authored by neher).
Merge branch 'T28017-VTK9'
Thu, Nov 26, 3:09 PM
holzwart closed T28005: General Code Review as Resolved.
Thu, Nov 26, 1:21 PM
schererj updated subscribers of T27968: CTP gets stuck on large import.

I would consider three different variants:

  1. Keep CTP as receiver -> move the dcmsend from ctp-pipeline to airflow (unknown end of transfer issue)
  2. Keep CTP as receiver and change the DICOMweb send pipline-step to the old DIMSE step (possible issue with missing slices <-> really fast)
  3. Don't use CTP at all -> Start a DICOM receiver in Airflow as a sensor and trigger DAGs at arrival (performance unknown)
Thu, Nov 26, 1:03 PM · Kaapana (internal)
schererj moved T28018: Firecracker-AWS Isolated container from Discussion to Resolved on the Kaapana (internal) board.
Thu, Nov 26, 12:56 PM · Request for Discussion, Kaapana (internal)
schererj closed T28018: Firecracker-AWS Isolated container as Resolved.
Thu, Nov 26, 12:56 PM · Request for Discussion, Kaapana (internal)
neher added a comment to T28017: Update to vtk 9.

Pushed new branch T28017-VTK9-CodeIssues.

Thu, Nov 26, 12:51 PM · MITK Diffusion
k656s committed rKAAPANAbec48f53585f: changed slack color (authored by k656s).
changed slack color
Thu, Nov 26, 12:35 PM
k656s committed rKAAPANAfb0b9db9dba2: fixed missing slack link (authored by k656s).
fixed missing slack link
Thu, Nov 26, 12:33 PM
k656s committed rKAAPANA1baecd277fb5: slack link (authored by k656s).
slack link
Thu, Nov 26, 12:30 PM
gaoh added a comment to T27968: CTP gets stuck on large import.

In T27573 we discussed the problem of data transfer from CTP to DCM4CHE.
So basically it is a kind of similar problem: A datatransfer between CTP and DCM4CHE fails.
The problem is then, CTP just keeps the data in the queue (here) or inserts in the quarantine folder (T27573).
Anyway, we do not get notified, that there is a problem.

Thu, Nov 26, 12:09 PM · Kaapana (internal)
eisenman added a comment to T28016: embed web app in package.

It sounds nice, but I also think that we can run into cumbersome situations w.r.t. package management and version control with this approach: If the web app is located within the package, for each change to the package itself, it has to be investigated how the change affects the web app. The developer also has to adapt and test the web app then. This also means that for each package release, a corresponding web app has to be provided. In my opinion it makes more sense to focus either on the package or the web app during the development. Probably, we want to improve the web app that is based on a fixed package version x most frequently. This use case is then hampered by this approach as the package itself also evolves.

Thu, Nov 26, 12:07 PM · challengeR (v1.0)
schererj archived Kaapana (internal) (Open Source Rocketplant).
Thu, Nov 26, 10:56 AM
s669m raised the priority of T28018: Firecracker-AWS Isolated container from Normal to Unbreak Now!.
Thu, Nov 26, 10:51 AM · Request for Discussion, Kaapana (internal)
s669m triaged T28018: Firecracker-AWS Isolated container as Normal priority.
Thu, Nov 26, 10:13 AM · Request for Discussion, Kaapana (internal)
neher committed rMITKDIFF72706e00fe52: vtk changes (authored by neher).
vtk changes
Thu, Nov 26, 9:09 AM
neher added a comment to T28017: Update to vtk 9.

Pushed new branch T28017-VTK9.

Thu, Nov 26, 9:09 AM · MITK Diffusion
neher claimed T28017: Update to vtk 9.
Thu, Nov 26, 9:08 AM · MITK Diffusion
neher triaged T28017: Update to vtk 9 as Normal priority.
Thu, Nov 26, 9:08 AM · MITK Diffusion
wiesenfa created T28016: embed web app in package.
Thu, Nov 26, 8:48 AM · challengeR (v1.0)

Wed, Nov 25

kislinsk triaged T28006: MatchPointRegistration module compilation fails with Clang 11 as Normal priority.
Wed, Nov 25, 11:47 PM · MITK
kislinsk added a comment to T28006: MatchPointRegistration module compilation fails with Clang 11.

After reading the itk::NumericTraits documentation and looking into the actual definitions of ZeroValue() I guess the fix could be:

Wed, Nov 25, 11:46 PM · MITK
kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.

TARGET_DEPENDS parameters are directly passed to target_link_libraries() and bypass the PACKAGE_DEPENDS mechanism.

Wed, Nov 25, 11:34 PM · Noteworthy, MITK (2020)
kislinsk added a project to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies: Noteworthy.

Public API change: Depending on VTK does not add a transitive dependency to Qt5 Widgets anymore, except, when the required VTK components have a public dependency to Qt5 Widgets of course.

Wed, Nov 25, 9:05 PM · Noteworthy, MITK (2020)
kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.

Fixed VTK and TinyXML-2 so far.

Wed, Nov 25, 8:49 PM · Noteworthy, MITK (2020)
kislinsk committed rMITKfc9c00185dfe: Move VTK-specific code to dedicated package depends file (authored by kislinsk).
Move VTK-specific code to dedicated package depends file
Wed, Nov 25, 8:46 PM
kislinsk committed rMITK64ae7f4ccf69: Use package depends file for TinyXML-2 (authored by kislinsk).
Use package depends file for TinyXML-2
Wed, Nov 25, 8:46 PM
kislinsk committed rMITK68f5331438a2: Merge branch 'bugfix/T28002-ImprovePackageDependsFiles' into develop (authored by kislinsk).
Merge branch 'bugfix/T28002-ImprovePackageDependsFiles' into develop
Wed, Nov 25, 8:46 PM
kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.

Pushed new branch bugfix/T28002-ImprovePackageDependsFiles.

Wed, Nov 25, 8:46 PM · Noteworthy, MITK (2020)
kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.

Holy moly, I just learned that the package depends files work completely different than I thought/was told the past 9 years. Instead of fixing the mitk_use_modules() function we just need to use the package depends files correctly.

Wed, Nov 25, 8:22 PM · Noteworthy, MITK (2020)
gaoh placed T24398: Dicom plugin: wdb Retrieve does not work up for grabs.

So for the current develop:
With or without CGET activated. When trying to Retrieve a dataset after Query, I get an Exception:

Wed, Nov 25, 3:36 PM · MITK
m113r created T28014: Additional Augmentation Refinement.
Wed, Nov 25, 12:53 PM · m113r
kalali added a member for MITK: a178n.
Wed, Nov 25, 11:35 AM
kislinsk changed the edit policy for MITK.
Wed, Nov 25, 11:26 AM
kislinsk archived mitk.org.
Wed, Nov 25, 11:25 AM
kislinsk archived SIDT.
Wed, Nov 25, 11:24 AM
gaoh closed Restricted Maniphest Task, a subtask of T27196: Rewrite packaging of MITK, as Invalid.
Wed, Nov 25, 10:57 AM · Cleared, MITK (2020)
thomass closed T27696: Dicom loading does not work for some 4D data with the latest installer as Resolved.
Wed, Nov 25, 8:25 AM · DICOM, Missing Info, MITK
kislinsk added a comment to T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies.
  • mitk_create_module() passes PACKAGE_DEPENDS to _mitk_parse_package_args()
    • The PACKAGE[|COMPONENT1[+COMPONENT2]...] is processed and the following variables are set in parent scope:
      • <PUBLIC|PRIVATE|INTERFACE>_PACKAGE_NAMES: Lists of package names for different visibilities
      • PACKAGE_NAMES: Joined lists from above (may contain duplicates!)
      • <PUBLIC|PRIVATE|INTERFACE>_<PACKAGE>_REQUIRED_COMPONENTS: Lists of components for different visibilities and packages
  • mitk_create_module() passes PACKAGE_NAMES to mitk_check_module_dependencies()
    • mitk_check_module_dependencies() passes PACKAGE_NAMES to _mitk_parse_package_args()
      • Notice that PACKAGE_NAMES does not contain visibilities anymore, so everything is put into PRIVATE_PACKAGE_NAMES by default
    • Nevertheless, all visibility lists are joined into package_names and duplicates are removed (why not just use PACKAGE_NAMES in the first place and remove duplicates?)
    • For each package, check if MITK_USE_<package> is not set and add package to _MISSING_DEP in parent scope together with missing modules
  • Also: Duplicates in PACKAGE_NAMES were removed by mitk_check_module_dependencies()
  • The module is disabled if there are any missing dependencies
  • PACKAGE_DEPENDS is passed to mitk_use_modules() as PACKAGES parameter
Wed, Nov 25, 8:02 AM · Noteworthy, MITK (2020)
kislinsk added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

@jsolislemus There's a workaround if you can't wait for the next release which would also verify if your issue is fixed:

Wed, Nov 25, 7:15 AM · MITK

Tue, Nov 24

kislinsk added a comment to T27985: Migrate from TinyXML to TinyXML-2.

Package dependency section depends on T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies!

Tue, Nov 24, 9:55 PM · Noteworthy, MITK (2020)
floca updated the task description for T27992: Release of MITK CLIs.
Tue, Nov 24, 9:22 PM · MITK (2020), Request for Discussion
gaoh claimed T24398: Dicom plugin: wdb Retrieve does not work.
Tue, Nov 24, 5:21 PM · MITK
floca added a comment to T27696: Dicom loading does not work for some 4D data with the latest installer.

@thomass could you check if the problem was realy just cuased by slow network drive and is solved. If this is the case, could you close the task? If the problem still exists, may be the issue solved by Stefan is a solution.

Tue, Nov 24, 5:17 PM · DICOM, Missing Info, MITK
floca added a comment to T24398: Dicom plugin: wdb Retrieve does not work.

@gaoh could you check if the problem is solved either with the branch or as soon as it is in develop?

Tue, Nov 24, 5:15 PM · MITK
floca added a comment to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

I would see it positiv. No sense crying over spilt milk. Thanks for solving that problem!

Tue, Nov 24, 5:12 PM · Cleared, MITK (2020)
thomass added a project to T28008: [Mapper] Levelwindow overwrites vtkLookUpTable Range with levelwindow range : Request for Discussion.

apparently a vtkLoopUpTable is set automatically so the property as such cannot be used to handle custom vtkLookUpTables

Tue, Nov 24, 4:07 PM · Request for Discussion, MITK
thomass triaged T28008: [Mapper] Levelwindow overwrites vtkLookUpTable Range with levelwindow range as Normal priority.
Tue, Nov 24, 2:25 PM · Request for Discussion, MITK
jsolislemus added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Hi, from what I've been reading, it seems this issue might be fixed? I read on T26264 that it might be fixed with a CMake variables related to the DCMTK dictionaries; although I'm not sure how could I implement it myself, while waiting for the next release (we're still developing on top of 2018.04.2). Thanks a lot for the effort, this error seemed very difficult to pinpoint.

Tue, Nov 24, 2:19 PM · MITK
jaegerp added a member for MIC: d587s.
Tue, Nov 24, 1:09 PM
m564f committed rKAAPANAc210006ac4fb: readme with helm install examples added (authored by m564f).
readme with helm install examples added
Tue, Nov 24, 10:26 AM
kislinsk removed a member for OP 4.1: kislinsk.
Tue, Nov 24, 10:14 AM
kislinsk added members for MIC: reicht, gaoh, kraeuter, d485r, rasheed, steint, graf, c082x, j762e, m097t, e249r, s669m, m139l.
Tue, Nov 24, 10:13 AM
kislinsk added members for MIC: kalali, a178n, kompan, floca, thomass.
Tue, Nov 24, 10:10 AM
kislinsk closed T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers, a subtask of T24398: Dicom plugin: wdb Retrieve does not work, as Resolved.
Tue, Nov 24, 9:53 AM · MITK
kislinsk closed T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers, a subtask of T26451: DICOM plugin cannot parse DICOM directories in macOS installer, as Resolved.
Tue, Nov 24, 9:53 AM · MITK
kislinsk closed T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers, a subtask of T27669: Dicom import issue with MITK binaries (package) and Ubuntu, as Resolved.
Tue, Nov 24, 9:53 AM · Missing Info, DICOM, MITK
kislinsk closed T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers as Resolved.
Tue, Nov 24, 9:53 AM · Cleared, MITK (2020)
kislinsk closed T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers, a subtask of T27696: Dicom loading does not work for some 4D data with the latest installer, as Resolved.
Tue, Nov 24, 9:53 AM · DICOM, Missing Info, MITK
kislinsk added a comment to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Mixed feelings here: On one hand I'm happy that we, with a single trivial line of CMake code, finally fixed a decade old severe issue we had in MITK without really noticing it causing quite some of inconvenience for our users without and we were not able to reproduce it over the years. Maybe we even lost some users right before they actually used MITK because "it cannot open my DICOM files". On the other hand, we fixed a decade old severe issue with a single line of CMake code.

Tue, Nov 24, 9:53 AM · Cleared, MITK (2020)
reinkea added a member for CAMI: t470h.
Tue, Nov 24, 9:51 AM
kislinsk added a member for MIC: s280a.
Tue, Nov 24, 9:43 AM
kislinsk removed a member for MIC: Unknown Object (User).
Tue, Nov 24, 9:38 AM
nolden created T28006: MatchPointRegistration module compilation fails with Clang 11.
Tue, Nov 24, 9:25 AM · MITK
kislinsk added a member for MIC: Unknown Object (User).
Tue, Nov 24, 9:19 AM
holzwart updated the task description for T28005: General Code Review.
Tue, Nov 24, 8:24 AM