Page MenuHomePhabricator
Feed All Stories

Fri, May 17

kompan renamed T30448: MITK snapshots/2024-05-02 Workbench not restarting from MITK snapshots/2023-12-06 Workbench not restarting to MITK snapshots/2024-05-02 Workbench not restarting.
Fri, May 17, 11:23 AM · MITK
kompan created T30448: MITK snapshots/2024-05-02 Workbench not restarting.
Fri, May 17, 10:17 AM · MITK

Thu, May 16

kompan added a project to T30204: Improve visibility between help files for perfusion: Next Milestone.
Thu, May 16, 10:05 AM · Next Milestone, Request for Discussion, MITK (v2024.06)
kompan added a project to T29638: ModelFit Inspector crahes sometimes on data selection: Next Milestone.
Thu, May 16, 10:05 AM · Next Milestone, MITK (v2024.06)
kompan added a project to T30432: [Perfusion] Possible to write text into info box: Next Milestone.
Thu, May 16, 10:04 AM · Next Milestone, MITK (v2024.06)
kompan added a project to T30439: [Perfusion] Only a selection of debug parameter images generated as sub-nodes: Next Milestone.
Thu, May 16, 10:03 AM · Next Milestone, Request for Discussion, Checklist, MITK (v2024.06)
kompan closed T27339: Provide public MITK ModelFit installer on a regular basis, a subtask of T27340: [ModelFit] Request for Mac Workbench installer, as Resolved.
Thu, May 16, 10:00 AM · Auto-closed, Restricted Project, MITK
kompan closed T27339: Provide public MITK ModelFit installer on a regular basis as Resolved.

This task is closed since the ModelFit/Perfusion views will be part of MITK v2024.06 and it is planned that they will be part of the official releases from MITK v2024.06 onwards.

Thu, May 16, 10:00 AM · MITK (v2024.06)
kompan added a project to T30296: [Perfusion] Concentration Curve Converter view does not hide options when deselecting 3D/4D: Next Milestone.
Thu, May 16, 9:54 AM · Next Milestone, MITK (v2024.06)
kompan added a project to T30437: [Perfusion] Provide example start parameter image for checklists: Next Milestone.
Thu, May 16, 9:53 AM · Next Milestone, Checklist, MITK (v2024.06)
kompan edited projects for T26288: MRI Perfusion view should only generate concentration images once, added: Next Milestone; removed Cleared.
Thu, May 16, 9:52 AM · Next Milestone, MITK (v2024.06)
kompan added a project to T30440: [Perfusion] Error when loading AIF from csv file in DCE MR Perfusion DataFit View: Next Milestone.
Thu, May 16, 9:46 AM · Next Milestone, Checklist, MITK (v2024.06)
kompan added a project to T30441: [Perfusion] Baseline range bug for variable flip angle conversion: Next Milestone.
Thu, May 16, 9:45 AM · Next Milestone, Checklist, MITK (v2024.06)
kompan closed T27739: Inspection positions deletion in ModelFit not updated in data display. as Resolved.
Thu, May 16, 9:42 AM · MITK (v2024.06), Cleared
kompan committed rMITK4f7293627beb: Fix collection of bugs in the ModelFitInspectorView. (authored by kompan).
Fix collection of bugs in the ModelFitInspectorView.
Thu, May 16, 9:37 AM
kompan committed rMITK9f2fc5b40ff0: SmartPointer for m_PositionBookmarksNode and m_PositionBookmarks. (authored by kompan).
SmartPointer for m_PositionBookmarksNode and m_PositionBookmarks.
Thu, May 16, 9:37 AM
kompan committed rMITK95d32ae25ec5: Remove empty line. (authored by kompan).
Remove empty line.
Thu, May 16, 9:37 AM
kompan committed rMITK5d4b27e52ee8: Fix comparison to resolve CI errors. (authored by kompan).
Fix comparison to resolve CI errors.
Thu, May 16, 9:37 AM
kompan committed rMITKa20f31105474: Use container iteration to iterated over static parameters. (authored by kompan).
Use container iteration to iterated over static parameters.
Thu, May 16, 9:37 AM
kompan committed rMITK9639faf6cc77: Remove old code. (authored by kompan).
Remove old code.
Thu, May 16, 9:37 AM
kompan committed rMITKb836340cf070: Hide "Additional input data visibilty" field (T30238) (authored by kompan).
Hide "Additional input data visibilty" field (T30238)
Thu, May 16, 9:36 AM
kompan committed rMITK5a4e9e52341d: Fix inspection positions deletion update (T27739). (authored by kompan).
Fix inspection positions deletion update (T27739).
Thu, May 16, 9:36 AM
kompan committed rMITK6118a45f16a3: Write vectors of all AIF and AIF Timegrid values into fit result table (T30237). (authored by kompan).
Write vectors of all AIF and AIF Timegrid values into fit result table (T30237).
Thu, May 16, 9:36 AM
kompan committed rMITKbe8a6b91885f: Correction to set same colors in display of curves and in the view settings… (authored by kompan).
Correction to set same colors in display of curves and in the view settings…
Thu, May 16, 9:36 AM
kompan committed rMITK8bd786bb3b1f: Remove dublication of infoOutput. (authored by kompan).
Remove dublication of infoOutput.
Thu, May 16, 9:36 AM

Wed, May 15

kislinsk removed a project from T30446: Decouple Workbench plugin from optional views: Request for Discussion.

Discussion result: Option B.

Wed, May 15, 1:19 PM · Next Milestone, MITK
kompan edited projects for T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes, added: Next Milestone; removed Request for Discussion, Checklist.
Wed, May 15, 11:42 AM · Next Milestone, MITK (v2024.06)
kompan added a comment to T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes.

In the MitkNodePredicateGeometry to precision is set to 1e-6. So this is at least one of the issues why the old masks are not found. It could be an option to relax the precision, but since the rotation matrix might have a large effect even for small inaccuracies, it needs to be thoroughly tested first how big the effect is if. e.g 1e-4 is accepted.
For now, the new segmentation masks are provided as test data instead of the old masks.

Wed, May 15, 11:41 AM · Next Milestone, MITK (v2024.06)
a178n closed T29197: [Segmentation] Is the classificationsegmentation-plugin used / required? as Resolved.

Already removed

Wed, May 15, 11:29 AM · MITK (v2024.06)
a178n removed a project from T30412: [Statistics] Planar figure cannot be set as ROI for askew images: Request for Discussion.
Wed, May 15, 11:29 AM · MITK, Next Milestone
a178n closed T30447: [TotalSeg] Levelwindow effect, a subtask of T29437: [SEG] Add TotalSegmentator, as Wontfix.
Wed, May 15, 11:18 AM · MITK
a178n closed T30447: [TotalSeg] Levelwindow effect as Wontfix.

Have in base class and decide wich tools will have it or not. Not ideal for Totalsegmentator

Wed, May 15, 11:18 AM · MITK
kompan moved T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes from Backlog to MITK Meeting on the Request for Discussion board.
Wed, May 15, 11:18 AM · Next Milestone, MITK (v2024.06)
kompan moved T30439: [Perfusion] Only a selection of debug parameter images generated as sub-nodes from Backlog to Cycle on the MITK (v2024.06) board.
Wed, May 15, 10:53 AM · Next Milestone, Request for Discussion, Checklist, MITK (v2024.06)
kompan moved T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes from Backlog to Cycle on the MITK (v2024.06) board.
Wed, May 15, 10:52 AM · Next Milestone, MITK (v2024.06)
floca moved T30447: [TotalSeg] Levelwindow effect from Backlog to MITK Meeting on the Request for Discussion board.
Wed, May 15, 9:52 AM · MITK
floca added a project to T30447: [TotalSeg] Levelwindow effect: Request for Discussion.
Wed, May 15, 9:52 AM · MITK
kislinsk moved T30446: Decouple Workbench plugin from optional views from Backlog to MITK Meeting on the Request for Discussion board.
Wed, May 15, 9:20 AM · Next Milestone, MITK

Tue, May 14

a178n added a comment to T30447: [TotalSeg] Levelwindow effect.

Pushed new branch to rMITK MITK: feature/T30447-totalseg-levelwindow.

Tue, May 14, 5:49 PM · MITK
a178n triaged T30447: [TotalSeg] Levelwindow effect as Normal priority.
Tue, May 14, 5:38 PM · MITK
a178n claimed T30430: [TotalSeg] Add check if python venv exists before installation.
Tue, May 14, 5:33 PM · MITK (v2024.06)
a178n added a comment to T30430: [TotalSeg] Add check if python venv exists before installation.

Pushed new branch to rMITK MITK: feature/T30430-python-venv-check.

Tue, May 14, 5:21 PM · MITK (v2024.06)
kompan added a project to T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes: Request for Discussion.
Tue, May 14, 11:36 AM · Next Milestone, MITK (v2024.06)
kompan added a comment to T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes.

I compared the geometry of the dynamic image, the old mask (which could not be found anymore) and a new mask (is found), using the Details info box in MITK. I found small differences in the geometries between the old mask and the dynamic image, but not between the new mask and the dynamic image. Namely:
Spacing:
dynamic image: [1.0156, 1.0156, 5.99998]
old mask: [1.0156, 1.0156, 5.99997]
new mask: [1.0156, 1.0156, 5.99998]

Tue, May 14, 11:36 AM · Next Milestone, MITK (v2024.06)
a178n claimed T30426: [SEG] Highlight importance of level window in Segment Anything.
Tue, May 14, 10:10 AM · Checklist, MITK (v2024.06)
a178n added a revision to T30426: [SEG] Highlight importance of level window in Segment Anything: Unknown Object (Differential Revision).
Tue, May 14, 10:07 AM · Checklist, MITK (v2024.06)
kislinsk triaged T30446: Decouple Workbench plugin from optional views as Normal priority.
Tue, May 14, 9:57 AM · Next Milestone, MITK
floca placed T30412: [Statistics] Planar figure cannot be set as ROI for askew images up for grabs.
Tue, May 14, 9:34 AM · MITK, Next Milestone
floca closed T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported as Wontfix.

Undo/redo is a known problem, covered by other tickets.
The crash propblem I was not able to reproduce.

Tue, May 14, 9:31 AM · Missing Info, Checklist, MITK (v2024.06)
floca committed rMITK1b29c1cf757a: T30444-Crash_when_working_with_labels (authored by floca).
T30444-Crash_when_working_with_labels
Tue, May 14, 9:28 AM
floca committed rMITKd50db49303c6: fixed typos (authored by floca).
fixed typos
Tue, May 14, 9:28 AM
floca committed rMITKb6bb9b40d428: Secured usage of GetLabel results to ensure that not nullptr access is (authored by floca).
Secured usage of GetLabel results to ensure that not nullptr access is
Tue, May 14, 9:28 AM
floca committed rMITK18037d1366b5: Changed return of GetLabel() to ensure secure usage of method with auto. (authored by floca).
Changed return of GetLabel() to ensure secure usage of method with auto.
Tue, May 14, 9:28 AM
kislinsk committed rMITK085d28103a7a: Merge branch 'bugfix/T30445-ChangeDefaultBuildConfig' into develop (authored by kislinsk).
Merge branch 'bugfix/T30445-ChangeDefaultBuildConfig' into develop
Tue, May 14, 8:29 AM
kislinsk closed T30445: Change default build configuration from Custom to WorkbenchRelease as Resolved.
Tue, May 14, 8:29 AM · MITK
kislinsk committed rMITK889397425908: Propagate CMAKE_CONFIGURATION_TYPES to MITK build (authored by kislinsk).
Propagate CMAKE_CONFIGURATION_TYPES to MITK build
Tue, May 14, 8:29 AM
kislinsk committed rMITK5a6eec50ba1a: Change default build configuration from Custom to WorkbenchRelease (authored by kislinsk).
Change default build configuration from Custom to WorkbenchRelease
Tue, May 14, 8:29 AM
kislinsk added a comment to T30445: Change default build configuration from Custom to WorkbenchRelease.

Deleted branch from rMITK MITK: bugfix/T30445-ChangeDefaultBuildConfig.

Tue, May 14, 8:29 AM · MITK
kislinsk added a comment to T30445: Change default build configuration from Custom to WorkbenchRelease.

Pushed new branch to rMITK MITK: bugfix/T30445-ChangeDefaultBuildConfig.

Tue, May 14, 8:28 AM · MITK
kislinsk triaged T30445: Change default build configuration from Custom to WorkbenchRelease as Low priority.
Tue, May 14, 8:22 AM · MITK

Mon, May 13

floca committed rMITKaf12ad9b29fe: T30442-fix_clear_label_content_refresh (authored by floca).
T30442-fix_clear_label_content_refresh
Mon, May 13, 1:39 PM
floca closed T30442: [SEG] Clear content on one label does not directly refresh the render windows as Resolved by committing rMITK9345a199763e: Fixed T30442.
Mon, May 13, 1:39 PM · MITK (v2024.06)
floca committed rMITK9345a199763e: Fixed T30442 (authored by floca).
Fixed T30442
Mon, May 13, 1:39 PM
kislinsk added a revision to T30444: [SEG] Crash when working a lot with labels on label delete : Unknown Object (Differential Revision).
Mon, May 13, 12:05 PM · MITK (v2024.06)
floca added a revision to T30442: [SEG] Clear content on one label does not directly refresh the render windows: Unknown Object (Differential Revision).
Mon, May 13, 11:55 AM · MITK (v2024.06)
floca moved T30444: [SEG] Crash when working a lot with labels on label delete from Backlog to Cycle on the MITK (v2024.06) board.
Mon, May 13, 11:29 AM · MITK (v2024.06)
kislinsk closed T30443: Tab button of 2nd view is not correctly rendered as Resolved.

Could also verify with Ubuntu and macOS installers that it only seems to happen on the Windows installers with Qt 6.6.1. Close as resolved.

Mon, May 13, 9:54 AM · MITK (v2024.06)
kislinsk added a comment to T30443: Tab button of 2nd view is not correctly rendered.

Qt 6.6.3 is the latest version of the Qt 6.6 range. I upgraded e230-nuc03. e230-nuc01 is not accessible via Remote Desktop because of expired credentials, have to upgrade later in office. Ubuntu 20.04 and 22.04 clients already build with Qt 6.6.2.

Mon, May 13, 9:33 AM · MITK (v2024.06)
kislinsk added a comment to T30443: Tab button of 2nd view is not correctly rendered.

I was surprised not being able to reproduce this issue anymore with my local build. I then tested the snapshot installer and I was able to reproduce. The only difference I see is Qt 6.6.1 (installer) vs. Qt 6.6.2 (local). I will upgrade Qt on our Windows CI clients and check again...

Mon, May 13, 9:00 AM · MITK (v2024.06)
kislinsk triaged T30443: Tab button of 2nd view is not correctly rendered as Normal priority.
Mon, May 13, 8:43 AM · MITK (v2024.06)
kislinsk claimed T30443: Tab button of 2nd view is not correctly rendered.
Mon, May 13, 8:43 AM · MITK (v2024.06)

Sat, May 11

floca added a comment to T30444: [SEG] Crash when working a lot with labels on label delete .

After monkey testing in RelWDebugInfo, I think I found a lead. It can happen due to different processing of the Qt event queue that GetLabel is queried in a widget on a label that does not exist anymore. But it is not checked if GetLabel returns nullptr. Which in this case can happen. I hope this will fix the problem..,

Sat, May 11, 12:24 PM · MITK (v2024.06)
floca triaged T30444: [SEG] Crash when working a lot with labels on label delete as Unbreak Now! priority.
Sat, May 11, 12:21 PM · MITK (v2024.06)
floca changed the visibility for F3651393: bug_tab.PNG.
Sat, May 11, 12:19 PM
floca changed the visibility for F3651396: bug_tab2.PNG.
Sat, May 11, 12:18 PM
floca created T30443: Tab button of 2nd view is not correctly rendered.
Sat, May 11, 12:17 PM · MITK (v2024.06)

Fri, May 10

floca triaged T30442: [SEG] Clear content on one label does not directly refresh the render windows as Low priority.
Fri, May 10, 3:04 PM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Deleted branch from rMITK MITK: bugfix/T26934-FixLogoAnnotation.

Fri, May 10, 2:57 PM · MITK (v2024.06)
kislinsk committed rMITKe6532b6e2a0f: Remove multi widget decoration manager duplicate (authored by kislinsk).
Remove multi widget decoration manager duplicate
Fri, May 10, 2:56 PM
kislinsk closed T26934: Multiple logos in screenshot when using screenshot maker plugin as Resolved by committing rMITK208cf8597f01: Remove multi widget decoration manager duplicate.
Fri, May 10, 2:56 PM · MITK (v2024.06)
kislinsk committed rMITK208cf8597f01: Remove multi widget decoration manager duplicate (authored by kislinsk).
Remove multi widget decoration manager duplicate
Fri, May 10, 2:56 PM
floca closed T30422: [SEG] Erase tool double click is irritating as Resolved.
Fri, May 10, 2:20 PM · Checklist, MITK (v2024.06)
floca committed rMITK196b8d8a4948: BREAKING: Removed background click feature from EraseRegionTool (authored by floca).
BREAKING: Removed background click feature from EraseRegionTool
Fri, May 10, 2:20 PM
floca committed rMITK4b9a5e0625e1: T30422-Remove_erase_tool_background_click (authored by floca).
T30422-Remove_erase_tool_background_click
Fri, May 10, 2:20 PM
floca committed rMITK6a2778e74939: T30417-Fix_confusing_highlighting_invisible_labels (authored by floca).
T30417-Fix_confusing_highlighting_invisible_labels
Fri, May 10, 2:19 PM
floca committed rMITK87c91fb3dedf: Fixed gcc error (authored by floca).
Fixed gcc error
Fri, May 10, 2:19 PM
floca closed T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX as Resolved by committing rMITK27cad36203c2: Refactored QmitkMultiLabelInspector to use the highlight guard.
Fri, May 10, 2:19 PM · Request for Discussion, Checklist, MITK (v2024.06)
floca committed rMITK27cad36203c2: Refactored QmitkMultiLabelInspector to use the highlight guard (authored by floca).
Refactored QmitkMultiLabelInspector to use the highlight guard
Fri, May 10, 2:19 PM
floca committed rMITK692addbcd6fe: Rework mapper to support highlight invisible (authored by floca).
Rework mapper to support highlight invisible
Fri, May 10, 2:19 PM
floca committed rMITK57fedf2e5d5d: Introduced the LabelHighlightGuard (authored by floca).
Introduced the LabelHighlightGuard
Fri, May 10, 2:19 PM
kompan triaged T30441: [Perfusion] Baseline range bug for variable flip angle conversion as Normal priority.
Fri, May 10, 10:55 AM · Next Milestone, Checklist, MITK (v2024.06)
floca edited projects for T30412: [Statistics] Planar figure cannot be set as ROI for askew images, added: Next Milestone, MITK, Request for Discussion; removed Missing Info, Checklist, MITK (v2024.06).

We should clarify how we handle the reinit or reinit warning in the Measurement view. Should be very simelar to the Segmentation view.

Fri, May 10, 10:39 AM · MITK, Next Milestone
kislinsk added a revision to T26934: Multiple logos in screenshot when using screenshot maker plugin: Unknown Object (Differential Revision).
Fri, May 10, 10:25 AM · MITK (v2024.06)
kompan triaged T30440: [Perfusion] Error when loading AIF from csv file in DCE MR Perfusion DataFit View as Normal priority.
Fri, May 10, 10:24 AM · Next Milestone, Checklist, MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Pushed new branch to rMITK MITK: bugfix/T26934-FixLogoAnnotation.

Fri, May 10, 10:23 AM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Deleted branch from rMITK MITK: bugfix/T26934-FixHighResScreenshots.

Fri, May 10, 10:18 AM · MITK (v2024.06)
kompan triaged T30439: [Perfusion] Only a selection of debug parameter images generated as sub-nodes as Normal priority.
Fri, May 10, 9:55 AM · Next Milestone, Request for Discussion, Checklist, MITK (v2024.06)
kislinsk added a revision to T26934: Multiple logos in screenshot when using screenshot maker plugin: Restricted Differential Revision.
Fri, May 10, 1:14 AM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Pushed new branch to rMITK MITK: bugfix/T26934-FixHighResScreenshots.

Fri, May 10, 1:08 AM · MITK (v2024.06)
kislinsk edited projects for T26934: Multiple logos in screenshot when using screenshot maker plugin, added: MITK (v2024.06); removed Auto-closed, MITK.
Fri, May 10, 1:06 AM · MITK (v2024.06)