Page MenuHomePhabricator
Feed All Stories

Today

floca added a comment to T27006: [Perfusion] - Problems selecting T1 map.
In T27006#191923, @Sara wrote:

Hi Ralf,
We changed the properties of the data node regarding the T1 map but unsuccessfully.
We always get "Dimension 2 is not in (ItkOutputImageType::ImageDimension)" error.

Just to be sure. The work-arround with the "binary" property (see above) is only for the problem that you weren't able to select the T1 map in the view.
It is not a solution for the Dimension 2 is not in (ItkOutputImageType::ImageDimension) error!

Mon, Jan 20, 11:59 AM · MITK
kalali triaged T27016: Use OpenStack for our CI system as Normal priority.
Mon, Jan 20, 11:43 AM · Restricted Project, CI
Sara added a comment to T27006: [Perfusion] - Problems selecting T1 map.

Hi Ralf,
We changed the properties of the data node regarding the T1 map but unsuccessfully.
We always get "Dimension 2 is not in (ItkOutputImageType::ImageDimension)" error.
We also checked the dimensionality of the T1 map from the Details Menu:

Dimension: 2
Dimensions: 60 200

The simulated DICOM data come from the QIBA dataset.
The T1 map in nifti format was obtained from the Variable Flip Angle simulated data that comes along with the QIBA dataset.
We computed the T1 map using ROCKETSHIP.
Thank you,
Sara and Daisy.

Mon, Jan 20, 11:08 AM · MITK
kislinsk committed rMITKea299c95c72b: Merge branch 'T26976-InstallPythonQtOnMacOs' (authored by kislinsk).
Merge branch 'T26976-InstallPythonQtOnMacOs'
Mon, Jan 20, 11:07 AM
kislinsk committed rMITK339c050c07de: Fix IGNORE_ITEM parameter name (authored by kislinsk).
Fix IGNORE_ITEM parameter name
Mon, Jan 20, 11:06 AM
Sara added a comment to T27006: [Perfusion] - Problems selecting T1 map.
Mon, Jan 20, 11:04 AM · MITK
kislinsk triaged T27010: `make package` takes forever (in particular on macOS) as Normal priority.
Mon, Jan 20, 10:30 AM · MITK
kislinsk closed T24271: Port tests from old mitk test macros to CPPUNIT as Resolved.
Mon, Jan 20, 10:23 AM · MITK
floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

@jsolislemus : Could you provide me your email adresse? Then I will send you the instructions how to transfer data.
Thanks

Mon, Jan 20, 10:04 AM · MITK (2018-04-4)
kahl committed rMITK1221316cb5db: Port mitk tests to CPPUnit (authored by kahl).
Port mitk tests to CPPUnit
Mon, Jan 20, 9:32 AM

Yesterday

floca closed T27006: [Perfusion] - Problems selecting T1 map as Invalid.

The problem was caused by the fact that the T1 map has just 2 different pixel values. Therfore it was automatically classified as binary image /mask on loading.

Sun, Jan 19, 8:36 AM · MITK
floca triaged T27006: [Perfusion] - Problems selecting T1 map as Normal priority.
Sun, Jan 19, 8:30 AM · MITK

Sat, Jan 18

floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

That would be great. Thanks!

Sat, Jan 18, 1:25 PM · MITK (2018-04-4)

Fri, Jan 17

floca claimed T24776: Refactor MatchPoint plugins to use the new node selection widgets.
Fri, Jan 17, 5:47 PM · MITK
floca added a revision to T24660: Add a "selection history" inspector: Unknown Object (Differential Revision).
Fri, Jan 17, 5:44 PM · MITK
aguilera committed rMITKc7d3b905cc41: adapt tests (authored by aguilera).
adapt tests
Fri, Jan 17, 4:54 PM
aguilera committed rMITK04efa9976233: add GetAllRepresentationObjects method (authored by aguilera).
add GetAllRepresentationObjects method
Fri, Jan 17, 4:54 PM
aguilera added a comment to T27003: Extend representation object handling in NavigationDataObjectVisualizationFilter.

Pushed new branch T27003-ExtendRepresentationObjectHandlingInNavigationDataObjectVisualizationFilter.

Fri, Jan 17, 4:54 PM · MITK, Restricted Project
dreherk added a comment to T27005: Domain adaptation of simulation with real PA images.

Pushed new branch T27005-domain_adaptation.

Fri, Jan 17, 4:03 PM · CAMI, Photoacoustics
dreherk created T27005: Domain adaptation of simulation with real PA images.
Fri, Jan 17, 2:45 PM · CAMI, Photoacoustics
kalali closed T26259: QmitkConvertToMultiLabelSegmentationAction only works once as Resolved.

Should work now with the fix of T26938. Please reopen, if this problem persists.

Fri, Jan 17, 12:43 PM · MITK
kalali accepted rMITK99804079e0a8: Add container for Type, LineStyle and Color.
Fri, Jan 17, 12:32 PM
kalali accepted rMITK61caf41dc62c: Add Function for returning index by string.
Fri, Jan 17, 12:32 PM
kalali accepted rMITK39cfb5c5df5e: Remove override.
Fri, Jan 17, 12:31 PM
kalali accepted rMITKcdda996996fd: Add Function to update existing data.
Fri, Jan 17, 12:31 PM
kalali accepted rMITKf98609dac0c1: Modify functions for GUI.
Fri, Jan 17, 12:31 PM
kalali accepted rMITKea1cf2ffd166: Add new function for adding data.
Fri, Jan 17, 12:30 PM
kalali accepted rMITK7aa0559a1250: Add function to update existing data.
Fri, Jan 17, 12:30 PM
kalali accepted rMITK2ef6a51b13de: Add emplace.
Fri, Jan 17, 12:29 PM
kalali accepted rMITK4fe5206d5ca9: Add chartExistance boolean to avoid #T26790.

Still an open issue: T26790

Fri, Jan 17, 12:29 PM
kalali accepted rMITKbe64b0e66a24: Re-add emplace functionality.
Fri, Jan 17, 12:28 PM
kalali accepted rMITK5bdfc4c4048e: Avoid repeated converting.
Fri, Jan 17, 12:27 PM
kalali accepted rMITK726b04a3e631: Refactor AddChartExampleData to avoid converting.
Fri, Jan 17, 12:27 PM
kalali accepted rMITK2bb676acf3f1: Remove unnecessary emplacements.
Fri, Jan 17, 12:26 PM
kalali accepted rMITKb6992664bb45: Remove emplacement for lineType & clarify naming of it.
Fri, Jan 17, 12:26 PM
jsolislemus added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Sorry for the long delay. Thank you for your help.

Fri, Jan 17, 10:36 AM · MITK (2018-04-4)
kahl committed rMITK43a77cff3c23: resolved merge conflicts (authored by kahl).
resolved merge conflicts
Fri, Jan 17, 10:08 AM
kahl added a comment to T24271: Port tests from old mitk test macros to CPPUNIT.

Pushed new branch T24271-port-more-tests-2-integration.

Fri, Jan 17, 10:08 AM · MITK
aguilera created T27003: Extend representation object handling in NavigationDataObjectVisualizationFilter.
Fri, Jan 17, 10:06 AM · MITK, Restricted Project
kislinsk committed rMITK4c24e3cba37d: Merge branch 'T26976-InstallPythonQtOnMacOs' (authored by kislinsk).
Merge branch 'T26976-InstallPythonQtOnMacOs'
Fri, Jan 17, 9:53 AM
kislinsk committed rMITKf02562b637bc: Ignore Python executable in macOS Python.framework (authored by kislinsk).
Ignore Python executable in macOS Python.framework
Fri, Jan 17, 9:52 AM

Thu, Jan 16

k656s added a member for d:cipher: j562r.
Thu, Jan 16, 5:31 PM
kalali added a revision to T27002: Refactor DICOM inspector plugin to use the new node selection widgets: Unknown Object (Differential Revision).
Thu, Jan 16, 4:55 PM · MITK
floca triaged T26239: BlackboxFunction custom parameters in own "bucket" and not in "params" as Normal priority.
Thu, Jan 16, 3:18 PM · Hyppopy
kalali triaged T27002: Refactor DICOM inspector plugin to use the new node selection widgets as Normal priority.
Thu, Jan 16, 3:05 PM · MITK
kalali updated the task description for T26741: Finishing new node selection concept.
Thu, Jan 16, 3:01 PM · Restricted Project
kalali triaged T27001: Rename org.mitk.gui.qt.dicom to org.mitk.gui.qt.dicombrowser as Low priority.
Thu, Jan 16, 2:55 PM · Request for Discussion, MITK
kalali added a comment to T26475: QmitkPropertyTreeView does not react on DICOM node changes.

The topic is about the properties-view tab title. I was just looking into it and thinking if we can remove this functionality completely: We now have the selection widget which shows the currently selected node - no need to write the name of the selected node in the tab title.

Thu, Jan 16, 2:49 PM · Restricted Project, MITK
kislinsk added a reverting change for rMITK343d9f435f57: Discover and fixup all executables before verifying the bundle on macOS: rMITKc6e9a6caff41: Revert "Discover and fixup all executables before verifying the bundle on macOS".
Thu, Jan 16, 2:21 PM
kislinsk committed rMITKc6e9a6caff41: Revert "Discover and fixup all executables before verifying the bundle on macOS" (authored by kislinsk).
Revert "Discover and fixup all executables before verifying the bundle on macOS"
Thu, Jan 16, 2:21 PM
kalali merged task T27000: QmitkAbstractNodeSelectionWidget does not react to node changes into T26851: QmitkNodeSelectionButton does not refresh if node information changes.
Thu, Jan 16, 1:31 PM · MITK
kalali merged T27000: QmitkAbstractNodeSelectionWidget does not react to node changes into T26851: QmitkNodeSelectionButton does not refresh if node information changes.
Thu, Jan 16, 1:31 PM · MITK
floca added a comment to T26998: Refactor Properties plugin to use the new node selection widgets.

@floca: This task does not fix T26475 since the QmitkSingleSlotSelectionWidget does not react to node changes itself (see T27000).

Yes you are right. I was inprecise. I already had T26851 in mind because it is on out to do list.

Thu, Jan 16, 1:28 PM · MITK
kalali triaged T27000: QmitkAbstractNodeSelectionWidget does not react to node changes as Normal priority.
Thu, Jan 16, 1:25 PM · MITK
kalali added a comment to T26998: Refactor Properties plugin to use the new node selection widgets.

This task does not fix T26475 since the QmitkSingleSlotSelectionWidget does not react to node changes itself.

Thu, Jan 16, 1:12 PM · MITK
kislinsk placed T26992: Rendering tests do not run on Windows and macOS up for grabs.
Thu, Jan 16, 12:51 PM · MITK
kislinsk placed T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11) up for grabs.
Thu, Jan 16, 12:51 PM · MITK (2018-04-4), Pull Request
kislinsk placed T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry up for grabs.
Thu, Jan 16, 12:51 PM · Request for Discussion, Restricted Project, MITK (2018-04-4)
kislinsk committed rMITK343d9f435f57: Discover and fixup all executables before verifying the bundle on macOS (authored by kislinsk).
Discover and fixup all executables before verifying the bundle on macOS
Thu, Jan 16, 12:50 PM
kalali closed T24659: Implement "Favorites" inspector, a subtask of T23751: Introduction of new selection concept, as Resolved.
Thu, Jan 16, 11:17 AM · MITK
kalali closed T24659: Implement "Favorites" inspector as Resolved.
Thu, Jan 16, 11:17 AM · MITK
kalali committed rMITKe1268d66cadd: Merge branch 'T24659-Implement-favorites-inspector' (authored by kalali).
Merge branch 'T24659-Implement-favorites-inspector'
Thu, Jan 16, 11:17 AM
kalali committed rMITK78ffa3d3aa42: Simplify logic (authored by kalali).
Simplify logic
Thu, Jan 16, 11:16 AM
kalali accepted rMITKfdfabc089f2d: Enalbe NodeChanged event trigger and pre-check if update is necessary.
Thu, Jan 16, 11:11 AM
kalali added inline comments to rMITKfdfabc089f2d: Enalbe NodeChanged event trigger and pre-check if update is necessary.
Thu, Jan 16, 11:11 AM
kislinsk added a comment to T26976: PythonQt is not installed on macOS when creating an MITK installer.

https://gitlab.kitware.com/cmake/cmake/issues/20165

Thu, Jan 16, 10:53 AM · MITK

Wed, Jan 15

floca added a comment to T26475: QmitkPropertyTreeView does not react on DICOM node changes.

@kalali: If this task is fixed T26475 should be fixed as well, after you introduced the new SelectionWidget to QmitkPropertyTreeView, shouldn't it? Or is it already fixed due to T26381?

Wed, Jan 15, 7:53 PM · Restricted Project, MITK
floca accepted rMITKfdfabc089f2d: Enalbe NodeChanged event trigger and pre-check if update is necessary.

Logic is correct. But I would condense it to remove redundancy (see inline comment).

Wed, Jan 15, 7:48 PM
kalali added 1 auditor(s) for rMITKfdfabc089f2d: Enalbe NodeChanged event trigger and pre-check if update is necessary: floca.
Wed, Jan 15, 6:28 PM
kalali committed rMITKfdfabc089f2d: Enalbe NodeChanged event trigger and pre-check if update is necessary (authored by kalali).
Enalbe NodeChanged event trigger and pre-check if update is necessary
Wed, Jan 15, 6:27 PM
kalali committed rMITK0bb2c01d5b33: Revert changes for updating the view of the inspector manually (authored by kalali).
Revert changes for updating the view of the inspector manually
Wed, Jan 15, 6:27 PM
kalali committed rMITK1f4788e1aec5: Adapt button title to be more precise (authored by kalali).
Adapt button title to be more precise
Wed, Jan 15, 6:27 PM
kalali accepted rMITK13e7f96912aa: Add new inspector for favorite nodes.
Wed, Jan 15, 6:26 PM
kalali added inline comments to rMITK13e7f96912aa: Add new inspector for favorite nodes.
Wed, Jan 15, 6:26 PM
kalali claimed T26998: Refactor Properties plugin to use the new node selection widgets.
Wed, Jan 15, 5:17 PM · MITK
kalali renamed T26998: Refactor Properties plugin to use the new node selection widgets from Refactor Properties plugins to use the new node selection widgets to Refactor Properties plugin to use the new node selection widgets.
Wed, Jan 15, 5:11 PM · MITK
kalali added a revision to T26998: Refactor Properties plugin to use the new node selection widgets: Unknown Object (Differential Revision).
Wed, Jan 15, 5:11 PM · MITK
kalali triaged T26998: Refactor Properties plugin to use the new node selection widgets as Normal priority.
Wed, Jan 15, 5:02 PM · MITK
floca accepted rMITK13e7f96912aa: Add new inspector for favorite nodes.

Discussed it offline.

Wed, Jan 15, 1:45 PM
kalali committed rMITKedcb00699a6f: Merge branch 'T26958-MapToSource-in-level-window-preset-dialog' (authored by kalali).
Merge branch 'T26958-MapToSource-in-level-window-preset-dialog'
Wed, Jan 15, 12:04 PM
kalali committed rMITK713aa629ad7a: Fix T26958 (authored by kalali).
Fix T26958
Wed, Jan 15, 12:04 PM
kalali added a comment to T26958: LevelWindow Preset Dialog does not work correctly.

Pushed new branch T26958-MapToSource-in-level-window-preset-dialog.

Wed, Jan 15, 12:03 PM · MITK (2018-04-4)
kalali closed T26958: LevelWindow Preset Dialog does not work correctly as Resolved by committing rMITK713aa629ad7a: Fix T26958.
Wed, Jan 15, 12:03 PM · MITK (2018-04-4)
kalali updated the task description for T26958: LevelWindow Preset Dialog does not work correctly.
Wed, Jan 15, 11:55 AM · MITK (2018-04-4)
kalali added inline comments to rMITK13e7f96912aa: Add new inspector for favorite nodes.
Wed, Jan 15, 11:48 AM

Tue, Jan 14

floca added inline comments to rMITK13e7f96912aa: Add new inspector for favorite nodes.
Tue, Jan 14, 9:44 PM
floca raised a concern with rMITK13e7f96912aa: Add new inspector for favorite nodes.
Tue, Jan 14, 9:40 PM
kalali added 1 auditor(s) for rMITK13e7f96912aa: Add new inspector for favorite nodes: floca.
Tue, Jan 14, 6:59 PM
kalali added a comment to rMITK13e7f96912aa: Add new inspector for favorite nodes.

Some remarks as written in T24659#191634

Tue, Jan 14, 6:57 PM
kalali added a comment to T24659: Implement "Favorites" inspector.

Everything works now but I'm not 100% convinced that this is the best way to do it. Will add some remarks in a review.

Tue, Jan 14, 6:42 PM · MITK
kalali committed rMITKd4170f5dbca9: Do some code cleaning (authored by kalali).
Do some code cleaning
Tue, Jan 14, 6:41 PM
kalali committed rMITK13e7f96912aa: Add new inspector for favorite nodes (authored by kalali).
Add new inspector for favorite nodes
Tue, Jan 14, 6:41 PM
kalali added a comment to T24659: Implement "Favorites" inspector.

Pushed new branch T24659-Implement-favorites-inspector.

Tue, Jan 14, 6:40 PM · MITK
kalali updated the task description for T24659: Implement "Favorites" inspector.
Tue, Jan 14, 6:34 PM · MITK
kislinsk committed rMITK258838df6a80: Merge branch 'T26992-FixRenderingTestHelper' (authored by kislinsk).
Merge branch 'T26992-FixRenderingTestHelper'
Tue, Jan 14, 4:24 PM
kislinsk committed rMITKf2e9c3aeb49a: Add missing header (macOS) (authored by kislinsk).
Add missing header (macOS)
Tue, Jan 14, 4:23 PM
kislinsk added a comment to T26992: Rendering tests do not run on Windows and macOS.

For now, re-introduce a check for OpenGL support until we found a solution.

Tue, Jan 14, 4:03 PM · MITK
kislinsk committed rMITKe5aeb4ab1fe5: Merge branch 'T26992-FixRenderingTestHelper' (authored by kislinsk).
Merge branch 'T26992-FixRenderingTestHelper'
Tue, Jan 14, 4:01 PM
kislinsk committed rMITKdd8d6da2f746: Reintroduce enhanced OpenGL support test (authored by kislinsk).
Reintroduce enhanced OpenGL support test
Tue, Jan 14, 4:01 PM
kislinsk committed rMITK2c98c94e9afb: Remove dangling declarations (authored by kislinsk).
Remove dangling declarations
Tue, Jan 14, 4:01 PM