Page MenuHomePhabricator
Feed All Stories

Yesterday

nolden updated the task description for T26721: Prepare Qt 5.13 compatibility.
Sat, Oct 19, 9:28 AM · MITK
nolden renamed T26721: Prepare Qt 5.13 compatibility from Fix Qt 5.13 compatibility to Prepare Qt 5.13 compatibility.
Sat, Oct 19, 9:27 AM · MITK

Fri, Oct 18

hettich added a comment to T26721: Prepare Qt 5.13 compatibility.

on MITK master:

Fri, Oct 18, 6:26 PM · MITK
holzwart committed rMITKfbe179b77df6: fixed bugs (authored by holzwart).
fixed bugs
Fri, Oct 18, 3:59 PM
kalali added a comment to T24757: Raw file downloads in CTest scripts don't work anymore with Phabricator URLs.

I just tried to use CTest with a branch. This is not working when I use set(GIT_BRANCH "Txxx"). I assume this is because this makes the script use the raw Phabricator file, which is not working, according to the task name.
However, since branches are not mirrored to GitHub, the proposed solution is not an option for me? Or is this not related?

Fri, Oct 18, 3:36 PM · Restricted Project, MITK
kalali triaged T26754: Review checklists as Low priority.
Fri, Oct 18, 3:21 PM · Restricted Project, MITK
holzwart committed rMITK8e5f9547fda7: move bandpass, new naming convention (authored by holzwart).
move bandpass, new naming convention
Fri, Oct 18, 3:02 PM
kalali updated the task description for T26754: Review checklists.
Fri, Oct 18, 10:43 AM · Restricted Project, MITK

Thu, Oct 17

kislinsk placed T26721: Prepare Qt 5.13 compatibility up for grabs.
Thu, Oct 17, 11:13 AM · MITK
kislinsk added a comment to T26721: Prepare Qt 5.13 compatibility.

Status as of now:

Thu, Oct 17, 11:13 AM · MITK
kislinsk committed rMITKc556e27481e6: Merge branch 'T26721-Qt-5.12' (authored by kislinsk).
Merge branch 'T26721-Qt-5.12'
Thu, Oct 17, 11:09 AM
kislinsk committed rMITK813e0bf26539: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Thu, Oct 17, 11:08 AM
kislinsk committed rMITKe24e19794d8c: Set Qt 5.12 as minimum required version (authored by kislinsk).
Set Qt 5.12 as minimum required version
Thu, Oct 17, 11:05 AM
kislinsk committed rMITK964b9d8b0578: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Thu, Oct 17, 11:05 AM
kislinsk added a comment to T26721: Prepare Qt 5.13 compatibility.

Pushed new branch T26721-Qt-5.12.

Thu, Oct 17, 11:05 AM · MITK
kislinsk committed rMITKc74351aa4e91: Set Qt 5.12 as maximum supported version (authored by kislinsk).
Set Qt 5.12 as maximum supported version
Thu, Oct 17, 10:58 AM
kislinsk added a comment to T26721: Prepare Qt 5.13 compatibility.

For now we should stick with the Qt 5.12 LTS, as long as 5.13 does not work reliably (see Windows issue above). We can add a CMake warning/error for now that does not allow to proceed configuring MITK with Qt > 5.12.

Thu, Oct 17, 10:34 AM · MITK
kislinsk reassigned T26756: Adapt to mitkFunctionCreateBlueBerryApplication changes from kislinsk to neher.
Thu, Oct 17, 10:30 AM · MITK Diffusion
kislinsk triaged T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11) as High priority.
Thu, Oct 17, 9:27 AM · MITK (2018-04-4), Pull Request
kislinsk edited projects for T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11), added: MITK (2018-04-4); removed MITK.
Thu, Oct 17, 9:27 AM · MITK (2018-04-4), Pull Request
kislinsk claimed T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).
Thu, Oct 17, 9:27 AM · MITK (2018-04-4), Pull Request
kislinsk added a project to T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11): Pull Request.
Thu, Oct 17, 9:18 AM · MITK (2018-04-4), Pull Request
kislinsk added a comment to T26756: Adapt to mitkFunctionCreateBlueBerryApplication changes.

Look at your nightlies. This is the fix. You're the only one allowed to merge into the master branch of MITK-Diffusion.

Thu, Oct 17, 9:17 AM · MITK Diffusion
neher added a comment to T26756: Adapt to mitkFunctionCreateBlueBerryApplication changes.

?

Thu, Oct 17, 8:59 AM · MITK Diffusion
neher closed T23702: Screenshot maker always takes screenshot of axial view as Resolved.
Thu, Oct 17, 8:58 AM · MITK

Wed, Oct 16

j762e added a comment to T23702: Screenshot maker always takes screenshot of axial view.

@neher : Is this resolved?

Wed, Oct 16, 2:52 PM · MITK
j762e updated subscribers of T18221: Usuability of Screenshot Maker.

Is this resolved with 4cda20fc6a60? The buttons were removed but do we want to have them with the correct logic (@kislinsk)

Wed, Oct 16, 2:45 PM · Bugzilla, MITK
kislinsk closed T23293: Apply C++ 11 modernizations as Resolved.
Wed, Oct 16, 2:03 PM · MITK
maleike added a comment to T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).

Ok, just created https://github.com/MITK/MITK/pull/240

Wed, Oct 16, 1:56 PM · MITK (2018-04-4), Pull Request
kislinsk committed rMITK029a4ba313e1: Modernize usage of auto keyword with clang-tidy (authored by kislinsk).
Modernize usage of auto keyword with clang-tidy
Wed, Oct 16, 1:54 PM
kislinsk added a comment to T23293: Apply C++ 11 modernizations.
Wed, Oct 16, 1:53 PM · MITK
kislinsk committed rMITK43319a16964c: Merge branch 'T23293-nullptr' (authored by kislinsk).
Merge branch 'T23293-nullptr'
Wed, Oct 16, 1:30 PM
kislinsk committed rMITKe9e22e6f0239: Fix wrong return value types (authored by kislinsk).
Fix wrong return value types
Wed, Oct 16, 1:24 PM
kislinsk committed rMITK0979df62b0ba: Modernize nullptr usage (authored by kislinsk).
Modernize nullptr usage
Wed, Oct 16, 1:24 PM
kislinsk added a comment to T23293: Apply C++ 11 modernizations.

Pushed new branch T23293-nullptr.

Wed, Oct 16, 1:24 PM · MITK
kislinsk committed rMITK3db51a382ace: Merge branch 'T23293-override-Oct2019' (authored by kislinsk).
Merge branch 'T23293-override-Oct2019'
Wed, Oct 16, 1:03 PM
kislinsk committed rMITKe18c70938711: Fix clang-tidy errors regarding multiple override specifiers (authored by kislinsk).
Fix clang-tidy errors regarding multiple override specifiers
Wed, Oct 16, 1:02 PM
kislinsk committed rMITK5d99ddc4d7ed: Merge branch 'T23293-override-Oct2019' (authored by kislinsk).
Merge branch 'T23293-override-Oct2019'
Wed, Oct 16, 12:35 PM
kislinsk committed rMITK4b7a4af81338: Add more override keywords with clang-tidy 9 (authored by kislinsk).
Add more override keywords with clang-tidy 9
Wed, Oct 16, 12:34 PM
kislinsk added a comment to T26756: Adapt to mitkFunctionCreateBlueBerryApplication changes.

@neher, you probably want to merge this. :-)

Wed, Oct 16, 12:31 PM · MITK Diffusion
kislinsk committed rMITKDIFF1f1ae6cd1401: Migrate to latest changes of mitkFunctionCreateBlueBerryApplication (authored by kislinsk).
Migrate to latest changes of mitkFunctionCreateBlueBerryApplication
Wed, Oct 16, 12:29 PM
kislinsk added a comment to T26756: Adapt to mitkFunctionCreateBlueBerryApplication changes.

Pushed new branch T26756-mitkFunctionCreateBlueBerryApplication.

Wed, Oct 16, 12:29 PM · MITK Diffusion
kislinsk created T26756: Adapt to mitkFunctionCreateBlueBerryApplication changes.
Wed, Oct 16, 12:27 PM · MITK Diffusion
kislinsk placed T26702: Support mosaic images up for grabs.
Wed, Oct 16, 12:10 PM · MITK
kislinsk closed T26654: Github pull request 239 (Check filename for invalid characters before saving e.g. "a:b.obj") as Resolved.
Wed, Oct 16, 12:07 PM · MITK (2018-04-4), Pull Request
kislinsk committed rMITK24e0741964b4: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Wed, Oct 16, 12:06 PM
kislinsk committed rMITK6d55c6c4600c: Merge remote-tracking branch 'maleike/check-save-filenames' into releases/2018… (authored by kislinsk).
Merge remote-tracking branch 'maleike/check-save-filenames' into releases/2018…
Wed, Oct 16, 12:02 PM
maleike committed rMITKf435c5354609: Minor cleanup - adapting to review comment by S. Dinkelacker (authored by maleike).
Minor cleanup - adapting to review comment by S. Dinkelacker
Wed, Oct 16, 12:02 PM
maleike committed rMITKa2d2c1fc6629: Check filename for invalid characters before attempting to save. (authored by maleike).
Check filename for invalid characters before attempting to save.
Wed, Oct 16, 12:02 PM

Tue, Oct 15

maleike added a comment to T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).

I tried the idea described above today and it fixes the behavior of my interactor that uses the mouse wheel in a 3D window. With this patch the MITK interactor gets to see the event first and can decide whether or not is is handled.

Tue, Oct 15, 5:47 PM · MITK (2018-04-4), Pull Request
kislinsk committed rMITK1fdbd9088049: Merge branch 'T23293-override-Oct2019' (authored by kislinsk).
Merge branch 'T23293-override-Oct2019'
Tue, Oct 15, 4:55 PM
kislinsk committed rMITK7bc10f124dfd: Fix wrong class name (authored by kislinsk).
Fix wrong class name
Tue, Oct 15, 4:54 PM
kalali committed rMITKd223e7267642: Merge branch 'T26727-Change-stdmultiwidget-dependent-files' into T24215-Remove… (authored by kalali).
Merge branch 'T26727-Change-stdmultiwidget-dependent-files' into T24215-Remove…
Tue, Oct 15, 4:50 PM
kalali committed rMITK2d8d2ca53254: Fix gcc errors (authored by kalali).
Fix gcc errors
Tue, Oct 15, 4:50 PM
kalali committed rMITK83fb64a3377d: Change custom viewer example plugin (authored by kalali).
Change custom viewer example plugin
Tue, Oct 15, 4:49 PM
kalali committed rMITK4db7d018bb9d: Change tutorial step8 (authored by kalali).
Change tutorial step8
Tue, Oct 15, 4:49 PM
kalali updated the task description for T26754: Review checklists.
Tue, Oct 15, 4:46 PM · Restricted Project, MITK
kislinsk committed rMITK9646099b086a: Unleash clang-tidy on MITK (override) (authored by kislinsk).
Unleash clang-tidy on MITK (override)
Tue, Oct 15, 4:41 PM
kislinsk added a comment to T23293: Apply C++ 11 modernizations.

Pushed new branch T23293-override-Oct2019.

Tue, Oct 15, 4:41 PM · MITK
kalali updated subscribers of T26754: Review checklists.
Tue, Oct 15, 4:12 PM · Restricted Project, MITK
kalali created T26754: Review checklists.
Tue, Oct 15, 4:12 PM · Restricted Project, MITK
kislinsk claimed T23293: Apply C++ 11 modernizations.

Revive task.

Tue, Oct 15, 3:59 PM · MITK
kislinsk closed T26752: [macOS] Make Boost libraries use RPATH as Resolved.
Tue, Oct 15, 3:48 PM · MITK
kislinsk committed rMITKf5e3a038d853: Merge branch 'T26752-Boost-RPATH' (authored by kislinsk).
Merge branch 'T26752-Boost-RPATH'
Tue, Oct 15, 3:28 PM
kislinsk committed rMITK6a53c08eddca: Make Boost libraries use RPATH (authored by kislinsk).
Make Boost libraries use RPATH
Tue, Oct 15, 3:27 PM
kislinsk added a comment to T26752: [macOS] Make Boost libraries use RPATH.

Pushed new branch T26752-Boost-RPATH.

Tue, Oct 15, 3:27 PM · MITK
kislinsk triaged T26752: [macOS] Make Boost libraries use RPATH as Normal priority.
Tue, Oct 15, 3:26 PM · MITK
kislinsk closed T26747: Fix AppleClang compile errors as Resolved.
Tue, Oct 15, 3:25 PM · MITK
kislinsk committed rMITKbab67ba4fb38: Merge branch 'T26747-AppleClang-Errors' (authored by kislinsk).
Merge branch 'T26747-AppleClang-Errors'
Tue, Oct 15, 1:51 PM
kislinsk committed rMITKfab06a4b7d5e: Fix AppleClang compile errors (authored by kislinsk).
Fix AppleClang compile errors
Tue, Oct 15, 1:50 PM
kislinsk added a comment to T26747: Fix AppleClang compile errors.

Pushed new branch T26747-AppleClang-Errors.

Tue, Oct 15, 1:50 PM · MITK
kislinsk triaged T26747: Fix AppleClang compile errors as Normal priority.
Tue, Oct 15, 1:41 PM · MITK
kislinsk committed rMITK31c6eb29967b: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Tue, Oct 15, 1:17 PM
kislinsk committed rMITKb7f0edc76daf: Add QCoreApplication class declaration (authored by kislinsk).
Add QCoreApplication class declaration
Tue, Oct 15, 1:17 PM
schererj moved T26339: [INSTALLATION] Add HTTPS-Proxy to docker-config in jip_tools.sh from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Tue, Oct 15, 1:17 PM · Restricted Project
schererj closed T26339: [INSTALLATION] Add HTTPS-Proxy to docker-config in jip_tools.sh as Resolved.
Tue, Oct 15, 1:17 PM · Restricted Project
schererj added a comment to T26339: [INSTALLATION] Add HTTPS-Proxy to docker-config in jip_tools.sh.

Resoved: 85869c185a2e857effc81347f9ec5e4c19c26dfe

Tue, Oct 15, 1:17 PM · Restricted Project
kalali added a comment to T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).

Actually, @hempe informed me that the render window menu is not flickering anymore in the latest stable release (if you mean with flickering: not being able to use the render window until you click inside the render window to set its focus).
I wanted to take a look into the diff this week.

Tue, Oct 15, 1:05 PM · MITK (2018-04-4), Pull Request
kislinsk committed rMITKd24e97f0b901: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Tue, Oct 15, 11:13 AM

Mon, Oct 14

kislinsk updated subscribers of T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).

@hempe @kalali Maybe related to the flickering render window menu issues?

Mon, Oct 14, 10:54 PM · MITK (2018-04-4), Pull Request
maleike created T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).
Mon, Oct 14, 5:28 PM · MITK (2018-04-4), Pull Request
kislinsk added a comment to T26736: Starting second MITK instance fails under GNU/Linux.

That's a strong indicator that your graphics H/W causes trouble with the "modern" OpenGL version that VTK 8.x requires. I'm open for new ideas but I think this is something that is not fixable other than trying newer drivers or more recent H/W. In theory, everything not older than 6-7years should work with OpenGL 3.2, but as it turned out, there's a lot of fake-compatibility in older drivers.

Mon, Oct 14, 1:31 PM · MITK
fvdnabee added a comment to T26736: Starting second MITK instance fails under GNU/Linux.

You can also test an MITK 2016.11 installer as the requirement of a newer OpenGL version was introduced in MITK 2018.04 with VTK 8.x.

Mon, Oct 14, 12:42 PM · MITK
kislinsk added a comment to T26736: Starting second MITK instance fails under GNU/Linux.

I tested with Ubuntu 16.04 in VM and also on a Ubuntu 18.04 host. Nvidia graphics.

Mon, Oct 14, 12:33 PM · MITK
fvdnabee added a comment to T26736: Starting second MITK instance fails under GNU/Linux.

Thank you for your efforts. I completely understand your decision with regards to Ubuntu as the main Linux platform. When I have time I'll try to start MITK from an Ubuntu live CD on this machine and report my findings here. One remark: if the issue in MITK is due to an issue with an upstream version of MITK dependencies (or system libraries), then we might encounter this issue in future versions of Ubuntu.

Mon, Oct 14, 12:02 PM · MITK
kislinsk added a comment to T26736: Starting second MITK instance fails under GNU/Linux.

Works for me on various Ubuntu machines and Windows.

Mon, Oct 14, 11:55 AM · MITK
kislinsk added a comment to T26736: Starting second MITK instance fails under GNU/Linux.

Firstly, thank you very much for the detailed and complete bug report. It really is a pleasure to have all information without asking for every detail.

Mon, Oct 14, 11:39 AM · MITK
kalali updated the task description for T26741: Finishing new node selection concept.
Mon, Oct 14, 10:47 AM · Unknown Object (Project)
kalali added a parent task for T23751: Introduction of new selection concept: T26741: Finishing new node selection concept.
Mon, Oct 14, 10:43 AM · MITK
kalali added a subtask for T26741: Finishing new node selection concept: T23751: Introduction of new selection concept.
Mon, Oct 14, 10:43 AM · Unknown Object (Project)
kalali triaged T26741: Finishing new node selection concept as High priority.
Mon, Oct 14, 10:43 AM · Restricted Project
kislinsk committed rMITK69a8c137cf43: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Mon, Oct 14, 8:57 AM

Fri, Oct 11

koehlerg created T26740: Tensorboard 2.0.
Fri, Oct 11, 5:04 PM · trixi
floca added a comment to T26712: DICOM StructuredReport export for planar figures - right place for the contribution.

@hentsch : Du kannst es erstmal direkt in PlanaFigure reinpacken, auch wenn es eine DCMTK dependency bedeutet. Wir schauen es uns erstmal an und wollen bis dahin den Aufwand gering halten.

Fri, Oct 11, 3:47 PM · Request for Discussion, d:cipher, MITK
nolden added a comment to F1442653: grafik.png.

@hentsch Thanks, is this complete? Could you mail it if it should stay confidential?

Fri, Oct 11, 2:47 PM
hentsch added a comment to T26712: DICOM StructuredReport export for planar figures - right place for the contribution.

@kislinsk Sure. I attached a screenshot of a sample DICOM-SR file:


Basically, it's the following information:

  • Patient data
  • Image data (e.g. pixel spacing, referrence to original DICOM)
  • optional name of Measurement for referrencing
  • Measurements
    • Length of line in mm (source: PlanarLine or open PlanarPolygon)
    • Length of Major and Minor axis in mm (source: PlanarEllipse or PlanarCross)
    • Area in mm² (source: closed PlanarPolygon)
  • Source of measurements with source points
    • POLYLINE or
    • ELLIPSE
Fri, Oct 11, 1:42 PM · Request for Discussion, d:cipher, MITK
kislinsk removed a project from T23742: Implement proof of concept for new segmentation data type: Request for Discussion.

The current status of this task is documented by the Bachelor's thesis of @jungsi.

Fri, Oct 11, 11:34 AM · MITK
kislinsk added a comment to T26712: DICOM StructuredReport export for planar figures - right place for the contribution.

Can you give us more information about what's actually contained in the report?

Fri, Oct 11, 11:32 AM · Request for Discussion, d:cipher, MITK
kislinsk removed a member for MITK: steint.
Fri, Oct 11, 11:28 AM
kislinsk added a member for Mint Medical GmbH: steint.
Fri, Oct 11, 11:28 AM