Thank you so much @aekavur ! It helps a lot to understand the reason finally!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Today
Yesterday
Hi again :)
Sat, May 21
Fri, May 20
I wanted to work on the reproduction, but the GSP-Networkdrives was super slow (kb/s) that I couldn't copy the files to my local machine :/
I'm not sure if this is the reason (T24348: Invalid pointer exception due to invalid QModelIndex in QmitkDataStorageTreeModel) for the decision. I would go the route to deprecate the QmitkDataStorageModel and replace it with the QmitkDataStorageSimpleTreeModel. However, the QmitkDataStorageSimpleTreeModel probably needs to be extended (e.g. dropping, changing hierarchy). Do we already have a task for this / should we tackle this in this release-phase?
I stumbled upon these different tasks because of T26394: [Render window manager] Provide tree view / model, which is related to the mxnMultiWidget.
Thu, May 19
See T16165: Reinit after deletion for a reasoning. Both tasks are justified but maybe we should highlight / utilize the general preference "Call global reinit if node is deleted" more.
My changes related to this task were mainly to clear some classes and remove uncertainty (see T28617: Inconsistent view initialization in rendering manager).
As far as I see it some changes have been made in the subtask T28490: Segmentation plugin: "new" segmentation should not run reinit! and the respective D523: This was mainly concerned with NOT resetting the view / camera using a newly introduced parameter "resetCamera".
In T26399#238874, @kalali wrote:
- move the node-tree-items to their new parents immediately inside the QmitkDataStorageSimpleTreeModel::NodeRemoved, like it is done here: https://phabricator.mitk.org/source/mitk/browse/develop/Modules/QtWidgets/src/QmitkDataStorageTreeModel.cpp$675-684
I quickly tested the second suggestion and I was not able to reproduce the bug anymore.
@floca : Ilooked into this again and found the following:
After a node has been removed, inside QmitkDataStorageSimpleTreeModel::NodeRemoved the function QmitkDataStorageSimpleTreeModel::UpdateModelData is called. Here the data storage pointer is used to retrieve the data node subset of a given node predicate. The returned nodeset still returns 6 nodes in my case, although only 5 should exists, since one node was removed.
The node still exists in the data storage, because the signal for a node being removed (RemoveNodeEvent) is sent before the actual removal of the node from the list of nodes inside StandaloneDataStorage (data member m_SourceNodes)).
The command nnUNet_print_available_pretrained_models calls nnunet.inference.pretrained_models.download_pretrained_model:print_available_pretrained_models.
This method can be expanded to take an extra optional argument eg. --export.
If the arg is provided, a JSON file will be exported to the RESULTS_FOLDER location by default.
Since it's an optional argument, there is no need for a documentation update by Python devs.
Instead of command output string parsing, the plan is to export available models' information and place it in a machine-readable format (eg. JSON) in the RESULTS_FOLDER.
This file can be further read by MITK and shown in GUI.
So, this involves making changes on the Python side, as well, for the dumping of the information in a machine-readable format (eg. JSON) natively.
Deleted branch from rMITK MITK: T26958-MapToSource-in-level-window-preset-dialog.
Deleted branch from rMITK MITK: T27049-Measurement-view-with-single-node-selection-widget.
Deleted branch from rMITK MITK: T27183-Fix-segmentation-view.
Pushed new branch to rMITK MITK: bugfix/T28285-Windows-UTF-8.