Page MenuHomePhabricator
Feed All Stories

Today

monishsinthala updated monishsinthala.
Wed, Aug 4, 2:41 PM
floca added a revision to T28659: DICOM Directory loading mighting fails if other files are in the directory: Unknown Object (Differential Revision).
Wed, Aug 4, 10:24 AM · MITK (v2021.10)
floca added a revision to T28658: Workbench crashes when try to load an empty directory : Unknown Object (Differential Revision).
Wed, Aug 4, 10:24 AM · MITK (v2021.10)
floca added a revision to T28658: Workbench crashes when try to load an empty directory : Restricted Differential Revision.
Wed, Aug 4, 10:21 AM · MITK (v2021.10)
floca added a revision to T28659: DICOM Directory loading mighting fails if other files are in the directory: Restricted Differential Revision.
Wed, Aug 4, 10:21 AM · MITK (v2021.10)
floca triaged T28659: DICOM Directory loading mighting fails if other files are in the directory as Normal priority.
Wed, Aug 4, 10:11 AM · MITK (v2021.10)
floca triaged T28658: Workbench crashes when try to load an empty directory as Unbreak Now! priority.
Wed, Aug 4, 10:05 AM · MITK (v2021.10)
kislinsk added a member for MIC: kochch.
Wed, Aug 4, 9:46 AM
kislinsk closed T28657: Fix Visual Studio 2019 v16.11 warnings as errors as Resolved.
Wed, Aug 4, 6:31 AM · MITK (v2021.10)
kislinsk added a comment to T28657: Fix Visual Studio 2019 v16.11 warnings as errors.

Deleted branch from rMITK MITK: bugfix/T28657-FixMSVCv16.11WarningsAsErrors.

Wed, Aug 4, 6:30 AM · MITK (v2021.10)
kislinsk committed rMITKa393ebd03511: Fix unused return type (authored by kislinsk).
Fix unused return type
Wed, Aug 4, 6:29 AM
kislinsk committed rMITKdc72fd711279: Merge branch 'bugfix/T28657-FixMSVCv16.11WarningsAsErrors' into develop (authored by kislinsk).
Merge branch 'bugfix/T28657-FixMSVCv16.11WarningsAsErrors' into develop
Wed, Aug 4, 6:29 AM
kislinsk added a comment to T28657: Fix Visual Studio 2019 v16.11 warnings as errors.

Pushed new branch to rMITK MITK: bugfix/T28657-FixMSVCv16.11WarningsAsErrors.

Wed, Aug 4, 6:28 AM · MITK (v2021.10)
kislinsk triaged T28657: Fix Visual Studio 2019 v16.11 warnings as errors as High priority.
Wed, Aug 4, 6:24 AM · MITK (v2021.10)

Yesterday

floca added a comment to T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .

that is at least one of the two code locations I assume to make problems. (The other one is when the interpolation results are written back to the segmentation)
For now, I wouldn't try to patch in multi-label support into the interpolation class. Instead I would ensure that only a label image (so an image that just contains the active label) is passed to the interpolation class.
I think that that is the most pragmatic approach to it, procure the current implementation will never work properly when multiple labels are present, due to the assumptions already stated by @kalali.

Tue, Aug 3, 5:16 PM · Request for Discussion, MITK (v2021.10)
k688h committed rKAAPANAc0051709fe3e: Change names of some input parameters where registry name was part of their name (authored by k688h).
Change names of some input parameters where registry name was part of their name
Tue, Aug 3, 5:10 PM
k688h committed rKAAPANA43a98465baf7: Add workaround for git protocol for dkfz proxy (authored by k688h).
Add workaround for git protocol for dkfz proxy
Tue, Aug 3, 4:28 PM
k688h committed rKAAPANA6caf3b952fab: Add http_proxy as argument for ci pipeline script (authored by k688h).
Add http_proxy as argument for ci pipeline script
Tue, Aug 3, 2:26 PM
gaoh added a member for MIC: metzger.
Tue, Aug 3, 1:49 PM
gaoh committed rKAAPANA23b6ffb4ef30: Updated CTP to the current version. (authored by gaoh).
Updated CTP to the current version.
Tue, Aug 3, 1:14 PM
p212r committed rKAAPANA1ceea2c6f769: Fix http_proxy not found error in start_build.py (authored by p212r).
Fix http_proxy not found error in start_build.py
Tue, Aug 3, 11:30 AM
s434n added a revision to T28492: Renderer interaction hangs in PACS mode when using keyboard modifiers: Unknown Object (Differential Revision).
Tue, Aug 3, 10:34 AM · MITK

Mon, Aug 2

kleina added a comment to T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .

That is what I assumed... the labels created by multi-label plugin always contain only two values, if I am not mistaken: 0 and x with x e [1,2,3,...]. One could check for the label values and if there is only two different ones, use these two. This does not include the case when a label was created externally,e.g., by U-Net and contains several values in a single image.

Mon, Aug 2, 4:35 PM · Request for Discussion, MITK (v2021.10)
k688h committed rKAAPANA66f562335d79: Update version number of chromedriver and remove specific version tag for… (authored by k688h).
Update version number of chromedriver and remove specific version tag for…
Mon, Aug 2, 4:31 PM
kalali added a project to T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label : Request for Discussion.
Mon, Aug 2, 4:21 PM · Request for Discussion, MITK (v2021.10)
kalali added a comment to T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .

Ok I think I found something odd:
In mitk::ShapeBasedInterpolationAlgorithm::ComputeDistanceMap there are two lines (92 / 93), where the invert filter input is defined with

invertFilter->SetInput(binaryImage);
invertFilter->SetMaximum(1);
Mon, Aug 2, 4:20 PM · Request for Discussion, MITK (v2021.10)
s434n claimed T28492: Renderer interaction hangs in PACS mode when using keyboard modifiers.

The cause for this problem lies in missing state-transitions of the interaction state-machine. DisplayConfigPACS.xml defines the events based on which the state-machine in DisplayInteraction.xml acts. For modifier-based interactions, a MousePressEvent / MouseReleaseEvent in combination with a modifier-key are responsible to transition into / out of the corresponding state ("move", "zoom", ...). When the modifier-key is released BEFORE releasing the mouse button, the second event is never triggered, causing the state machine to get stuck in that specific state, which blocks most other interactions.

Mon, Aug 2, 1:46 PM · MITK
kleina added a comment to T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .

Tested it on Windows. I can confirm what @kalali said.

Mon, Aug 2, 11:54 AM · Request for Discussion, MITK (v2021.10)
eisenman renamed T27891: [shiny] fix bootstrapping choice in new report from fix bootstrapping choice in new report to [shiny] fix bootstrapping choice in new report.
Mon, Aug 2, 10:39 AM · webChallengeR
eisenman renamed T27839: [shiny] Second report cannot be downloaded from Second report cannot be downloaded to [shiny] Second report cannot be downloaded.
Mon, Aug 2, 10:39 AM · webChallengeR
eisenman renamed T27829: [shiny] Disabling button "Next" when a text field is empty from Disabling button "Next" when a text field is empty to [shiny] Disabling button "Next" when a text field is empty.
Mon, Aug 2, 10:39 AM · webChallengeR
eisenman renamed T27822: [shiny] Type of files can be changed in the file dialog from Type of files can be changed in the file dialog to [shiny] Type of files can be changed in the file dialog.
Mon, Aug 2, 10:39 AM · webChallengeR
eisenman renamed T27821: [shiny] Cookie notification disappears when pressing "Esc" from Cookie notification disappears when pressing "Esc" to [shiny] Cookie notification disappears when pressing "Esc".
Mon, Aug 2, 10:38 AM · webChallengeR
eisenman renamed T27779: [shiny] Clarifications on page "Configure ranking" from Clarifications on page "Configure ranking" to [shiny] Clarifications on page "Configure ranking".
Mon, Aug 2, 10:38 AM · webChallengeR
eisenman renamed T27786: [shiny] Navigation from page "Uncertainty analysis" to "Generate report" without option selected from Navigation from page "Uncertainty analysis" to "Generate report" without option selected to [shiny] Navigation from page "Uncertainty analysis" to "Generate report" without option selected.
Mon, Aug 2, 10:38 AM · webChallengeR
eisenman renamed T27780: [shiny] Links should open in new tabs from Links should open in new tabs to [shiny] Links should open in new tabs.
Mon, Aug 2, 10:38 AM · webChallengeR
eisenman renamed T27788: [shiny] Several blocks for configuration of data structure appear when switching from options "head" and "all" from Several blocks for configuration of data structure appear when switching from options "head" and "all" to [shiny] Several blocks for configuration of data structure appear when switching from options "head" and "all".
Mon, Aug 2, 10:37 AM · webChallengeR
eisenman renamed T27761: [shiny] Prevent generation of report if field "name" is empty from Prevent generation of report if field "name" is empty to [shiny] Prevent generation of report if field "name" is empty.
Mon, Aug 2, 10:37 AM · webChallengeR
eisenman renamed T27757: [shiny] Contradicting instruction on page "Uncertainty analysis" from Contradicting instruction on page "Uncertainty analysis" to [shiny] Contradicting instruction on page "Uncertainty analysis".
Mon, Aug 2, 10:37 AM · webChallengeR
eisenman renamed T27783: [shiny] Typo in waiting pop-up from Typo in waiting pop-up to [shiny] Typo in waiting pop-up.
Mon, Aug 2, 10:37 AM · webChallengeR
eisenman renamed T27764: [shiny] Detect early when insufficient number of columns are loaded from Detect early when insufficient number of columns are loaded to [shiny] Detect early when insufficient number of columns are loaded.
Mon, Aug 2, 10:37 AM · webChallengeR
eisenman renamed T27833: [shiny] Clicks on button "Privacy and data protection policy" replicates text from Clicks on button "Privacy and data protection policy" replicates text to [shiny] Clicks on button "Privacy and data protection policy" replicates text.
Mon, Aug 2, 10:35 AM · webChallengeR
eisenman renamed T27842: [shiny] Error while generating single-task report from Error while generating single-task report to [shiny] Error while generating single-task report.
Mon, Aug 2, 10:35 AM · webChallengeR
eisenman renamed T27765: [shiny] Make sure that column specified for metric values has numeric values from Make sure that column specified for metric values has numeric values to [shiny] Make sure that column specified for metric values has numeric values.
Mon, Aug 2, 10:35 AM · webChallengeR
eisenman renamed T27758: [shiny] Remove "next" button from page "Generate report" from Remove "next" button from page "Generate report" to [shiny] Remove "next" button from page "Generate report".
Mon, Aug 2, 10:35 AM · webChallengeR
eisenman renamed T27766: [shiny] Update workflow figure from Update workflow figure to [shiny] Update workflow figure.
Mon, Aug 2, 10:34 AM · webChallengeR
eisenman renamed T27838: [shiny] Add configuration option to indicate order of metric values from Add configuration option to indicate order of metric values to [shiny] Add configuration option to indicate order of metric values.
Mon, Aug 2, 10:34 AM · webChallengeR
eisenman renamed T27835: [shiny] Change order of ranking configuration from Change order of ranking configuration to [shiny] Change order of ranking configuration.
Mon, Aug 2, 10:33 AM · webChallengeR
eisenman placed T27782: [shiny] Success notification may be hidden up for grabs.
Mon, Aug 2, 10:27 AM · webChallengeR
eisenman renamed T27828: [shiny] Error message when wrong type in text field from Error message when wrong type in text field to [shiny] Error message when wrong type in text field.
Mon, Aug 2, 10:27 AM · webChallengeR
eisenman updated subscribers of T27828: [shiny] Error message when wrong type in text field.
Mon, Aug 2, 10:26 AM · webChallengeR
eisenman renamed T27782: [shiny] Success notification may be hidden from Success notification may be hidden to [shiny] Success notification may be hidden.
Mon, Aug 2, 10:26 AM · webChallengeR
eisenman renamed T27827: [shiny] Disabling button "Next" when checkbox "configure" is checked but nothing has been picked from Disabling button "Next" when checkbox "configure" is checked but nothing has been picked to [shiny] Disabling button "Next" when checkbox "configure" is checked but nothing has been picked.
Mon, Aug 2, 10:25 AM · webChallengeR
eisenman renamed T27889: [shiny] display error notification when trying generating already opened report from display error notification when trying generating already opened report to [shiny] display error notification when trying generating already opened report.
Mon, Aug 2, 10:25 AM · webChallengeR
eisenman renamed T27905: [shiny] Investigate download failure from Investigate download failure to [shiny] Investigate download failure.
Mon, Aug 2, 10:19 AM · webChallengeR
eisenman updated subscribers of T27932: [shiny] Metric value column cannot be selected.
Mon, Aug 2, 10:19 AM · webChallengeR
eisenman renamed T27932: [shiny] Metric value column cannot be selected from Metric value column cannot be selected to [shiny] Metric value column cannot be selected.
Mon, Aug 2, 10:19 AM · webChallengeR
eisenman renamed T27933: [shiny] Bootstrapping is performed even if it was disabled from Bootstrapping is performed even if it was disabled to [shiny] Bootstrapping is performed even if it was disabled.
Mon, Aug 2, 10:18 AM · webChallengeR
eisenman renamed T27942: [shiny] Handle path separator characters in report name from Handle path separator characters in report name to [shiny] Handle path separator characters in report name.
Mon, Aug 2, 10:18 AM · webChallengeR
eisenman moved T27828: [shiny] Error message when wrong type in text field from In Progress to Backlog on the webChallengeR board.
Mon, Aug 2, 10:17 AM · webChallengeR
eisenman moved T27782: [shiny] Success notification may be hidden from In Progress to Backlog on the webChallengeR board.
Mon, Aug 2, 10:17 AM · webChallengeR
eisenman moved T27827: [shiny] Disabling button "Next" when checkbox "configure" is checked but nothing has been picked from In Progress to Backlog on the webChallengeR board.
Mon, Aug 2, 10:16 AM · webChallengeR
eisenman moved T28094: [dash] Develop web app based on Dash from In Progress to Done on the webChallengeR board.
Mon, Aug 2, 10:16 AM · webChallengeR
eisenman updated subscribers of T28094: [dash] Develop web app based on Dash.
Mon, Aug 2, 10:09 AM · webChallengeR
kleina added a comment to T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .

Ah ok, thx. I will try later.

Mon, Aug 2, 9:16 AM · Request for Discussion, MITK (v2021.10)

Sun, Aug 1

kalali added a comment to T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .

Ehm... I cannot do Interpolation in MultiLabelSegmentation I think. Shouldn't there be a drop down?

image.png (431×495 px, 15 KB)

Sun, Aug 1, 9:15 AM · Request for Discussion, MITK (v2021.10)

Sat, Jul 31

m564f committed rKAAPANA1da26c0dfbe5: added Branching-Operator to Kaapana Base Operators and Exp-Dags (authored by m564f).
added Branching-Operator to Kaapana Base Operators and Exp-Dags
Sat, Jul 31, 10:41 AM
m564f committed rKAAPANA060b2c1a521a: cleanup general fed-exp operators (authored by m564f).
cleanup general fed-exp operators
Sat, Jul 31, 10:41 AM
m564f committed rKAAPANAe4b5ff252a2c: entrypoint explaination added (authored by m564f).
entrypoint explaination added
Sat, Jul 31, 10:41 AM
m564f committed rKAAPANA5849890ad5dc: cleanup brats experiment (authored by m564f).
cleanup brats experiment
Sat, Jul 31, 10:41 AM
m564f committed rKAAPANA71f112ebcb3d: renaming trigger-remotes-operator (authored by m564f).
renaming trigger-remotes-operator
Sat, Jul 31, 10:41 AM
m564f committed rKAAPANA05dd9a8226fa: cleanup mnist experiment (authored by m564f).
cleanup mnist experiment
Sat, Jul 31, 10:41 AM

Fri, Jul 30

m564f committed rKAAPANAaab58dac046f: added exemplary federated experiments using pysyft integration (authored by m564f).
added exemplary federated experiments using pysyft integration
Fri, Jul 30, 10:42 PM
m564f committed rKAAPANAeffedd3c756c: cleanup docker image (authored by m564f).
cleanup docker image
Fri, Jul 30, 10:03 PM
m564f committed rKAAPANA54ce50fff219: cleanup PySyft DAG and operators (authored by m564f).
cleanup PySyft DAG and operators
Fri, Jul 30, 10:00 PM
m564f committed rKAAPANAbe6152c1140d: README update (authored by m564f).
README update
Fri, Jul 30, 9:48 PM
m564f committed rKAAPANAf4b3214f037a: README update (authored by m564f).
README update
Fri, Jul 30, 9:47 PM
m564f committed rKAAPANAee61c3357f10: added host-ip to logfile (authored by m564f).
added host-ip to logfile
Fri, Jul 30, 9:47 PM
s669m triaged T28653: website feedbacks - comments from Ralf as Normal priority.
Fri, Jul 30, 5:13 PM · Request for Discussion, Kaapana (internal)
floca added a comment to T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation.

oops, sorry. than I have mixed something up.

Fri, Jul 30, 5:02 PM · MITK (v2021.10)
kleina added a comment to T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .

Ehm... I cannot do Interpolation in MultiLabelSegmentation I think. Shouldn't there be a drop down?

image.png (431×495 px, 15 KB)

Fri, Jul 30, 4:26 PM · Request for Discussion, MITK (v2021.10)
kalali updated subscribers of T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .
Fri, Jul 30, 4:06 PM · Request for Discussion, MITK (v2021.10)
kalali added a comment to T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .

Is this task still valid? If I try what's written in the description (after showing the interpolation widget), nothing happens, not even on the first label.

Fri, Jul 30, 4:05 PM · Request for Discussion, MITK (v2021.10)
k688h committed rKAAPANA2870eb384b29: Uncomment part that pushes charts and containers (authored by k688h).
Uncomment part that pushes charts and containers
Fri, Jul 30, 3:52 PM
kalali updated subscribers of T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation.

@kalali Aren't you already working on that topic? I thought, i just reviewed something in that direction?!?

Fri, Jul 30, 3:31 PM · MITK (v2021.10)
k688h committed rKAAPANA466e53ac3096: Push code to test cronjobs after ci pipeline script successfully running (authored by k688h).
Push code to test cronjobs after ci pipeline script successfully running
Fri, Jul 30, 2:26 PM
k688h committed rKAAPANA8f619f50cb98: Update folder name of build config in build script (authored by k688h).
Update folder name of build config in build script
Fri, Jul 30, 2:26 PM
k688h committed rKAAPANAc56d68bc910f: Add sleep time of 5 mins before UI tests start to let kaapana platform pods get… (authored by k688h).
Add sleep time of 5 mins before UI tests start to let kaapana platform pods get…
Fri, Jul 30, 2:26 PM
k688h committed rKAAPANA41b671e5b620: Change name of folder containing build scripts according to PEP8 Python Style (authored by k688h).
Change name of folder containing build scripts according to PEP8 Python Style
Fri, Jul 30, 2:26 PM
k688h committed rKAAPANA4fb9fddeec55: Change name of build helper scripts inside CI folder to differentiate from… (authored by k688h).
Change name of build helper scripts inside CI folder to differentiate from…
Fri, Jul 30, 2:26 PM
kalali added a comment to T28649: Deprecated classes in ImageExtraction-module are not used.

Ok I don't really understand how to work with the ExtractSliceFilter and how to replace what's currently done inside PlanarFigureMaskGenerator::CalculateMask(). Maybe someone can help and explain the different usages of ExtractSliceFilter and ExtractImageFilter and how to correctly set the desired slice for the slice filter.

Fri, Jul 30, 2:19 PM · MITK (v2021.10)
gaoh committed rKAAPANA46070b517137: fixed operator flag 'delete_input_on_success' (authored by gaoh).
fixed operator flag 'delete_input_on_success'
Fri, Jul 30, 12:36 PM
gaoh committed rKAAPANA9d76233ab253: fixed GetRefSeriesOperator for no modality set. (authored by gaoh).
fixed GetRefSeriesOperator for no modality set.
Fri, Jul 30, 12:01 PM
kalali added a comment to T28649: Deprecated classes in ImageExtraction-module are not used.

I just realized that PlanarFigureMaskGenerator is still using the ExtractImageFilter from this module. Other classes use ExtractSliceFilter (which is the recommended version). So in order to remove the ImageExtraction-module, I will replace the filter inside PlanarFigureMaskGenerator.

Fri, Jul 30, 11:45 AM · MITK (v2021.10)
kalali moved T27713: [Segmentation] Disable "New" button when no image is selected from MITK Meeting to Backlog on the Request for Discussion board.
Fri, Jul 30, 10:25 AM · MITK (v2021.10), Request for Discussion

Thu, Jul 29

schererj committed rKAAPANA5a51e0c37d37: added auto-clean for service-process-incoming-dcm dag (authored by schererj).
added auto-clean for service-process-incoming-dcm dag
Thu, Jul 29, 10:51 PM
schererj committed rKAAPANA8ad9e1b2a48e: bodypart-regession integration + kibana dashboard adjustments + jupyterlab 3.1. (authored by schererj).
bodypart-regession integration + kibana dashboard adjustments + jupyterlab 3.1.
Thu, Jul 29, 10:44 PM
schererj committed rKAAPANA31fc9e539b89: integration complete (authored by schererj).
integration complete
Thu, Jul 29, 10:44 PM
schererj committed rKAAPANA3796a07a439c: add prediction adjustments (authored by schererj).
add prediction adjustments
Thu, Jul 29, 10:44 PM
schererj committed rKAAPANA8b923408e4a2: add prediction adjustments (authored by schererj).
add prediction adjustments
Thu, Jul 29, 10:44 PM