Page MenuHomePhabricator
Feed All Stories

Today

kislinsk committed rMITK5fef4b445b74: Fix macro formatting and add semicolons to macros that confuse Doxygen (authored by kislinsk).
Fix macro formatting and add semicolons to macros that confuse Doxygen
Wed, Jan 22, 4:44 PM
kislinsk committed rMITKf1fd5682d82d: Fix multiple uses of labels (authored by kislinsk).
Fix multiple uses of labels
Wed, Jan 22, 4:44 PM
thomass committed rMITKa60b344b8604: Move miniapp section to different location and reorganize layout (authored by thomass).
Move miniapp section to different location and reorganize layout
Wed, Jan 22, 4:04 PM
thomass committed rMITK5ea3d0a459d0: Rearrange plugin list (authored by thomass).
Rearrange plugin list
Wed, Jan 22, 4:04 PM
kalali updated subscribers of T19124: When selecting more than one measurement, statistics aren't calculated.

The new multi node selection functionality allows to select an image and multiple corresponding masks. However, this will compute the statistics for each mask individually.
From the description it is not clear what is requested here:

  1. compute the unified statistics of both masks
  2. compute two individual statistics, one for each mask respectively
Wed, Jan 22, 4:01 PM · Bugzilla, MITK
kislinsk committed rMITK2fa6854b3558: Create directory for Doxygen to parse (authored by kislinsk).
Create directory for Doxygen to parse
Wed, Jan 22, 1:41 PM
kislinsk committed rMITK2c554de6729c: Quote more paths (authored by kislinsk).
Quote more paths
Wed, Jan 22, 1:41 PM
floca committed rMITK9eb9830a1a13: Fixed T24660 (authored by floca).
Fixed T24660
Wed, Jan 22, 1:38 PM
floca committed rMITKfacc3e630dc0: Merge remote-tracking branch 'origin/master' into T24660… (authored by floca).
Merge remote-tracking branch 'origin/master' into T24660…
Wed, Jan 22, 1:38 PM
kislinsk committed rMITKadbda9da00dc: Quote dot path (authored by kislinsk).
Quote dot path
Wed, Jan 22, 1:18 PM
kislinsk committed rMITK412a05f776a2: Remove deprecated config variables (authored by kislinsk).
Remove deprecated config variables
Wed, Jan 22, 1:18 PM
kislinsk committed rMITK799989e5a216: Make developer warnings less intrusive (authored by kislinsk).
Make developer warnings less intrusive
Wed, Jan 22, 1:18 PM
kislinsk added a comment to T27025: Fix documentation warnings.

Pushed new branch T27025-FixDocumentationWarnings.

Wed, Jan 22, 1:17 PM · MITK
kislinsk triaged T27025: Fix documentation warnings as Normal priority.
Wed, Jan 22, 11:45 AM · MITK
kislinsk closed T26977: Fix Nightly warnings as Resolved.
Wed, Jan 22, 11:34 AM · MITK
kislinsk added a comment to T26977: Fix Nightly warnings.

Too meta, fixed a few warnings, though.

Wed, Jan 22, 11:34 AM · MITK
kislinsk committed rMITK9c096725e520: Merge branch 'T26977-FixWarnings' (authored by kislinsk).
Merge branch 'T26977-FixWarnings'
Wed, Jan 22, 11:33 AM
kislinsk closed T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients as Resolved.
Wed, Jan 22, 11:32 AM · MITK
kislinsk closed T26976: PythonQt is not installed on macOS when creating an MITK installer, a subtask of T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients, as Resolved.
Wed, Jan 22, 11:31 AM · MITK
kislinsk closed T26976: PythonQt is not installed on macOS when creating an MITK installer as Resolved.
Wed, Jan 22, 11:31 AM · MITK
kislinsk committed rMITK5f183c6b9c54: Merge branch 'T27024-FixSpectralUnmixingTest' (authored by kislinsk).
Merge branch 'T27024-FixSpectralUnmixingTest'
Wed, Jan 22, 10:23 AM
kislinsk committed rMITKe315ea04a30a: Disable randomly failing test (authored by kislinsk).
Disable randomly failing test
Wed, Jan 22, 10:22 AM
kislinsk added a comment to T27024: Fix PhotoacousticsLib mitkSpectralUnmixingTest.

Pushed new branch T27024-FixSpectralUnmixingTest.

Wed, Jan 22, 10:22 AM · MITK
kislinsk triaged T27024: Fix PhotoacousticsLib mitkSpectralUnmixingTest as Normal priority.
Wed, Jan 22, 10:18 AM · MITK
kislinsk added a comment to T27022: CTest returns error code if subproject does not have tests.

Here's my CMake merge request: https://gitlab.kitware.com/cmake/cmake/merge_requests/4258

Wed, Jan 22, 9:17 AM · CI, MITK
kislinsk added a comment to T27022: CTest returns error code if subproject does not have tests.

In CMake, Source/CTest/cmCTestTestHandler.cxx, cmCTestTestHandler::ProcessHandler(), there is a check if the sum of passed and failed tests equal zero. After another pre-check (see below), "No tests were found!!!" is logged as ERROR_MESSAGE. In Source/cmCTest.cxx, cmCTest::Log(), cmSystemTools::SetErrorOccured() is called if the log type is ERROR_MESSAGE.

Wed, Jan 22, 6:11 AM · CI, MITK
kislinsk renamed T27022: CTest returns error code if subproject does not have tests from Remove Subprojects without tests to CTest returns error code if subproject does not have tests.
Wed, Jan 22, 5:50 AM · CI, MITK

Yesterday

kislinsk added a comment to T27022: CTest returns error code if subproject does not have tests.

Reverted the removal as CTest still fails, probably because of no tests in superbuild projects. I think the best way to solve this is to contribute to CMake.

Tue, Jan 21, 4:53 PM · CI, MITK
kislinsk committed rMITK12ad79a30e7a: Merge branch 'T27022-RemoveUnusedSubprojects' (authored by kislinsk).
Merge branch 'T27022-RemoveUnusedSubprojects'
Tue, Jan 21, 4:52 PM
kislinsk added a reverting change for rMITK2666aaa01fbe: Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject: rMITKc7ccaf77b3e4: Revert "Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject".
Tue, Jan 21, 4:52 PM
kislinsk committed rMITKc7ccaf77b3e4: Revert "Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject" (authored by kislinsk).
Revert "Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject"
Tue, Jan 21, 4:52 PM
kislinsk committed rMITKc9744b3934d8: Merge branch 'T27022-RemoveUnusedSubprojects' (authored by kislinsk).
Merge branch 'T27022-RemoveUnusedSubprojects'
Tue, Jan 21, 4:23 PM
kislinsk committed rMITK2666aaa01fbe: Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject (authored by kislinsk).
Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject
Tue, Jan 21, 4:20 PM
kislinsk added a comment to T27022: CTest returns error code if subproject does not have tests.

Pushed new branch T27022-RemoveUnusedSubprojects.

Tue, Jan 21, 4:20 PM · CI, MITK
kislinsk triaged T27022: CTest returns error code if subproject does not have tests as Normal priority.
Tue, Jan 21, 4:18 PM · CI, MITK
kalali added a project to T27019: Do not disable rendering tests on Linux by default: CI.
Tue, Jan 21, 3:43 PM · CI, Noteworthy, MITK
kislinsk updated subscribers of T27019: Do not disable rendering tests on Linux by default.
Tue, Jan 21, 3:42 PM · CI, Noteworthy, MITK
kislinsk closed T27019: Do not disable rendering tests on Linux by default as Resolved.
Tue, Jan 21, 3:42 PM · CI, Noteworthy, MITK
kislinsk added a project to T27019: Do not disable rendering tests on Linux by default: Noteworthy.

I have introduced a new superbuild and MITK-build advanced cache variable called MITK_XVFB_TESTING. If switched on, it will prepend testdriver calls with xvfb-run --auto-servernum resulting in having a virtual frame buffer available for rendering tests. This is useful in headless systems like continuous integration clients. Works for Linux. To install xvfb call sudo apt install xvfb.

Tue, Jan 21, 3:42 PM · CI, Noteworthy, MITK
kislinsk committed rMITK3e7b326f3900: Merge branch 'T27019-RenderingTestsOnLinux' (authored by kislinsk).
Merge branch 'T27019-RenderingTestsOnLinux'
Tue, Jan 21, 3:00 PM
floca committed rMITK93827c374c6b: Fixed review remarks. (authored by floca).
Fixed review remarks.
Tue, Jan 21, 2:50 PM
floca committed rMITK48cfba96c089: Fixed T24660 (authored by floca).
Fixed T24660
Tue, Jan 21, 2:50 PM
floca closed T24660: Add a "selection history" inspector as Resolved by committing rMITK48cfba96c089: Fixed T24660.
Tue, Jan 21, 2:49 PM · MITK
floca closed T24660: Add a "selection history" inspector, a subtask of T23751: Introduction of new selection concept, as Resolved.
Tue, Jan 21, 2:49 PM · MITK
floca added a comment to T24660: Add a "selection history" inspector.

Pushed new branch T24660-selection_history_inspector.

Tue, Jan 21, 2:49 PM · MITK
kislinsk committed rMITK837dbe368af2: Fix if-condition (authored by kislinsk).
Fix if-condition
Tue, Jan 21, 2:28 PM
mpkh closed T27021: mitk.org is down? as Resolved.

seems fixed

Tue, Jan 21, 2:06 PM · MITK
kislinsk committed rMITK0797e9c5fe24: Fix test declarations (authored by kislinsk).
Fix test declarations
Tue, Jan 21, 2:00 PM
kislinsk committed rMITKd09bb9dd863a: Add MITK_XVFB_TESTING option (authored by kislinsk).
Add MITK_XVFB_TESTING option
Tue, Jan 21, 1:59 PM
mpkh triaged T27021: mitk.org is down? as Unbreak Now! priority.
Tue, Jan 21, 12:17 PM · MITK
kislinsk committed rMITKda2f2e9b318e: Merge branch 'T27019-RenderingTestsOnLinux' (authored by kislinsk).
Merge branch 'T27019-RenderingTestsOnLinux'
Tue, Jan 21, 9:48 AM
kislinsk committed rMITK9e655013a885: Remove MITK_ENABLE_RENDERING_TESTING completely (authored by kislinsk).
Remove MITK_ENABLE_RENDERING_TESTING completely
Tue, Jan 21, 9:47 AM

Mon, Jan 20

thomass committed rMITK83657a10cd35: Merge branch 'T26840-MitkHomepageReorganization-TopLevel' of ssh://phabricator. (authored by thomass).
Merge branch 'T26840-MitkHomepageReorganization-TopLevel' of ssh://phabricator.
Mon, Jan 20, 7:22 PM
thomass committed rMITK26a23e607635: Reorganize Workbench page and plugin list wip (authored by thomass).
Reorganize Workbench page and plugin list wip
Mon, Jan 20, 7:22 PM
thomass added a reverting change for rMITK580b376a4cb5: fixed docu typos mentioned in T26841: rMITK80ba8f5e8497: Revert "fixed docu typos mentioned in T26841".
Mon, Jan 20, 7:22 PM
thomass committed rMITK80ba8f5e8497: Revert "fixed docu typos mentioned in T26841" (authored by thomass).
Revert "fixed docu typos mentioned in T26841"
Mon, Jan 20, 7:22 PM
thomass committed rMITK580b376a4cb5: fixed docu typos mentioned in T26841 (authored by thomass).
fixed docu typos mentioned in T26841
Mon, Jan 20, 7:22 PM
kalali committed rMITK6aa36ba9511c: Merge branch 'T26475-Remove-node-change-reaction' (authored by kalali).
Merge branch 'T26475-Remove-node-change-reaction'
Mon, Jan 20, 5:33 PM
kalali closed T26475: QmitkPropertyTreeView does not react on DICOM node changes as Resolved.
Mon, Jan 20, 5:33 PM · Restricted Project, MITK
kalali committed rMITK18039d0020ae: Remove name-property-observer to not react on name changes (authored by kalali).
Remove name-property-observer to not react on name changes
Mon, Jan 20, 5:31 PM
kalali added a comment to T26475: QmitkPropertyTreeView does not react on DICOM node changes.

Pushed new branch T26475-Remove-node-change-reaction.

Mon, Jan 20, 5:31 PM · Restricted Project, MITK
kalali closed T26998: Refactor Properties plugin to use the new node selection widgets as Resolved.
Mon, Jan 20, 3:48 PM · MITK
kalali closed T26998: Refactor Properties plugin to use the new node selection widgets, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Mon, Jan 20, 3:48 PM · MITK
kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Mon, Jan 20, 3:48 PM · MITK
kalali committed rMITK86585d5917c7: Merge branch 'T26998-Properties-view-with-single-node-selection-widget' (authored by kalali).
Merge branch 'T26998-Properties-view-with-single-node-selection-widget'
Mon, Jan 20, 3:46 PM
kalali committed rMITK4ec12cda7899: Merge branch 'T27002-DICOM-inspector-view-with-single-node-selection-widget' (authored by kalali).
Merge branch 'T27002-DICOM-inspector-view-with-single-node-selection-widget'
Mon, Jan 20, 3:45 PM
kalali committed rMITK3f8115606192: Modernize and clean class (authored by kalali).
Modernize and clean class
Mon, Jan 20, 3:42 PM
kalali committed rMITKb82bf8b5268b: Fix gcc warning-as-error by using a different function name (authored by kalali).
Fix gcc warning-as-error by using a different function name
Mon, Jan 20, 3:42 PM
kalali committed rMITKbef7e116d21d: Add a single node selection widget (authored by kalali).
Add a single node selection widget
Mon, Jan 20, 3:42 PM
kalali added a comment to T26998: Refactor Properties plugin to use the new node selection widgets.

Pushed new branch T26998-Properties-view-with-single-node-selection-widget.

Mon, Jan 20, 3:41 PM · MITK
kislinsk committed rMITK250366539f2f: Merge branch 'T27019-RenderingTestsOnLinux' (authored by kislinsk).
Merge branch 'T27019-RenderingTestsOnLinux'
Mon, Jan 20, 2:46 PM
kislinsk committed rMITK2e3e8f907d47: Enable rendering tests on Linux by default (authored by kislinsk).
Enable rendering tests on Linux by default
Mon, Jan 20, 2:28 PM
kislinsk added a comment to T27019: Do not disable rendering tests on Linux by default.

Pushed new branch T27019-RenderingTestsOnLinux.

Mon, Jan 20, 2:28 PM · CI, Noteworthy, MITK
jsolislemus added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Hello, my email is

Mon, Jan 20, 2:23 PM · MITK (2018-04-4)
kislinsk triaged T27019: Do not disable rendering tests on Linux by default as Normal priority.
Mon, Jan 20, 2:22 PM · CI, Noteworthy, MITK
kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Mon, Jan 20, 2:14 PM · MITK
kalali closed T27002: Refactor DICOM inspector plugin to use the new node selection widgets as Resolved.
Mon, Jan 20, 2:14 PM · MITK
kalali closed T27002: Refactor DICOM inspector plugin to use the new node selection widgets, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Mon, Jan 20, 2:14 PM · MITK
kalali committed rMITK94adc0ebd8e8: Add suggestions from D226 (authored by kalali).
Add suggestions from D226
Mon, Jan 20, 2:13 PM
kalali committed rMITKe9a988a5cb42: Modernize and clean class (authored by kalali).
Modernize and clean class
Mon, Jan 20, 2:13 PM
kalali committed rMITKe2b214a0eb5d: Add a single node selection widget (authored by kalali).
Add a single node selection widget
Mon, Jan 20, 2:13 PM
kalali added a comment to T27002: Refactor DICOM inspector plugin to use the new node selection widgets.

Pushed new branch T27002-DICOM-inspector-view-with-single-node-selection-widget.

Mon, Jan 20, 2:13 PM · MITK
eisenman committed rMITK4144766e079e: Fix error in method call (authored by eisenman).
Fix error in method call
Mon, Jan 20, 2:06 PM
eisenman committed rMITKf34b85a421f4: Fix error caused by signed and unsigned integer comparison (authored by eisenman).
Fix error caused by signed and unsigned integer comparison
Mon, Jan 20, 2:06 PM
eisenman committed rMITK204dcf53fd47: Remove duplicate typedef (authored by eisenman).
Remove duplicate typedef
Mon, Jan 20, 2:05 PM
Sara added a comment to T27006: [Perfusion] - Problems selecting T1 map.

Hi Ralf,
to make it clear, for the Signal to Concentration Conversion via the T1 map, MITK required the T1 map but in the drop down menu we could only select the DCE DICOM images.
We tried to fix the problem in two ways:

  • Editing the T1 map to have more than two values otherwise MITK would recognized it as a mask.
  • Uncecking binary property of the data node for the T1 map.

In the first case, we are able to select the T1 map in the drop menu, but we get the Dimension 2 is not in (ItkOutputImageType::ImageDimension) error.
In the secon case, we are still not able to select the T1 map in the drop menu.

Mon, Jan 20, 12:49 PM · MITK
floca added a comment to T27006: [Perfusion] - Problems selecting T1 map.
In T27006#191923, @Sara wrote:

Hi Ralf,
We changed the properties of the data node regarding the T1 map but unsuccessfully.
We always get "Dimension 2 is not in (ItkOutputImageType::ImageDimension)" error.

Just to be sure. The work-arround with the "binary" property (see above) is only for the problem that you weren't able to select the T1 map in the view.
It is not a solution for the Dimension 2 is not in (ItkOutputImageType::ImageDimension) error!

Mon, Jan 20, 11:59 AM · MITK
kalali triaged T27016: Use OpenStack for our CI system as Normal priority.
Mon, Jan 20, 11:43 AM · Restricted Project, CI
Sara added a comment to T27006: [Perfusion] - Problems selecting T1 map.

Hi Ralf,
We changed the properties of the data node regarding the T1 map but unsuccessfully.
We always get "Dimension 2 is not in (ItkOutputImageType::ImageDimension)" error.
We also checked the dimensionality of the T1 map from the Details Menu:

Dimension: 2
Dimensions: 60 200

The simulated DICOM data come from the QIBA dataset.
The T1 map in nifti format was obtained from the Variable Flip Angle simulated data that comes along with the QIBA dataset.
We computed the T1 map using ROCKETSHIP.
Thank you,
Sara and Daisy.

Mon, Jan 20, 11:08 AM · MITK
kislinsk committed rMITKea299c95c72b: Merge branch 'T26976-InstallPythonQtOnMacOs' (authored by kislinsk).
Merge branch 'T26976-InstallPythonQtOnMacOs'
Mon, Jan 20, 11:07 AM
kislinsk committed rMITK339c050c07de: Fix IGNORE_ITEM parameter name (authored by kislinsk).
Fix IGNORE_ITEM parameter name
Mon, Jan 20, 11:06 AM
Sara added a comment to T27006: [Perfusion] - Problems selecting T1 map.
Mon, Jan 20, 11:04 AM · MITK
kislinsk triaged T27010: `make package` takes forever (in particular on macOS) as Normal priority.
Mon, Jan 20, 10:30 AM · MITK
kislinsk closed T24271: Port tests from old mitk test macros to CPPUNIT as Resolved.
Mon, Jan 20, 10:23 AM · MITK
floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

@jsolislemus : Could you provide me your email adresse? Then I will send you the instructions how to transfer data.
Thanks

Mon, Jan 20, 10:04 AM · MITK (2018-04-4)
kahl committed rMITK1221316cb5db: Port mitk tests to CPPUnit (authored by kahl).
Port mitk tests to CPPUnit
Mon, Jan 20, 9:32 AM

Sun, Jan 19

floca closed T27006: [Perfusion] - Problems selecting T1 map as Invalid.

The problem was caused by the fact that the T1 map has just 2 different pixel values. Therfore it was automatically classified as binary image /mask on loading.

Sun, Jan 19, 8:36 AM · MITK
floca triaged T27006: [Perfusion] - Problems selecting T1 map as Normal priority.
Sun, Jan 19, 8:30 AM · MITK

Sat, Jan 18

floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

That would be great. Thanks!

Sat, Jan 18, 1:25 PM · MITK (2018-04-4)

Fri, Jan 17

floca claimed T24776: Refactor MatchPoint plugins to use the new node selection widgets.
Fri, Jan 17, 5:47 PM · MITK