Page MenuHomePhabricator
Feed Advanced Search

Mar 28 2019

hentsch committed rRTTB6fa9c0e317a3: added warning if ITK 5 is used and RTTB_ITK5_SUPPORT is not checked (authored by hentsch).
added warning if ITK 5 is used and RTTB_ITK5_SUPPORT is not checked
Mar 28 2019, 2:19 PM
hentsch committed rRTTB405e020cf567: added option for ITK 5 (authored by hentsch).
added option for ITK 5
Mar 28 2019, 2:19 PM
hentsch committed rRTTB605ca65fa179: adapted readme (authored by hentsch).
adapted readme
Mar 28 2019, 2:19 PM
hentsch committed rMITK7a9959da72bc: Merge branch 'T26205-emptyStatisticsContainerImageStatisticsModel' (authored by hentsch).
Merge branch 'T26205-emptyStatisticsContainerImageStatisticsModel'
Mar 28 2019, 11:02 AM
hentsch closed T26205: VIsualizing empty statistics container leads to crash in QmitkImageStatisticsTableModel as Resolved by committing rMITKa1c6fb698339: resolved T26205.
Mar 28 2019, 11:02 AM · MITK
hentsch committed rMITKa1c6fb698339: resolved T26205 (authored by hentsch).
resolved T26205
Mar 28 2019, 10:57 AM
hentsch added a comment to T26205: VIsualizing empty statistics container leads to crash in QmitkImageStatisticsTableModel.

Pushed new branch T26205-emptyStatisticsContainerImageStatisticsModel.

Mar 28 2019, 10:57 AM · MITK
hentsch claimed T26205: VIsualizing empty statistics container leads to crash in QmitkImageStatisticsTableModel.
Mar 28 2019, 10:47 AM · MITK
hentsch committed rMITK0dea07a6e5cc: Merge branch 'master' of https://phabricator.mitk.org/source/mitk (authored by hentsch).
Merge branch 'master' of https://phabricator.mitk.org/source/mitk
Mar 28 2019, 10:23 AM
hentsch committed rMITK6cf3217eed2f: Merge branch 'T26169-minimizeModuleDependencies' (authored by hentsch).
Merge branch 'T26169-minimizeModuleDependencies'
Mar 28 2019, 10:23 AM
hentsch closed T26169: Minimize Module dependencies as Resolved.
Mar 28 2019, 10:23 AM · MITK
hentsch committed rMITK599eddce21b6: Removed unneeded dependencies (authored by hentsch).
Removed unneeded dependencies
Mar 28 2019, 8:07 AM
hentsch added a comment to T26169: Minimize Module dependencies.

Pushed new branch T26169-minimizeModuleDependencies.

Mar 28 2019, 8:06 AM · MITK

Mar 27 2019

hentsch triaged T26205: VIsualizing empty statistics container leads to crash in QmitkImageStatisticsTableModel as Normal priority.
Mar 27 2019, 1:29 PM · MITK
hentsch triaged T26190: Enable double-click in Qmitk*NodeSelectionWidget as Wishlist priority.
Mar 27 2019, 9:34 AM · MITK
hentsch triaged T26188: Don't use itk smart pointer for input in ImageStatisticsCalculator as High priority.
Mar 27 2019, 9:31 AM · MITK
hentsch created T26188: Don't use itk smart pointer for input in ImageStatisticsCalculator.
Mar 27 2019, 9:30 AM · MITK

Mar 21 2019

hentsch claimed T26169: Minimize Module dependencies.
Mar 21 2019, 10:04 AM · MITK
hentsch triaged T26169: Minimize Module dependencies as Low priority.
Mar 21 2019, 9:43 AM · MITK

Mar 20 2019

hentsch committed rMITK81f5a00cf57b: Merge branch 'master' of https://phabricator.mitk.org/source/mitk (authored by hentsch).
Merge branch 'master' of https://phabricator.mitk.org/source/mitk
Mar 20 2019, 3:38 PM
hentsch committed rMITK2ded9205bb6e: Merge branch 'T23104-deprecateQmitkPlotWidget' (authored by hentsch).
Merge branch 'T23104-deprecateQmitkPlotWidget'
Mar 20 2019, 3:38 PM
hentsch committed rMITKe03c4d889e54: Merge branch 'T23104-deprecateQmitkPlotWidget' (authored by hentsch).
Merge branch 'T23104-deprecateQmitkPlotWidget'
Mar 20 2019, 3:38 PM
hentsch committed rMITKe4a23497042a: Merge branch 'master' of https://phabricator.mitk.org/source/mitk (authored by hentsch).
Merge branch 'master' of https://phabricator.mitk.org/source/mitk
Mar 20 2019, 3:38 PM
hentsch committed rMITKf127e8e17e8a: Merge remote-tracking branch 'origin/T23104-deprecateQmitkPlotWidget' (authored by hentsch).
Merge remote-tracking branch 'origin/T23104-deprecateQmitkPlotWidget'
Mar 20 2019, 3:38 PM
hentsch committed rMITKd8f5e35d30c7: no deprecation of QmitkPlotWidget until all uses are replaced (authored by hentsch).
no deprecation of QmitkPlotWidget until all uses are replaced
Mar 20 2019, 2:55 PM
hentsch committed rMITK5175b0b3cae1: don't deprecate class, just one function (authored by hentsch).
don't deprecate class, just one function
Mar 20 2019, 2:03 PM
hentsch committed rMITK41d4d391ebe9: Merge branch 'T23191-4DIntensityProfile' (authored by hentsch).
Merge branch 'T23191-4DIntensityProfile'
Mar 20 2019, 1:52 PM
hentsch committed rMITKd8bca35f6006: resolved GCC warning (authored by hentsch).
resolved GCC warning
Mar 20 2019, 1:50 PM
hentsch added a comment to T23104: Deprecate QmitkPlotWidget.

first, we have to migrate the existing plots to MitkChart (T23385, T23386, T25832), then we can set the whole class deprecated

Mar 20 2019, 1:40 PM · Restricted Project, MITK

Mar 19 2019

hentsch closed T26071: Title option into global options as Resolved.
Mar 19 2019, 2:38 PM · Restricted Project, MITK
hentsch closed T26071: Title option into global options, a subtask of T23104: Deprecate QmitkPlotWidget, as Resolved.
Mar 19 2019, 2:38 PM · Restricted Project, MITK
hentsch merged Restricted Maniphest Task into T25833: Leak/Debugbreak when closing workbench related to MitkChart.
Mar 19 2019, 2:34 PM · Restricted Project, MITK
hentsch closed T26072: Color doesn´t work on anything but Line as Resolved.
Mar 19 2019, 2:33 PM · Restricted Project, MITK
hentsch closed T26072: Color doesn´t work on anything but Line, a subtask of T23104: Deprecate QmitkPlotWidget, as Resolved.
Mar 19 2019, 2:33 PM · Restricted Project, MITK
hentsch removed a project from T26080: [QmitkImageStatisticsTableModel] Multiple masks instead multiple timesteps: Restricted Project.
Mar 19 2019, 2:28 PM · MITK
hentsch committed rMITK0017d88a79f5: Merge branch 'T24388-HistogramWithCustomMaxMinValues' (authored by hentsch).
Merge branch 'T24388-HistogramWithCustomMaxMinValues'
Mar 19 2019, 2:18 PM
hentsch committed rMITKb12a4e1a18bd: Setting min/max values directly on start (authored by hentsch).
Setting min/max values directly on start
Mar 19 2019, 2:17 PM
hentsch committed rMITK3c61b4a0ac89: Renamed function to clarify that x axis is meant (authored by hentsch).
Renamed function to clarify that x axis is meant
Mar 19 2019, 2:17 PM
hentsch committed rMITK8c48c4d709ec: Added documentation (authored by hentsch).
Added documentation
Mar 19 2019, 2:17 PM
hentsch committed rMITKae8da3bd4b42: Added comment about automatic y-axis zoom (that's not yet implemented in plotly. (authored by hentsch).
Added comment about automatic y-axis zoom (that's not yet implemented in plotly.
Mar 19 2019, 2:17 PM
hentsch committed rMITK7638b386adf2: Change default to tab "Options" (authored by hentsch).
Change default to tab "Options"
Mar 19 2019, 2:17 PM
hentsch closed T23191: Image Statistics plugin: 4D data + intensity profile does not work as Resolved by committing rMITK9247f6b10d5e: resolved T23191: 4D image is splitted in 3D and then intensity is calculated.
Mar 19 2019, 12:05 PM · MITK
hentsch committed rMITK0ae9731b9191: Merge branch 'T23191-4DIntensityProfile' (authored by hentsch).
Merge branch 'T23191-4DIntensityProfile'
Mar 19 2019, 12:05 PM
hentsch committed rMITK0653d65ca726: removed unused variable (authored by hentsch).
removed unused variable
Mar 19 2019, 11:53 AM
hentsch committed rMITK44fb62fa89f8: renamed variable (authored by hentsch).
renamed variable
Mar 19 2019, 11:53 AM
hentsch committed rMITK13599b4990f2: Don't show legend in histogram and intensity profile (authored by hentsch).
Don't show legend in histogram and intensity profile
Mar 19 2019, 11:53 AM
hentsch committed rMITK19d20f287ed0: removed unused label (authored by hentsch).
removed unused label
Mar 19 2019, 11:53 AM
hentsch committed rMITK9247f6b10d5e: resolved T23191: 4D image is splitted in 3D and then intensity is calculated (authored by hentsch).
resolved T23191: 4D image is splitted in 3D and then intensity is calculated
Mar 19 2019, 11:53 AM
hentsch committed rMITK8af889efd2ad: IntensityProfile should throw exception if image is 4D and can't be processed (authored by hentsch).
IntensityProfile should throw exception if image is 4D and can't be processed
Mar 19 2019, 11:53 AM
hentsch added a comment to T23191: Image Statistics plugin: 4D data + intensity profile does not work.

Pushed new branch T23191-4DIntensityProfile.

Mar 19 2019, 11:52 AM · MITK
hentsch added inline comments to rMITK4409ae4d1006: Added properties to zoom to the set values, doesnt work yet.
Mar 19 2019, 9:05 AM

Mar 15 2019

hentsch committed rMITKe956a98b7a10: Merge branch 'T25568-remove-old-image-statistics-plugin' (authored by hentsch).
Merge branch 'T25568-remove-old-image-statistics-plugin'
Mar 15 2019, 3:34 PM
hentsch committed rMITKa17898c7a71b: removed unneeded variable resolved T25568 (authored by hentsch).
removed unneeded variable resolved T25568
Mar 15 2019, 3:33 PM
hentsch committed rMITKc954eae5f79d: renamed QmitkImageSTatisticsReload to QmitkImageStatistics (authored by hentsch).
renamed QmitkImageSTatisticsReload to QmitkImageStatistics
Mar 15 2019, 3:33 PM
hentsch committed rMITK44ff1e95ed27: removed old statistics view (authored by hentsch).
removed old statistics view
Mar 15 2019, 3:33 PM
hentsch added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

could also be that the problems arise due to ITK update (2016.03: 4.7.1, 2016.11: 4.9.0).
We could check that with MITK code from end 2016 and an updated ITK version.

Mar 15 2019, 1:32 PM · MITK
hentsch updated subscribers of T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

In MITK 2016.03, Reinit on the respective data sets work, whereas in MITK 2016.11, it does not work any more.
Hence, it has to do something with the changes introduces by @espak in Geometry (1ca1a7b0574).

Mar 15 2019, 1:10 PM · MITK
hentsch added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

futher analyses:

  • newer data tends to work better
    • newer in terms of date
    • newer in terms of acquisition machine software version
  • working and not working data stems from the same machine (Siemens)
Mar 15 2019, 1:04 PM · MITK
hentsch moved T26165: How to handle erroneous DICOMS/input data? from Backlog to MITK Meeting on the Request for Discussion board.
Mar 15 2019, 8:42 AM · Request for Discussion, DICOM, MITK
hentsch added a project to T26165: How to handle erroneous DICOMS/input data?: Request for Discussion.
Mar 15 2019, 8:41 AM · Request for Discussion, DICOM, MITK
hentsch added a project to T26165: How to handle erroneous DICOMS/input data?: DICOM.
Mar 15 2019, 8:41 AM · Request for Discussion, DICOM, MITK
hentsch triaged T26165: How to handle erroneous DICOMS/input data? as Normal priority.
Mar 15 2019, 8:40 AM · Request for Discussion, DICOM, MITK

Mar 14 2019

hentsch added a comment to T25833: Leak/Debugbreak when closing workbench related to MitkChart.

further hints: https://github.com/electron/electron/issues/15133

Mar 14 2019, 10:36 AM · Restricted Project, MITK

Mar 13 2019

hentsch committed rMITK4c8300c0c039: Fixes for GCC (authored by hentsch).
Fixes for GCC
Mar 13 2019, 5:12 PM
hentsch added a comment to T23104: Deprecate QmitkPlotWidget.

deprecation leads to errors in GCC

Mar 13 2019, 4:56 PM · Restricted Project, MITK
hentsch committed rMITK0f118b0b703a: fixes for GCC (authored by hentsch).
fixes for GCC
Mar 13 2019, 4:48 PM
hentsch committed rMITKd6f4d04b934b: Merge branch 'T25700-deleteImageStatisticsNodeDeprecated' (authored by hentsch).
Merge branch 'T25700-deleteImageStatisticsNodeDeprecated'
Mar 13 2019, 1:43 PM
hentsch committed rMITK6f73c731232b: Holding rules not necessary (authored by hentsch).
Holding rules not necessary
Mar 13 2019, 11:49 AM
hentsch committed rMITKfc4f3e114ec7: Simplified OnStatisticsCalculationEnds (authored by hentsch).
Simplified OnStatisticsCalculationEnds
Mar 13 2019, 11:49 AM

Mar 12 2019

hentsch added inline comments to rMITK27a095954d52: Added comments, new tests.
Mar 12 2019, 3:12 PM
hentsch added inline comments to rMITK513797e0e164: Changed indextype name, implemented new tests.
Mar 12 2019, 3:12 PM
hentsch added inline comments to rMITKce48f96ec50d: Changed double and unsigned long to fit stay adaptive.
Mar 12 2019, 2:05 PM
hentsch added inline comments to rMITKc8b79109c683: Now changes color in all chart types.
Mar 12 2019, 11:36 AM
hentsch added a comment to T25918: [imageStatisticsCalculator] Rename StatisticsObject to ImageStatisticsObject.

looks fine, you can merge it :)

Mar 12 2019, 11:25 AM · MITK

Mar 1 2019

hentsch added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

had a further look into it:

  • looked into the matrix vectors. Looks like the first and the second vector is normalized, but the third is not (https://academo.org/demos/3d-vector-plotter/)
  • tried to transpose the matrix
  • tried to change the last column by sign
  • the rectification leads to a normal vector that is the same like the first vector.
  • we can set the matrix manually to space directions: (1.9,0,0) (0,1.9,0) (0,0,12) (pixel spacing). But that's not a real solution as we usually can't alter the data.
Mar 1 2019, 4:33 PM · MITK
hentsch committed rMITK848f5ae8a04f: first try to fix T25700 (authored by hentsch).
first try to fix T25700
Mar 1 2019, 2:25 PM
hentsch committed rMITK0edeb6292b96: Merge branch 'T25845-GUIInitializationState' (authored by hentsch).
Merge branch 'T25845-GUIInitializationState'
Mar 1 2019, 10:14 AM
hentsch closed T25845: Check GUI initialization state as Resolved by committing rMITK9939f5dbf51c: Resolved T25845.
Mar 1 2019, 10:14 AM · Restricted Project, MITK
hentsch committed rMITK9939f5dbf51c: Resolved T25845 (authored by hentsch).
Resolved T25845
Mar 1 2019, 10:13 AM
hentsch added a comment to T25845: Check GUI initialization state.

Pushed new branch T25845-GUIInitializationState.

Mar 1 2019, 10:13 AM · Restricted Project, MITK

Feb 28 2019

hentsch claimed T25845: Check GUI initialization state.
Feb 28 2019, 5:06 PM · Restricted Project, MITK

Feb 26 2019

hentsch added a comment to rMITKa456c97939bf: Deleted unnecassary code, rewrote verify statistics, fixed accuracy of test….

sieht gut aus, vielen dank :)
Lass uns die Anmerkungen am besten kurz besprechen

Feb 26 2019, 4:25 PM

Feb 22 2019

hentsch closed T26037: Make use of custom statistic values possible as Resolved by committing rMITK3c8bb832f9cd: Resolved T26037.
Feb 22 2019, 1:57 PM · MITK
hentsch committed rMITK3880e5c6a0fd: Merge branch 'T26037-useCustomStatisticValues' (authored by hentsch).
Merge branch 'T26037-useCustomStatisticValues'
Feb 22 2019, 1:57 PM
hentsch closed T26037: Make use of custom statistic values possible, a subtask of T25512: Restructure image statistics calculator, as Resolved.
Feb 22 2019, 1:57 PM · MITK
hentsch committed rMITK3c8bb832f9cd: Resolved T26037 (authored by hentsch).
Resolved T26037
Feb 22 2019, 12:04 PM
hentsch added a comment to T26037: Make use of custom statistic values possible.

Pushed new branch T26037-useCustomStatisticValues.

Feb 22 2019, 12:04 PM · MITK
hentsch triaged T26102: Display only available statistics in QmitkImageStatisticsWidget as Wishlist priority.
Feb 22 2019, 12:02 PM · MITK
hentsch claimed T26037: Make use of custom statistic values possible.
Feb 22 2019, 11:34 AM · MITK

Feb 21 2019

hentsch committed rRTTBa4f2b6070395: Litmus compiles with ITK 5 (authored by hentsch).
Litmus compiles with ITK 5
Feb 21 2019, 2:53 PM
hentsch merged task T25994: Voxelizer plugin doesn't work anymore into Restricted Maniphest Task.
Feb 21 2019, 10:08 AM · Restricted Project, Restricted Project

Feb 20 2019

hentsch added a comment to T26080: [QmitkImageStatisticsTableModel] Multiple masks instead multiple timesteps.

we should add an extra view mode MaskXStatistic to avoid mixture of different things

Feb 20 2019, 3:20 PM · MITK
hentsch triaged T26080: [QmitkImageStatisticsTableModel] Multiple masks instead multiple timesteps as Wishlist priority.
Feb 20 2019, 3:10 PM · MITK
hentsch added a subtask for T25512: Restructure image statistics calculator: Unknown Object (Maniphest Task).
Feb 20 2019, 2:56 PM · MITK

Feb 19 2019

hentsch closed T26067: Add possibility to add x-data as Resolved by committing rMITKa043041ddaed: Resolved T26067.
Feb 19 2019, 5:16 PM · MITK
hentsch committed rMITK73710f09b448: Merge branch 'T26067-addXData' (authored by hentsch).
Merge branch 'T26067-addXData'
Feb 19 2019, 5:16 PM
hentsch closed T26067: Add possibility to add x-data, a subtask of T25683: Chart Example Plugin, as Resolved.
Feb 19 2019, 5:16 PM · MITK
hentsch committed rMITKc7227693b905: added documentation (authored by hentsch).
added documentation
Feb 19 2019, 5:14 PM
hentsch committed rMITK1d43ba8e0e80: consistent naming (authored by hentsch).
consistent naming
Feb 19 2019, 5:14 PM
hentsch committed rMITK61511aaa407d: Removed unneeded includes (authored by hentsch).
Removed unneeded includes
Feb 19 2019, 5:14 PM