Page MenuHomePhabricator

ritter (Markus Ritter)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (210 w, 5 d)
Roles
Disabled

Recent Activity

Aug 2 2016

ritter added projects to T6934: Test for AffineInteraction: MITK, Bugzilla.
Aug 2 2016, 9:43 AM · Bugzilla, MITK
ritter added projects to T6932: Affine Interactor should inform when an interaction is completed: MITK, Bugzilla.
Aug 2 2016, 9:43 AM · Bugzilla, MITK
ritter added a comment to T6932: Affine Interactor should inform when an interaction is completed.

introduce new events

Aug 2 2016, 9:43 AM · Bugzilla, MITK
ritter added a comment to T6932: Affine Interactor should inform when an interaction is completed.

changed the implementation design from mitkMessage to the common itkEvent concept.

Aug 2 2016, 9:43 AM · Bugzilla, MITK
ritter added a comment to T6932: Affine Interactor should inform when an interaction is completed.

[SVN revision 29727]
FIX (#6932): added new events; events get invoked after interaction has ended

Aug 2 2016, 9:43 AM · Bugzilla, MITK
ritter added a comment to F662: affineinteraction.patch.

introduce new events

Aug 2 2016, 9:43 AM
ritter added a comment to T5921: no check if polydatas are the same in SetVtkPolyData.

[SVN revision 27277]
FIX (#5921): check if polydatas are the same

Aug 2 2016, 9:41 AM · Bugzilla, MITK
ritter added a comment to F628: #5921.patch.

check if polydatas are the same

Aug 2 2016, 9:41 AM
ritter added a comment to T5921: no check if polydatas are the same in SetVtkPolyData.

check if polydatas are the same

Aug 2 2016, 9:41 AM · Bugzilla, MITK
ritter added projects to T5921: no check if polydatas are the same in SetVtkPolyData: MITK, Bugzilla.
Aug 2 2016, 9:41 AM · Bugzilla, MITK
ritter added projects to T5886: AutoCropImageFilter changes the geometry of the input image: MITK, Bugzilla.
Aug 2 2016, 9:41 AM · Bugzilla, MITK
ritter added a comment to T5886: AutoCropImageFilter changes the geometry of the input image.

[SVN revision 27918]
FIX (#5886): clone the IndexToWorldTransform before applying it to the output image; using itkRegionOfInterestImageFilter instead of itkCropImageFilter

Aug 2 2016, 9:41 AM · Bugzilla, MITK
ritter added a comment to T5886: AutoCropImageFilter changes the geometry of the input image.

some refactoring:

  • Getter-Method for the calculated image region
  • itkRegionOfInterestImageFilter instead of itkCropImageFilter when extracting the image region from the input
Aug 2 2016, 9:41 AM · Bugzilla, MITK
ritter added a comment to T5866: QmitkStdMultiWidget does not emit signal, when WidgetPlaneMode changes.

[SVN revision 27235]
FIX (#5866): emit signal "WidgetPlaneModeChange(int)" when changing plane mode

Aug 2 2016, 9:41 AM · Bugzilla, MITK
ritter added projects to T5866: QmitkStdMultiWidget does not emit signal, when WidgetPlaneMode changes: MITK, Bugzilla.
Aug 2 2016, 9:41 AM · Bugzilla, MITK
ritter added a comment to T5433: Warnings in QmitkToolRoiDataSelectionToolBox and QmitkToolWorkingDataSelectionBox.

[SVN revision 26273]
FIX (#5433): removed unused parameters

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5391: Segmentation is currently not supported for 2D images.

closing this bug, since it is a duplicate of #4017

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5303: enhance the functionality of mitkBoundingObjectGroup.

[SVN revision 26098]
ENH (#5303): added a filter to create segmentations out of boundingobjects

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5304: adding ROI support to toolframework.

[SVN revision 26174]
ENH (#5304): - migrated WorkingDataSelectionBox to Qt4 with basic functionality

  • added RoiDataSelectionBox and BoundingObjectWidget
Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added projects to T5304: adding ROI support to toolframework: MITK, Bugzilla.
Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5304: adding ROI support to toolframework.

[SVN revision 26108]
ENH (#5304): -adding ROI support to BinaryThresholdTool

  • adding SpinBox to GUI
Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5304: adding ROI support to toolframework.

[SVN revision 27926]
ENH (#5304): added first version of MaskAndCutRoiImageFilter; minor changes to Mask- and PadImageFilter

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5303: enhance the functionality of mitkBoundingObjectGroup.

[SVN revision 25995]
ENH (#5303): -added a function to remove a boundingobject from the group
-use a deque instead of itk::VectorContainer for m_BoundingObjects

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5304: adding ROI support to toolframework.

[SVN revision 26665]
ENH (#5304): added member vars (+ getter/setter) to store the minima/maxima pixel values of the original image in the masked area.

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5303: enhance the functionality of mitkBoundingObjectGroup.

[SVN revision 27919]
FIX (#5303): correct region calculation

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5304: adding ROI support to toolframework.

[SVN revision 26002]
ENH (#5304): adding getter, setter, observer and a new message for roi data

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5303: enhance the functionality of mitkBoundingObjectGroup.

[SVN revision 26094]
FIX (#5303): fixing warnings of uninitialized variables

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5304: adding ROI support to toolframework.

[SVN revision 26037]
ENH (#5304): adding flag for ROI support

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added projects to T5303: enhance the functionality of mitkBoundingObjectGroup: MITK, Bugzilla.
Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added projects to T5300: app crashes when segmentation bundle is active and datastorage is empty: MITK, Bugzilla.
Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5300: app crashes when segmentation bundle is active and datastorage is empty.

[SVN revision 25984]
FIX (#5300): only try to get name from node if it exists. adjusted the visibility of labels

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5294: paintbrushtools produce vtk-warnings.

[SVN revision 26136]
FIX (#5294): leave the last contour point retrieved from ipMITKSegmentationGetContour8N out, when creating mitk::Contour

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5294: paintbrushtools produce vtk-warnings.

The warnings are produced because of coincident points in the contour. When getting the contour from ipMITKSegmentationGetContour8N the first ant the last point are equal. Leaving the last point out seems to produce correct contours without vtk-warnings. Need to do some testing

Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added projects to T5294: paintbrushtools produce vtk-warnings: MITK, Bugzilla.
Aug 2 2016, 9:40 AM · Bugzilla, MITK
ritter added a comment to T5041: option for showing "helper objects" in datamanager view.

current Progress

Aug 2 2016, 9:39 AM · Bugzilla, MITK
ritter added projects to T5041: option for showing "helper objects" in datamanager view: MITK, Bugzilla.
Aug 2 2016, 9:39 AM · Bugzilla, MITK
ritter added a comment to F580: showHelper.patch.

current Progress

Aug 2 2016, 9:39 AM
ritter added a comment to T4948: segmented pixel does not match selected pixel.

seems that there is still a problem when transforming worldcoordinates into unitbased pixel coordinates. setting dependency to T4692

Aug 2 2016, 9:39 AM · Bugzilla, MITK
ritter added a comment to T4948: segmented pixel does not match selected pixel.

adding a patch showing the current progress

Aug 2 2016, 9:39 AM · Bugzilla, MITK
ritter added a comment to T4948: segmented pixel does not match selected pixel.

The function WorldToIndex In mitkGeometry3D (line 323), which takes world coordinates in mm and processes them into discrete index coordinates in units, might do something wrong.

Aug 2 2016, 9:39 AM · Bugzilla, MITK
ritter added a comment to T4948: segmented pixel does not match selected pixel.

commited the changes of the attached patch, to make the segmentationbundle usable again. Still some files still have to be checked.

Aug 2 2016, 9:39 AM · Bugzilla, MITK
ritter added a comment to F575: offset_correction.patch.

current progress

Aug 2 2016, 9:39 AM
ritter added a comment to T4872: No descriptor for images that are not binary.

[SVN revision 26029]
ENH (#4872): adding new NodeDescriptor "NoneBinaryImage"

Aug 2 2016, 9:39 AM · Bugzilla, MITK
ritter added projects to T4872: No descriptor for images that are not binary: MITK, Bugzilla.
Aug 2 2016, 9:39 AM · Bugzilla, MITK
ritter added a comment to T4692: Inconsistent handling of pixel and voxel centers.

attached a patch, that should correct the IsIndexInside function, when it is an image geometry

Aug 2 2016, 9:38 AM · Bugzilla, MITK
ritter added a comment to F561: geometry3d.patch.

patch for correcting the IsIndexInside function

Aug 2 2016, 9:38 AM
ritter added a comment to T4601: the popup for selecting the bounding object blocks application.

[SVN revision 24463]
FIX (#4601): now the bounding object is created on user request, so the popup does not block the application on startup. Also cleaned up the code a bit

Aug 2 2016, 9:38 AM · Bugzilla, MITK
ritter added a comment to T4601: the popup for selecting the bounding object blocks application.

we decided that it is better to create the bounding object on user request. now the dialog only pops up when the user presses the new boundingbox button or when changeing the image in the combobox

Aug 2 2016, 9:38 AM · Bugzilla, MITK
ritter added projects to T4601: the popup for selecting the bounding object blocks application: MITK, Bugzilla.
Aug 2 2016, 9:38 AM · Bugzilla, MITK
ritter added a comment to T4385: isInside method is still slow on ellipsoid, cone and cylinder.

[SVN revision 23894]
FIX (#4385): IsInside method now uses the VtkTransform, which caches the inverse.

Aug 2 2016, 9:38 AM · Bugzilla, MITK
ritter added projects to T4385: isInside method is still slow on ellipsoid, cone and cylinder: MITK, Bugzilla.
Aug 2 2016, 9:38 AM · Bugzilla, MITK
ritter added a comment to T4330: possible memory bug in cdelete.

this bug has been fixed in rev:23804 see T4333

Aug 2 2016, 9:38 AM · Bugzilla, MITK
ritter added a comment to F534: imageCropper_offset1.png.

showing offset on Pic3D

Aug 2 2016, 9:37 AM
ritter added a comment to T4007: BoundingObjectCutter produces offset.

attached example pic, to show the produced offset

Aug 2 2016, 9:37 AM · Bugzilla, MITK
ritter added projects to T4007: BoundingObjectCutter produces offset: MITK, Bugzilla.
Aug 2 2016, 9:37 AM · Bugzilla, MITK
ritter added a comment to T4007: BoundingObjectCutter produces offset.

after testing some more pictures, it seems that the problem occurs on all images. (but on Pic3D it's easier to see). if you do not delete the boundingobject in the imagecropper after croping you can see, that the upper and the left border of the image is not inside the boundingobject and that the pixelvalue of those pixels outside have a value of 0. on the right and the bottom border, there are pixels inside the boundingobject that have no value, thus not existing in the cropped image. maybe this is related to some changes made in tik3.16 ?

Aug 2 2016, 9:37 AM · Bugzilla, MITK
ritter added a comment to T4000: IsInside function of boundingobjects seems to be broken.

the problem only occurs in border areas of rotated mr images.

Aug 2 2016, 9:37 AM · Bugzilla, MITK
ritter added a comment to F533: rotatedMR_Seg1.png.

BoundingObjectSegmentation on rotated MR

Aug 2 2016, 9:37 AM
ritter added a comment to T4000: IsInside function of boundingobjects seems to be broken.

as mentioned above, the problems only occurs on rotated mr images. on "normal" images the IsInside method evaluates correctly.
My test case: Create a boundingobject (e.g. a cube) and use the BoundingObjectCutter to cut it out.

Aug 2 2016, 9:37 AM · Bugzilla, MITK
ritter added a comment to T4000: IsInside function of boundingobjects seems to be broken.

result when creating a binary image out of a rotated MR when using the BoundingObjectCutter

Aug 2 2016, 9:37 AM · Bugzilla, MITK
ritter added a comment to T4000: IsInside function of boundingobjects seems to be broken.

maybe this is also related to T4692. i'll test it after applying ivo's patch

Aug 2 2016, 9:37 AM · Bugzilla, MITK
ritter added a comment to T4000: IsInside function of boundingobjects seems to be broken.

(In reply to comment #1)

Can you provide a minimal example that shows the behavior? Ideally as a test
case?

Aug 2 2016, 9:37 AM · Bugzilla, MITK
ritter added projects to T4000: IsInside function of boundingobjects seems to be broken: MITK, Bugzilla.
Aug 2 2016, 9:37 AM · Bugzilla, MITK
ritter added a comment to T3847: Moving Image Opacity in PointBasedRegistration does not work correctly.

[SVN revision 22726]
FIX (#3847): changed signal from sliderMoved to valueChanged

Aug 2 2016, 9:37 AM · Bugzilla, MITK
ritter added a comment to T3842: It is possible to select more then one tool in the Measurement bundle.

[SVN revision 22727]
FIX (#3842): added m_DrawActionsGroup for exclusive triggering and a check if the planar figure is initialized

Aug 2 2016, 9:37 AM · Bugzilla, MITK
ritter added a comment to T3724: crash after undoing a cropping.

[SVN revision 22955]
FIX (#3724): added a destructor for opExchangeNodes (which is a mitk::Operation). when called, it removes the observers from m_Node, m_OldData and m_NewData

Aug 2 2016, 9:36 AM · Bugzilla, MITK
ritter added a comment to T3724: crash after undoing a cropping.

only clicking in one of the 2D-views lead to the crash, other interaction is possible. When clicking inside a 2D-view, the NodeDeleted callback function is executed.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
ritter added projects to T3724: crash after undoing a cropping: MITK, Bugzilla.
Aug 2 2016, 9:36 AM · Bugzilla, MITK
ritter added a comment to T3482: Qmitk depends on QmitkExt.

(In reply to comment #3)

Aug 2 2016, 9:36 AM · Bugzilla, MITK
ritter added a comment to T3476: Warnings and Messages in the console.

[SVN revision 22214]
FIX (#3476): removed debug message and changed notation in plugin.xml

Aug 2 2016, 9:36 AM · Bugzilla, MITK
ritter added a comment to T3438: Threshold Dialog window size too large.

[SVN revision 21775]
FIX (#3438): set dialog to a fixed size of 300x50

Aug 2 2016, 9:36 AM · Bugzilla, MITK
ritter added projects to T3438: Threshold Dialog window size too large: MITK, Bugzilla.
Aug 2 2016, 9:36 AM · Bugzilla, MITK
ritter added projects to T3417: ExtApp crashes when applying a threshold segmentation via contextmenue: MITK, Bugzilla.
Aug 2 2016, 9:36 AM · Bugzilla, MITK
ritter added a comment to T3417: ExtApp crashes when applying a threshold segmentation via contextmenue.

[SVN revision 21773]
FIX (#3417): Don't delete ThresholdToolManager, just clear the data

Aug 2 2016, 9:36 AM · Bugzilla, MITK
ritter added a comment to T3392: crash after using Fill tool.

can't reproduce it here. maybe this bug was related to #3417. Jochen, can you try to reproduce it?

Aug 2 2016, 9:35 AM · Bugzilla, MITK
ritter added a comment to T2472: Progress bar behaves unusual.

[SVN revision 22067]
FIX (#2472): fixed progress bar behavior

Aug 2 2016, 9:27 AM · Bugzilla, MITK