T27689 RTDose_image_cannot_be_serialized_and_workbench_crashes_upon_loading
52adb58300dd
Actions

Description

T27689 RTDose_image_cannot_be_serialized_and_workbench_crashes_upon_loading

Summary:
Changed to DoubleProperty to support existing serializers

Changed to Point3dProperty to use existing serializer.

Not really needed for this bug. But also cleaned it up
as plain GenericProperty<> in general cannot be serialized currently.

Code clean up (dead code)

Test Plan: unit test, code review and manual test if the error can be reproduced

Reviewers: O3 MITK Reviewer Group II, thomass, O1 MITK Reviewer Group I

Reviewed By: O3 MITK Reviewer Group II, thomass, O1 MITK Reviewer Group I

Subscribers: kislinsk

Differential Revision: https://phabricator.mitk.org/D449

Details

Provenance

floca	Authored on Jan 11 2021, 7:10 PM
floca	Pushed on Jan 20 2021, 5:27 PM

Reviewer

O3: MITK Reviewer Group II

Differential Revision

Restricted Differential Revision

Parents

rMITKadb6d06ec088: Fixed T27689
rMITK15ecdf8d92aa: Update DCMQI to v1.2.3

Branches

Unknown

Tags

Unknown

Event Timeline

floca committed rMITK52adb58300dd: T27689 RTDose_image_cannot_be_serialized_and_workbench_crashes_upon_loading (authored by floca).Jan 20 2021, 5:27 PM

floca added an edge: Restricted Differential Revision.

kislinsk mentioned this in T28197: 2021 Week 04 (Very Late January).Jan 25 2021, 5:33 PM

Merged Changes

adb6d06ec088 Fixed T27689
Author
floca
Browse Repository
No Builds
No Audits
bac2bebfaee6 Prevent that serialization errors of single properties lead to a failed write…
Author
floca
Browse Repository
No Builds
No Audits
b0a993ea0c4b Code clean up (dead code)
Author
floca
Browse Repository
No Builds
No Audits
9919ca949962 Changed to Point3dProperty to use existing serializer.
Author
floca
Browse Repository
No Builds
No Audits
bb5f99527044 Changed to DoubleProperty to support existing serializers
Author
floca
Browse Repository
No Builds
No Audits

Changes (8)

Path

Size

Packages

Modules/

Classification/

CLMiniApps/

CLGlobalImageFeatures.cpp

Core/

src/

IO/

mitkItkImageIO.cpp

O1: MITK Reviewer Group I

MatchPointRegistration/

src/

Rendering/

mitkRegEvaluationMapper2D.cpp

O3: MITK Reviewer Group II

RT/

autoload/

DICOMRTIO/

mitkRTDoseReaderService.cpp

test/

mitkRTDoseReaderServiceTest.cpp

Plugins/

org.mitk.gui.qt.dosevisualization/

src/

internal/

RTDoseVisualizer.cpp

O3: MITK Reviewer Group II

org.mitk.gui.qt.matchpoint.evaluator/

src/

internal/

QmitkMatchPointRegistrationEvaluator.cpp

O3: MITK Reviewer Group II

org.mitk.gui.qt.matchpoint.manipulator/

src/

internal/

QmitkMatchPointRegistrationManipulator.cpp

O3: MITK Reviewer Group II

rMITK52adb58300dd

View Options

Modules/Classification/CLMiniApps/CLGlobalImageFeatures.cpp

View Options

Modules/Core/src/IO/mitkItkImageIO.cpp

View Options

Modules/MatchPointRegistration/src/Rendering/mitkRegEvaluationMapper2D.cpp

View Options

Modules/RT/autoload/DICOMRTIO/mitkRTDoseReaderService.cpp

View Options

Modules/RT/test/mitkRTDoseReaderServiceTest.cpp

View Options

Plugins/org.mitk.gui.qt.dosevisualization/src/internal/RTDoseVisualizer.cpp

View Options

Plugins/org.mitk.gui.qt.matchpoint.evaluator/src/internal/QmitkMatchPointRegistrationEvaluator.cpp

View Options

Plugins/org.mitk.gui.qt.matchpoint.manipulator/src/internal/QmitkMatchPointRegistrationManipulator.cpp

T27689 RTDose_image_cannot_be_serialized_and_workbench_crashes_upon_loading52adb58300ddActions

Description

Details

Event Timeline

Merged Changes

Changes (8)

rMITK52adb58300dd

Modules/Classification/CLMiniApps/CLGlobalImageFeatures.cpp

Modules/Core/src/IO/mitkItkImageIO.cpp

Modules/MatchPointRegistration/src/Rendering/mitkRegEvaluationMapper2D.cpp

Modules/RT/autoload/DICOMRTIO/mitkRTDoseReaderService.cpp

Modules/RT/test/mitkRTDoseReaderServiceTest.cpp

Plugins/org.mitk.gui.qt.dosevisualization/src/internal/RTDoseVisualizer.cpp

Plugins/org.mitk.gui.qt.matchpoint.evaluator/src/internal/QmitkMatchPointRegistrationEvaluator.cpp

Plugins/org.mitk.gui.qt.matchpoint.manipulator/src/internal/QmitkMatchPointRegistrationManipulator.cpp

T27689 RTDose_image_cannot_be_serialized_and_workbench_crashes_upon_loading
52adb58300dd
Actions