HomePhabricator
Diffusion MITK 5a894d07de8d

Improve reinit behavior

Description

Improve reinit behavior

Summary:
First draft of refactoring the RenderingManager.
The idea is to separate the view initialization from rendering updates. This probably fits T27613 best - but more code needs to be changed.
The topic was also discussed in T26496 (e.g. removing "IRenderingManager") so this task is also related.

Separate view initialization from rendering update

Remove view initialization functions from interface

Modify data node actions to use the new RenderWindowManager

Modify module classes to use the new RenderWindowManager

Modify examples to use the new RenderWindowManager

Modify plugins to use the new RenderWindowManager

Remove IRenderingManager


Clean classes

Make functions more consistent

Test Plan:
Most important changes are

  • documentation
  • changing bool initializeGlobalTime = true (true as default, instead of false)
    • some initialize-functions don't have this parameter; here the global time is always initialized (true as implicit default)
  • alignment of function bodies

So I suggest to clarify these changes / clean the class even more and then define a clear test plan.

Reviewers: floca, kislinsk, O1 MITK Reviewer Group I, O3 MITK Reviewer Group II

Reviewed By: floca, O1 MITK Reviewer Group I, O3 MITK Reviewer Group II

Subscribers: kalali, kislinsk, floca

Maniphest Tasks: T27613

Differential Revision: https://phabricator.mitk.org/D517

Details

Provenance
kalaliAuthored on Jan 17 2022, 1:08 PM
kalaliPushed on Mar 8 2022, 2:39 PM
Reviewer
O1: MITK Reviewer Group I
Differential Revision
Restricted Differential Revision
Parents
rMITKa9f3a2d6e3c2: Use const getter functions
rMITK16277ce23174: Handle case insensitive CEST properties
Branches
Unknown
Tags
Unknown
Tasks
T27613: Improve reinit behavior