HomePhabricator
Diffusion MITK 65af279906d1

Merge branch 'bugfix/T29494-RegressionInPreferencesChangedEvent' into develop

Description

Merge branch 'bugfix/T29494-RegressionInPreferencesChangedEvent' into develop

Details

Auditors
floca
Provenance
kislinskAuthored on Mar 19 2023, 5:18 PM
kislinskPushed on Mar 19 2023, 5:18 PM
Parents
rMITKf50eaee22362: Fix a regression in Preference change events
rMITK4974a335ada8: Show warning for interaction reference geometry
Branches
Unknown
Tags
Unknown

Event Timeline

floca raised a concern with this commit.Mar 21 2023, 6:11 PM
floca added a subscriber: floca.
floca added inline comments.
/Modules/Core/src/IO/mitkPreferences.h
90

Is this realy the right solution? both events now seem pretty redundant when always triggered together and changing values also mean structural changes. Which I would not expect.

This commit now has outstanding concerns.Mar 21 2023, 6:11 PM
kislinsk added inline comments.
/Modules/Core/src/IO/mitkPreferences.h
90

Yes I know this is ugly but it resembles the original BlueBerry-based code path. It got lost during the migration to the Core services as the call to OnChanged() was hidden behind an otherwise unfinished and unused "mark as dirty" feature that was scattered across the whole class(es) without doing anything... well, besides this side effect in that very situation here that everything else relied on to happen.

So I does not like the design as well but the current solution is the minimal invasive solution that does not change API and does not change anything compared to before, so it's neither better nor worse and I can live with that for the sake of not touching all the classes that rely on these specific events. :)

All concerns with this commit have now been addressed.Mar 21 2023, 7:14 PM