Merge branch 'bugfix/T29494-RegressionInPreferencesChangedEvent' into develop
kislinsk Authored on Mar 19 2023, 5:18 PM kislinsk Pushed on Mar 19 2023, 5:18 PM
- rMITKf50eaee22362: Fix a regression in Preference change events
rMITK4974a335ada8: Show warning for interaction reference geometry
Is this realy the right solution? both events now seem pretty redundant when always triggered together and changing values also mean structural changes. Which I would not expect.
Yes I know this is ugly but it resembles the original BlueBerry-based code path. It got lost during the migration to the Core services as the call to OnChanged() was hidden behind an otherwise unfinished and unused "mark as dirty" feature that was scattered across the whole class(es) without doing anything... well, besides this side effect in that very situation here that everything else relied on to happen.
So I does not like the design as well but the current solution is the minimal invasive solution that does not change API and does not change anything compared to before, so it's neither better nor worse and I can live with that for the sake of not touching all the classes that rely on these specific events. :)