HomePhabricator
Diffusion MITK c80ff622c8e6

T30476-Expose_DCM_block_split_reason

Description

T30476-Expose_DCM_block_split_reason

Summary:
removed dead code

Fixed inconsistency in DICOMITKSeriesGDCMReader copy constructor and operaotr=. m_SimpleVolumeReading was not transfered.

Corrected visibility of internal clone implementation in ClassicDICOMSeriesReader

Add split reason class

Extended reader classes to support DICOMSplitReason to expose information

Add split information into property and tool output

Changed property path for split reason for being more generally applicable.

Changed MimeType check to not prefilter via extensons but directly check files for being DICOM.

+ Fixed T30486

Improved/fixed CLI argument documentatoin of MitkFileConverter

Added split reason MissingSlices to be more "expressive"/easy to parse

+ fixed the reason detection logic to prevent false positives

Added also dataset name to dicom tests to have more telling names

+ added some informative documentation

Renamed DICOMSplitReason to IOVolumeSplitReason and moved it to core to make it more broadly availabel

Added deserialization to IOVolumeSplitReason

Fixed bug. condensing 3D block now also merges split reasons

Added missing slices warning to MitkFileConverter and DICOMVolumeDiagnostics

Added test for IOVolumeSplitReason

Test Plan: code review, unit tests

Reviewers: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kislinsk

Reviewed By: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kislinsk

Subscribers: kislinsk

Maniphest Tasks: T30486

Differential Revision: https://phabricator.mitk.org/D976

Details

Provenance
flocaAuthored on Jul 31 2024, 8:27 AM
flocaPushed on Jul 31 2024, 9:40 AM
Reviewer
O3: MITK Reviewer Group II
Differential Revision
Restricted Differential Revision
Parents
rMITK90a3eb2512c5: Fixed errors in details generation for missing slice and slice distance
rMITK0b72a4ca94bc: Merge branch 'bugfix/T30499-DoubleUnregister' into develop
Branches
Unknown
Tags
Unknown
Tasks
T30486: [DCM] Directory loading feature does not work sometimes

Merged Changes