Page MenuHomePhabricator

Remove outline polydata from image mapper
Closed, InvalidPublic

Description

Inside the mitkImageVtkMapper2D is a huge function called CreateOutlinePolydata generating the counturs of an input binary image. This function is complicated and confusing. In order to improve the readability and maintainability, it should be moved to a filter/an additional class.

TODO:
-We have to design this in a way that also improves the performances issues mentioned in T12691.
-Check if anything else regarding contours can be moved from mitkImageVtkMapper2D.

Event Timeline

Cosmetic bug of medium importance. Everything can be done right now since #12691 is solved.

T12691 is closed, but the issue has not really been fixed. The changes made in T12691 have improved the rendering performance for slices that do not show binary segmentations.

Those slices that do show the segmentations are rendered as slow as before.

I created a new T13137 to fix the actual problem.

What is the status here? Markus E. are you working on this?

No, I'm not working on this right now.

The issue with the slow outline creation has been fixed and is already integrated into master.

Still cosmetic fix of medium importance. Someone with rendering experience like Christoph, Sandy, Markus or me should do it.

Because there is currently no other use case for creating oulines and also the code in ImageVtkMapper2D is very well documented, we decided that it is not necessary to outsource the code.

kislinsk changed the task status from Invalid to Spite.Jun 27 2018, 1:32 PM
kislinsk added a project: Bulk Edit.
kislinsk changed the task status from Spite to Invalid.Jun 27 2018, 1:36 PM
kislinsk removed a project: Bulk Edit.