Page MenuHomePhabricator

DICOM plug-in does not delete temporary files
Closed, ResolvedPublic


On my Ubuntu 12.04 system, when activating the DICOM plug-in by clicking on the toolbar button and then closing the application, all files in the current working directory are deleted.

Event Timeline

Michael Bauer won't be here for a while because of his exams. Keno and i will look into this.

[55a71d]: Merge branch 'bug-13021-do-not-remove-temp-files'

Merged commits:

2012-09-12 17:01:12 Marco Nolden [f9379e]
Commented out another temp file removal

This was dangerous since it did not check if everything is set

2012-09-12 17:04:36 Marco Nolden [bf0c95]
Dactivated temp file removal

This was very dangerous

This still needs more investigation, I just removed all the deletes.

What is the result of the "more investigation" ?

[d70faf]: Merge branch 'bug-13021-dicom-does-not-delete-temporary-files'

Merged commits:

2012-10-26 16:08:45 Michael Bauer [957976]
made several changes to avoid unwanted deletes but
still remove temporary dicom files if you close the dicom plugin.

  • unique temp dicom folder
  • check whether the dicom folder was created correctly before removing
  • only QmitkDicomDirectoryListener removes files

There is a little Syntax error which causes errors on the Dashboard:

/.../MITK/Plugins/org.mitk.gui.qt.dicom/src/internal/QmitkDicomEditor.h:121:10: error: extra qualification ‘QmitkDicomEditor::’ on member ‘CreateTemporaryDirectory’ [-fpermissive]

New remote branch pushed: bug-13021-RemoveExtraQualifierFromDicomEditorHeader

[5f9f47]: Merge branch 'bug-13021-RemoveExtraQualifierFromDicomEditorHeader'

Merged commits:

2012-10-29 09:02:46 Christoph Kolb [3ac807]
COMP: Fixed header