Page MenuHomePhabricator

Missing Tests in Core
Closed, ResolvedPublic

Description

List for classes in the core that are not yet covered by a test.

Event Timeline

Most important classes without test class(imo):

mitkDisplayGeometry.cpp & mitkGeometry2D.cpp (see mitkGeometryTest.cpp for coverage)
mitkImageCaster.cpp
mitkSlicedData.cpp
mitkPlaneOperation.cpp
mitkStandaloneDataStorage.cpp
mitkUIDGenerator.h

Additionally the following tests are commented out, thus this classes are also not tested:

#mitkImageMapper2DTest.cpp
#mitkImageToItkTest.cpp
#mitkPipelineSmartPointerCorrectnessTest.cpp
#mitkRegistrationBaseTest.cpp
#mitkSegmentationInterpolationTest.cpp
#mitkAbstractTransformGeometryTest.cpp
#mitkImageSliceSelectorTest.cpp

mitkVtkPropRendererTest.cpp

#mitkLabeledImageToSurfaceFilterTest.cpp
#mitkExternalToolsTest.cpp
[since 05.08.2009 with commit c240a53ed530a2bb2bfca71958a81fcf23c28899 / message: COMP: added files.cmake for tests.]

#QmitkRenderingTestHelper.cpp
[since 14.12.2011 with commit 3706a8a76f7dc4382b1fb5a869dfe33aaeb14c4d / message: Added the original test by Markus Engel including the RenderingTestHelper class. Reworked the helper class to use an mitkRenderWindow instead a QmitkRenderWindow. Currently, the test is saving the image as a screenshot, however, the screen is not correct yet.]

#mitkSTLFileReaderTest.cpp
[since 07.04.2010 with commit 2ff795f9c9c1eaaf216275bfcd71cfe06cc3e02b / message: disabled mitkPointsetLocaleTest again, cause the Test still fales on linux]

mitk::StandaloneDataStorage is tested in the test mitkDataStorageTest

There already is a test for mitkUIDGenerator.

New remote branch pushed: bug-13692-ActivateDeactivatedTests

cleaned up the core testing in branch bug-13692-ActivateDeactivatedTests and also activated / fixed some tests which were deactivated before. We should merge this back to the master.

[e52bb1]: Merge branch 'bug-13692-ActivateDeactivatedTests'

Merged commits:

2013-12-12 12:19:55 Alfred Franz [00119e]
updated test data hash tag


2013-12-12 12:07:58 Alfred Franz [9bce4d]
DOC: added bug number to deactivated test


2013-12-12 12:06:35 Alfred Franz [3e4869]
converted STL file reader test to the new CPP unit test environment. Test data could be used much easier now.


2013-12-12 11:41:40 Alfred Franz [d46a4e]
activated tests which were missing in the files.cmake. Added comments for the deactivated tests...


2013-12-11 18:31:10 Alfred Franz [6aefb8]
activated and extended RawImageFileReaderTest


2013-12-11 15:51:53 Alfred Franz [c5b818]
removed ImageMapper2DTest because the ImageMapper2D was completely replaced by the ImageVtkMapper2D

There are many new tests for the ImageVtkMapper2D, the old test class is not needed any more.


2013-12-11 15:44:00 Alfred Franz [1fe767]
cleaned up (removed files from cmake which are not in the core any more)


2013-12-11 15:16:07 Alfred Franz [b35ce8]
Merge branch 'bug-16654-ImageToItkTestFix_CorrectBase' into bug-13692-ActivateDeactivatedTests


2013-12-11 13:52:46 Jan Hering [826a8b]
Fixed ImageToItkTest

  • casting with correct types
  • testing for exception with wrong types
  • expplicit dereferencing of temporary itk image, test for expected exception

2013-12-11 13:24:43 Alfred Franz [7fad51]
cleaned up file structure


2013-12-11 13:00:03 Alfred Franz [4cc220]
cleaned up file


2013-12-11 12:56:47 Alfred Franz [35d484]
activated mitkImageSliceSelectorTest again


2013-12-11 11:33:37 Alfred Franz [d414dd]
Added new test case with real test data. (Warning test is failing, maybe because of T16654)


2013-12-11 10:11:46 Alfred Franz [42f196]
Started complete revision of ImageToItkTest... not finished yet.


2013-12-11 10:10:47 Alfred Franz [7fe927]
added some comments to old tests, activated tests which should be used again

Branch bug-13692-ActivateDeactivatedTests is merged... so the problem with the deactivated tests is solved.

Should we leave this bug open until the missing tests are also implemented?

User franza has pushed new remote branch:

bug-13692-AddCommentForDeactivatedTests

[aa407d]: Merge branch 'bug-13692-AddCommentForDeactivatedTests'

Merged commits:

2014-02-19 15:00:12 Alfred Franz [09d7c4]
DOC: added comment block for IGT


2014-02-19 14:57:10 Alfred Franz [c07445]
DOC: added a comment block for deactivating tests in the core

new list showing status of core tests

Moritz and Manuel created a nice overview of the core tests. See my excel attachment. White test of classes are unknown, red are without MITK macros, yellow are with testing macros, green are with CppUnit.

I figured out that the StandaloneDataStorage is covered by the mitkDataStorageTest.

mitkImageCaster does not contain logic and thus does not need a test.

SlicedData is a pure virtual class and already tested by all images tests.
mitkUIDGeneratorTest has been written already.
mitkPlaneOperation does not contain logic.

I will write a test for mitkDisplayGeometry.

User kilgus has pushed new remote branch:

bug-13692-DisplayGeometryTest

bug-13692-DisplayGeometryTest is obsolete, since the display geometry was removed.

nolden claimed this task.
nolden added a subscriber: nolden.

I will close this task now. There was valuable work done on adding and updating tests, but this will never be finished anyway. New developments in that area will be tracked in T26962.