Page MenuHomePhabricator
Create Task
Maniphest T13980

mitkUIDGenerator generates equal UID's
Closed, ResolvedPublic
Actions

Description

when two different instances of the UIDGenerator generates id's in the same second, the IDs are equal.
Possible solution:

  • Add static id
  • add milliseconds
  • add thread ID
  • write test

Event Timeline

• kolbch added projects: MITK, Bugzilla.Dec 12 2012, 3:46 PM
• kolbch added a subscriber: • kolbch.Dec 12 2012, 5:45 PM

New remote branch pushed: bug-13980-mitkUIDGeneratorGeneratesEqualUIDs

franza added a subscriber: franza.Jan 16 2013, 3:49 PM

[174e2e]: Merge branch 'bug-13980-mitkUIDGeneratorGeneratesEqualUIDs'

Merged commits:

2012-12-12 17:43:32 Christoph Kolb [2f4234]
added test and improved the seed for the randomnumber generator

franza added a comment.Jan 16 2013, 4:27 PM

[d9a801]: Merge branch 'bug-13980-mitkUIDGeneratorGeneratesEqualUIDs'

Merged commits:

2013-01-16 16:25:29 Alfred Franz [bbf52e]
COMP (#13980): added special case for WIN32 to get process ID

franza added a comment.Jan 16 2013, 4:36 PM

[9fdc32]: Merge branch 'bug-13980-mitkUIDGeneratorGeneratesEqualUIDs'

Merged commits:

2013-01-16 16:35:13 Alfred Franz [6cca6b]
COMP (#13980): added special include to get process ID under WIN32

franza added a comment.Jan 16 2013, 5:37 PM

[e084fe]: Merge branch 'bug-13980-mitkUIDGeneratorGeneratesEqualUIDs'

Merged commits:

2013-01-16 17:33:26 Alfred Franz [a58e73]
COMP (#13980): added hash with time and clock to seed

franza added a comment.Jan 16 2013, 5:57 PM

[e88c60]: Merge branch 'bug-13980-mitkUIDGeneratorGeneratesEqualUIDs'

Merged commits:

2013-01-16 17:55:35 Alfred Franz [455084]
COMP (#13980): added missing header include

franza added a comment.Jan 16 2013, 6:14 PM

[c88157]: Merge branch 'bug-13980-mitkUIDGeneratorGeneratesEqualUIDs'

Merged commits:

2013-01-16 18:12:28 Alfred Franz [e39f63]
COMP (#13980): moved method into namespace

franza added a comment.Jan 16 2013, 6:28 PM

[a727cc]: Merge branch 'bug-13980-mitkUIDGeneratorGeneratesEqualUIDs'

Merged commits:

2013-01-16 18:27:26 Alfred Franz [3fda5b]
COMP (#13980): replaced UCHAR_MAX for linux compatibility

nolden added a subscriber: nolden.Jan 21 2013, 1:56 PM

[e050bd]: Merge branch 'bug-13980-mitkUIDGeneratorGeneratesEqualUIDs'

Merged commits:

2013-01-21 13:18:54 Marco Nolden [f83bc9]
COMP: Fix for GCC 4.7 and (proably) MinGW

franza added a comment.Jan 23 2013, 1:35 PM

[9613e9]: Merge branch 'bug-13980-mitkUIDGeneratorGeneratesEqualUIDs'

Merged commits:

2013-01-23 13:34:02 Alfred Franz [f4301c]
DOC: Added documentation.

franza added a comment.Jan 23 2013, 1:39 PM

The UID generator was improved, but is still not perfect because real UID generation is a complex task. However, for most of the cases it should work now, and the test is also running. Thus, I'll close this bug.

Further improvements are discussed in the feature request T14333.

franza added a comment.Jan 23 2013, 5:48 PM

[fa28ed]: Merge branch 'bug-13980-ImproveUIDGeneratorTest'

Merged commits:

2013-01-23 17:47:08 Alfred Franz [26c8cf]
COMP (#13980): Extended test to find error in UIDGenerator on dart clients

franza added a comment.Jan 23 2013, 6:20 PM

New remote branch pushed: bug-13980-ImproveUIDGeneratorTest

franza added a comment.Jan 23 2013, 6:21 PM

[80ec5b]: Merge branch 'bug-13980-ImproveUIDGeneratorTest'

Merged commits:

2013-01-23 18:20:27 Alfred Franz [a98d14]
COMP (#13980): Removed unused code, also decreased path length

2013-01-23 18:19:03 Alfred Franz [ea755f]
COMP (#13980): Changed random generator to ITK random generator which is better (maybe)

franza added a comment.Jan 24 2013, 10:47 AM

[3867fd]: Merge branch 'bug-13980-ImproveUIDGeneratorTest'

Merged commits:

2013-01-24 10:37:44 Alfred Franz [c81924]
Cleaned up code after bugfixing: adapted documentation and removed unused code.

kislinsk edited projects, added MITK (2013-03); removed MITK.Aug 1 2016, 10:48 PM
MITK · MIC · IMSY · DKFZ