Page MenuHomePhabricator
Create Task
Maniphest T14179

Hide LevelWindowSlider if a lookuptable is set.
Closed, ResolvedPublic
Actions

Description

It is confusing to have GUI elements which do nothing. If a lookuptable property is set by the user, we decided that the slider should not change anything, and thus, be hidden. This bug is used to hide it. Hopefully, we will manage to fix this for the next release.

Related Objects
Search...

Event Timeline

• kilgus added projects: MITK, Bugzilla.Jan 9 2013, 3:24 PM
• kilgus added a subscriber: • kilgus.Jan 10 2013, 9:20 AM

If this stuff is in the core, we should maybe just use one bug and write just one core change request, since T12056 and this are closely related.

zelzer added a subscriber: zelzer.Jun 24 2013, 3:32 PM

What is the status of this bug? Please change the target milestone to "AfterNextRelease" if this bug is not relevant or cannot be fixed in time for the 2013-06 release.

• fetzer added a subscriber: • fetzer.Jun 27 2013, 1:29 PM

This bug could not be fixed for release 2013-06. Setting target milestone to next release

metzger added a subscriber: metzger.Jul 31 2013, 9:53 AM

What is the status of this bug? Can it be closed due to the changes of T12056?

• kilgus added a comment.Aug 5 2013, 9:32 AM

Still an issue.

The job is to hide the LevelWindowSlider if he does nothing (i.e. no lookuptable or something like that can be applied).

norajitr added a subscriber: norajitr.Aug 28 2013, 4:45 PM

Now, the level window slider is hidden if no image with an applicable level window is present within the data manager.

norajitr added a comment.Aug 29 2013, 4:01 PM

Hiding the level window slider is done by adding a property observer to the LevelWindowManager for the "Image Rendering.Mode" property. The LevelWindowManager::Update function is used for callback, subsequently calling LevelWindowManager::SetAutoTopMostImage. Here, the level window slider is hidden (i.e. m_LevelWindowProperty not being set from NULL), if all relevant data nodes use non-level-window "Image Rendering.Mode" property values.

norajitr added a comment.Sep 4 2013, 7:06 PM

New remote branch pushed: bug-14179-ConditionalLevelWindowSliderDeactivation

norajitr added a comment.Sep 18 2013, 2:28 PM

Testing implemented as part of bug-15992.

• engelhsa added a subscriber: • engelhsa.Oct 9 2013, 3:21 PM

New remote branch pushed: bug-14179-ConditionalLevelWindowSliderDeactivationFix

norajitr added a comment.Oct 9 2013, 3:23 PM

[7e86fc]: Merge branch 'bug-14179-ConditionalLevelWindowSliderDeactivationFix'

Merged commits:

2013-10-09 15:22:42 Tobias Norajitra [2b84a8]
Added an additional property observer to the LevelWindowManager for the rendering mode property, LevelWindowManager::Update being the proper callback function.

norajitr added a comment.Oct 9 2013, 3:51 PM

[6afc7b]: Merge branch 'bug-14179-ConditionalLevelWindowSliderDeactivationFix'

Merged commits:

2013-10-09 15:49:44 Tobias Norajitra [16c76e]
COMP: Uninitialized variable fix. Zero pointer return handled.

kislinsk edited projects, added MITK (2013-09); removed MITK.Aug 1 2016, 10:48 PM
MITK · MIC · IMSY · DKFZ