Page MenuHomePhabricator
Create Task
Maniphest T14698

Binary image is still rendered red if binary property is set to false
Closed, ResolvedPublic
Actions

Description

example image

Bundle_0_D11-11-3_S2-2-2_b1000_NOISE0_StickBall.dwi5 KBDownload

Related Objects
Search...

Event Timeline

neher added projects: MITK, Bugzilla.Mar 12 2013, 10:56 AM
• kilgus added a subscriber: • kilgus.Jun 12 2013, 4:20 PM

Valid bug. Easy to fix. Just go to mitk::ImageVtkMapper2D::ApplyColor and fix the if-conditions according to the "binary"-property.

• fetzer added a subscriber: • fetzer.Jun 27 2013, 1:29 PM

This bug could not be fixed for release 2013-06. Setting target milestone to next release

• ordas added a subscriber: • ordas.Aug 14 2013, 1:35 PM

this bug will be fixed together with 14386

• kilgus added a comment.Nov 13 2013, 3:46 PM

This bug is waiting for T14386.

• fetzer added a comment.Dec 9 2013, 3:50 PM

Current release is finished. Reseting target milestone...

• kilgus added a comment.Sep 24 2014, 3:13 PM

I will take care of this.

• git-user added a subscriber: • git-user.Sep 24 2014, 3:38 PM

User kilgus has pushed new remote branch:

bug-14698-BinaryImagePropertiesFix
• kilgus added a comment.Sep 24 2014, 3:45 PM

I pushed a solution. The hovering and the selected color property should only be applied for binary images. Added a check for binary. Please see my code for the trivial core change request.

zelzer added a subscriber: zelzer.Sep 24 2014, 3:53 PM

Is it documented in the properties Doxygen page that these properties only apply to binary images?

• kilgus added a comment.Sep 24 2014, 4:01 PM

The property names are:
binaryimage.hoveringcolor
binaryimage.selectedcolor

I think that is self descriptive :).

• kilgus added a comment.Sep 24 2014, 4:23 PM

My branch is ready to merge. Waiting for green dashboard ...

• kilgus added a comment.Sep 25 2014, 4:27 PM

[c9f922]: Merge branch 'bug-14698-BinaryImagePropertiesFix'

Merged commits:

2014-09-24 15:33:15 Thomas Kilgus [0c33aa]
The hovering and the selected color property should only be applied for binary images. Added a check for binary.

MITK · MIC · IMSY · DKFZ