Page MenuHomePhabricator

Improve documentation of "rendering modes" (give graphical examples)
Closed, ResolvedPublic

Description

Comment from mailing list: http://permalink.gmane.org/gmane.comp.lib.mitk.user/4124

It would be helpful if somebody cleans up after the changes of T10174 and T8165. Especially the interaction between lookup tables, color and opacity properties is hardly described:

http://docs.mitk.org/nightly-qt4/classmitk_1_1RenderingModeProperty.html#a7451daf93e33e8eac433b0b0440b220e

The documentation here would be more helpful if it gave examples of HOW the components are applied instead of just in which order. A graphical illustration would be the best :-)

Event Timeline

I will take care of this in the next bugsquashing.

New remote branch pushed: bug-15693-DocuAndExamplesOfRenderingModeProperty

I wrote a simple rendering test to illustrate the lookup table property and the corresponding rendering mode property.

We already have a similar test for colortransferfunctions which can serve as example. Next Wednesday, I will add another test for the LOOKUPTABLE_LEVELWINDOW_COLOR mode. Those three tests are nice visual and code examples of the different modes. I will also add more documentation.

I added example screen shots for docu and started writing it.

Todo:
-Finish docu
-Write test for LOOKUPTABLE_LEVELWINDOW_COLOR

New remote branch pushed: bug-15693-DocuRenderingMode

I finished the docu and added example screen shots.

[9ca365]: Merge branch 'bug-15693-DocuRenderingMode'

Merged commits:

2013-10-16 14:51:08 Thomas Kilgus [b13dd7]
Finished docu.


2013-10-09 16:52:43 Thomas Kilgus [695779]
Added another example screen shot to docu. Finished docu in property header. Removed an annoying warning from the image mapper.


2013-10-02 16:59:18 Thomas Kilgus [87ce17]
Starting docu. Added examples.


2013-10-02 16:59:03 Thomas Kilgus [99cce9]
Cleaning up tests. Reference screen shot has to be created after comparing/rendering.


2013-10-02 15:50:03 Thomas Kilgus [ca023a]
Renamed Cmake flag MITK_ENABLE_GUI_TESTING to MITK_ENABLE_RENDERING_TESTING


2013-10-02 15:09:54 Thomas Kilgus [251ce4]
Merge branch 'bug-15693-DocuAndExamplesOfRenderingModeProperty' into bug-15693-DocuRenderingMode


2013-08-07 17:40:31 Thomas Kilgus [27c0ca]
Added a new rendering test to better illustrate a lookuptable and the corresponding rendering mode.

[f56d45]: Merge branch 'bug-15693-DocuRenderingMode'

Merged commits:

2013-10-16 16:52:04 Thomas Kilgus [2e7358]
COMP: Outcommented test until MITK-Data has been updated.

[30ea9a]: Merge branch 'bug-15693-DocuRenderingMode'

Merged commits:

2013-10-22 10:41:07 Thomas Kilgus [bcdbd1]
Reactivated test. Updated MITK-Data.

[2d5c07]: Merge branch 'bug-15693-DocuRenderingMode'

Merged commits:

2013-10-22 15:45:57 Thomas Kilgus [3273f2]
COMP: Outcommented test, until we know what the issue is.

[9a70ea]: Merge branch 'bug-15693-AddTestAgain'

Merged commits:

2013-11-27 14:19:26 Thomas Kilgus [282428]
Adding test to check if its working on the dashboard now.

[047505]: Merge branch 'bug-15693-AddTestAgain'

Merged commits:

2013-11-27 15:13:43 Thomas Kilgus [d34c65]
COMP: Test not running yet.

[6c093f]: Merge branch 'bug-15693-AddTestAgain'

Merged commits:

2013-11-27 15:55:05 Thomas Kilgus [4e8946]
Trying to reactivate test with texture interpolation off.

[5cf84f]: Merge branch 'bug-15693-AddTestAgain'

Merged commits:

2013-11-27 16:18:49 Thomas Kilgus [72e786]
COMP: Still not working ... :(

The mitkImageVtkMapper2DLookupTableTest failes on the windows continuous. However, the test passes on local machines (Casper, Thomas, Sandy).

We tried to fix it by disabling the "texture interpolation" property (=false) in the test.

Unfortunaly this did not help to pass the test on the windows continuous virtual machine.

We assume the test image is not well chosen, because of the aliased font.

However, there is another test successfully using this image (mitkImageVtkMapper2DTransferFunctionTest), but with a error threshold. Potentially, it has the same problem as the mitkImageVtkMapper2DLookupTableTest.

The docu issue has been solved. A failing rendering test remains which will be solved in T16533.