Page MenuHomePhabricator

mitk::DataNode should not include mitk::Image in header
Closed, ResolvedPublic

Description

The mitk::DataNode header includes the header of mitk::Image (via mitkImageSource.h).

Although this is not a real problem, it is unnecessary and increases compile times when working with mitk::Image (because many classes depend on DataNode).

The DataNode is supposed to have a dependency on BaseData, not the Image.

Unfortunately this dependency has been there quite a long time now. Thus removing the include will result many other classes to miss the "mitkImage.h" because the transitive include has been removed.

It's not hard to do, just takes some time to make the code compile again...

Related Objects

StatusAssignedTask
ResolvedNone

Event Timeline

User heime has pushed new remote branch:

bug-16694-forwarddeclaration

User heime has pushed new remote branch:

bug-16694-forwarddeclaration-integration

[81945c]: Merge branch 'bug-16694-forwarddeclaration-integration'

Merged commits:

2014-04-09 16:21:54 Eric Heim [723e85]
Merge branch 'bug-16694-forwarddeclaration' into bug-16694-forwarddeclaration-integration


2014-03-12 16:15:36 Eric Heim [932233]
forward declarations in diffusion and tutorials


2014-03-12 14:51:33 Eric Heim [11cca6]
forward declaration of mitk Image in mitkDatanode

[82abd5]: Merge branch 'bug-16694-forwarddeclaration-integration'

Merged commits:

2014-05-05 13:27:22 Eric Heim [f129dc]
COMP: Fixed Plugin generator build test