Page MenuHomePhabricator

Enable WARNINGS_AS_ERRORS for modules
Closed, ResolvedPublic

Event Timeline

New remote branch pushed: bug-16780-warnings-as-errors-for-modules

[05fa83]: Merge branch 'bug-16780-warnings-as-errors-for-modules'

Merged commits:

2014-01-13 02:57:47 Sascha Zelzer [8cec72]
Fixed VS2010 warning about unknown -std=c++0x option.

Removed C++0x CMake code completely, since it wasn't used properly.


2014-01-13 02:46:23 Sascha Zelzer [8cb6d1]
Enable "warnings as errors" for a couple of modules.

[06f3e5]: Merge branch 'bug-16780-warnings-as-errors-for-modules'

Merged commits:

2014-01-13 11:05:10 Sascha Zelzer [2ac14e]
COMP: Fixed warnings.

[a69e0d]: Merge branch 'bug-16780-warnings-as-errors-for-modules'

Merged commits:

2014-01-13 14:27:39 Sascha Zelzer [cfa7d7]
COMP: Restore old behavior for NavigationDataSource::GetOutput(std::string)

New remote branch pushed: bug-16780-remove-vc10-warnings

[15f2b7]: Merge branch 'bug-16780-remove-vc10-warnings'

Merged commits:

2014-01-13 18:17:49 Caspar Goch [4c44e7]
Fixed VC 10 complaints about conversion from size_t to int

[721bbc]: Merge branch 'bug-16780-remove-gcc-4-8-1-warning'

Merged commits:

2014-01-15 09:51:09 Adrian Winterstein [2842c3]
Removed cast warning in CreateDistanceImageFromSurfaceFilter (gcc 4.8.1).

New remote branch pushed: bug-16780-remove-gcc-4-8-1-warning

New remote branch pushed: bug-16780-remove-Apple-LLVM-version-4-2-clang-425-0-28-warnings

New remote branch pushed: bug-16780-RemoveWarningsInDiffusionCore

Core changes in "bug-16780-RemoveWarningsInDiffusionCore":

  • removed empty implementation of "void mitk::FileWriter::SetInput( DataNode* )" in mitkFileWriter
  • removed DEPRECATED ReleaseGraphicsResources(vtkWindow* /*renWin*/) in mitkVtkMapper

[15cb7d]: Merge branch 'bug-16780-warnings-as-errors-for-modules'

Merged commits:

2014-01-17 02:21:42 Sascha Zelzer [9e367a]
Merge remote-tracking branch 'origin/bug-16780-RemoveWarningsInDiffusionCore' into bug-16780-warnings-as-errors-for-modules


2014-01-17 02:21:13 Sascha Zelzer [ee9c06]
Merge remote-tracking branch 'origin/bug-16780-remove-Apple-LLVM-version-4-2-clang-425-0-28-warnings' into bug-16780-warnings-as-errors-for-modules


2014-01-17 02:20:48 Sascha Zelzer [8a0dfd]
Merge remote-tracking branch 'origin/bug-16780-remove-gcc-4-8-1-warning' into bug-16780-warnings-as-errors-for-modules


2014-01-17 02:20:12 Sascha Zelzer [9cfd20]
Merge remote-tracking branch 'origin/bug-16780-remove-vc10-warnings' into bug-16780-warnings-as-errors-for-modules


2014-01-15 16:24:34 Christoph Kolb [5ee4f7]
remove warnings in diffusionCore


2014-01-15 16:24:17 Christoph Kolb [c2d513]
Remove deprecated and unneeded methods


2014-01-15 16:23:37 Christoph Kolb [46d7ab]
Enable WARNINGS_AS_ERRORS in DiffusionCore


2014-01-15 16:00:30 Jonas Cordes [ff1762]
Merge branch 'bug-16485-removeTestCase4' into bug-16780-remove-Apple-LLVM-version-4-2-clang-425-0-28-warnings


2014-01-15 15:59:04 Jonas Cordes [d48562]
add forward-declaration for us::ModuleContext


2014-01-15 15:33:52 Jonas Cordes [3560ea]
fix implicit double to int cast


2014-01-15 15:25:47 Jonas Cordes [84116f]
unused variable found in qt src temp-fix in cmake file for Overlays module


2014-01-15 15:01:10 Jonas Cordes [815203]
add missed line


2014-01-15 14:49:24 Jonas Cordes [2f094f]
Enable WARNINGS_AS_ERRORS for modules caused a error for character encoding


2014-01-15 14:23:09 Jonas Cordes [7dd38d]
remove unused private variables in mitkSurfaceInterpolationController.h
double m_MinSpacing;
double m_MaxSpacing;
const Image* m_WorkingImage;
unsigned int m_DistImageVolume;


2014-01-15 14:23:04 Jonas Cordes [09ff15]
remove unused private variable in mitkPlanarFigureMapper2D.h
float m_PointWidth

[4c9190]: Merge branch 'bug-16780-warnings-as-errors-for-modules'

Merged commits:

2014-01-17 10:37:07 Jonas Cordes [c8734f]
Merge branch 'bug-16780-RemoveWarningsInDiffusionCore' into bug-16780-warnings-as-errors-for-modules


2014-01-17 10:33:12 Jonas Cordes [a89cf9]
COMP: fix uninitialized variable


2014-01-17 10:11:38 Jonas Cordes [b85e33]
COMP: replace deprecated get_vnl_vector call with GetVnlVector


2014-01-17 10:11:01 Jonas Cordes [54f80f]
COMP: fix int and unsigned int comparison error

New remote branch pushed: bug-16780-RemoveWarningsInDiffusionImaging

New remote branch pushed: bug-16780-warnings-as-errors-in-connectomics

New remote branch pushed: bug-16780-warnings-as-errors-clang-3.4

@Sascha
After the warning-as-errors commit, mitk does not compile anymore with clang 3.4, i pushed the changes necessary to compile again, but I am not completely sure they are valid, especially the commit about the undefined reference.
Maybe you can check it and we can have a look together at it.

DiffusionImaging is now warning free for gcc 4.8 and clang 3.3 in bug-16780-RemoveWarningsInDiffusionImaging.

this should be tested in windows before we merge it.

clang 3.4 generates more warnings but i think it can wait since it was just released

New remote branch pushed: bug-16780-fixGPGPUModuleWarnings

[bcfa77]: Merge branch 'bug-16780-fixGPGPUModuleWarnings'

Merged commits:

2014-01-20 10:43:03 Christoph Kolb [d57d41]
remove unused variables which cause warnings

[41e8e9]: Merge branch 'bug-16780-RemoveWarningsInDiffusionImaging'

Merged commits:

2014-01-20 15:25:27 Christoph Kolb [9c3ac2]
make pos and dir in mitk::Particle private members


2014-01-20 13:50:25 Christoph Kolb [3b21b7]
initialize variable to remove warning


2014-01-20 12:58:47 Christoph Kolb [ee4d92]
fix clang 3.3 warnings -> set vectorContainer type to unsigned int


2014-01-20 12:41:06 Caspar Goch [66cd23]
disable warning for template exporting


2014-01-20 12:40:37 Caspar Goch [ce998a]
specify std min type


2014-01-20 12:39:38 Caspar Goch [bb929a]
fix connectomics warning


2014-01-20 10:25:34 Christoph Kolb [54ef89]
removed more clang 3.3 warnings


2014-01-20 10:16:41 Christoph Kolb [1348b4]
removed clang warnings


2014-01-17 18:05:04 Christoph Kolb [906494]
enable WARNINGS_AS_ERRORS and remove warnings in diffusionImaging Modules

New remote branch pushed: bug-16780-warnings-unused-result

[2506fa]: Merge branch 'bug-16780-warnings-unused-result'

Merged commits:

2014-01-20 16:46:25 Christian Weber [fb5869]
COMP: fix to remove unused result errors.

[39d3e1]: Merge branch 'bug-16780-RepairProjectionFilter'

Merged commits:

2014-01-20 17:04:19 Christoph Kolb [7104b4]
COMP: use signed integers in for loop

[d1806f]: Merge branch 'bug-16780-RepairProjectionFilter'

Merged commits:

2014-01-20 17:08:25 Christoph Kolb [388269]
COMP: initialize radius_src

[962e9d]: Merge branch 'bug-16780-RepairProjectionFilter'

Merged commits:

2014-01-20 17:32:27 Christoph Kolb [b511af]
COMP: initialize radius_src

[772ee4]: Merge branch 'bug-16780-RemoveWarningsInDiffusionImaging'

Merged commits:

2014-01-21 16:25:14 Jan Hering [4d24cf]
COMP Remove WSignCompare errors in Quantification


2014-01-21 15:35:25 Caspar Goch [4baaa0]
COMP: ignore unused variable warnings in connectomics due to boost


2014-01-21 14:57:46 Caspar Goch [24c508]
COMP: More integer replacements


2014-01-21 14:24:19 Caspar Goch [16028d]
COMP: Another unsigned int int comparison


2014-01-21 14:10:14 Caspar Goch [bf6347]
COMP: Fixed size type


2014-01-21 13:37:40 Caspar Goch [4936cc]
COMP: Remove more linux warnings

New remote branch pushed: bug-16780-RemoveWarnings-Apple-LLVM-version-4-2

[c90396]: Merge branch 'bug-16780-remove-vc10-warnings'

Merged commits:

2014-01-24 13:52:09 Caspar Goch [ed6cc0]
COMP: Use unused local variable

New remote branch pushed: bug-16780-clang-warnings-diffusion

[4da374]: Merge branch 'bug-16780-RemoveWarningsInDiffusionImaging'

Merged commits:

2014-01-28 13:07:48 Jan Hering [060467]
Exclude -Wunneeded-internal-declaration from errors

  • under clang, the error comes from Boost macros deactivating warning-as-error for this type

New remote branch pushed: bug-16780-warnings-as-errors-clang-3.4-v2

New remote branch pushed: bug-16780-warnings-as-errors-clang-3dot4

[07332d]: Merge branch 'bug-16780-warnings-as-errors-clang-3dot4'

Merged commits:

2014-01-30 18:24:49 Christian Weber [5f8e88]
Merge branch 'bug-16780-warnings-as-errors-clang-3.4-v2'


2014-01-30 18:21:02 Christian Weber [a0debd]
fix wrong header guards


2014-01-17 20:28:21 Christian Weber [4bcc58]
Removed default values from friend declarations


2014-01-17 20:27:50 Christian Weber [f844dd]
Deleted unused variables

User cordes has pushed new remote branch:

bug-16780-DiffusionImagingModule-Warning-Fixes

[fb2cd5]: Merge branch 'bug-16780-DiffusionImagingModule-Warning-Fixes'

Merged commits:

2014-02-13 15:49:22 Jonas Cordes [a54e8e]
unsigned int comparison warning killed a minus sign

[056b68]: Merge branch 'bug-16780-BoostWarningsInConnectomicsModule'

Merged commits:

2014-02-25 11:12:37 Adrian Winterstein [f2c76e]
Ignoring "Maybe Uninitialized" and "Unused Parameter" warnings on linux in Release mode
as there is at least one in the Boost header files.

User wintersa has pushed new remote branch:

bug-16780-BoostWarningsInConnectomicsModule2

There has been good overall progress for enabling warnings_as_errors for several modules. For future work, please open new bugs for the specific module being worked on.