Page MenuHomePhabricator
Create Task
Maniphest T18167

Segmentation view image selectors can be brought to an inconsistent state.
Closed, WontfixPublic
Actions

Description

Open an image, create a segmentation. Check the binary property on the image, then uncheck it on the segmentation. As a consequence, both images will be in the segmentation image selector, while none being in the patient image selector.

Related Objects
Search...

Event Timeline

norajitr added projects: MITK, Bugzilla.Oct 1 2014, 5:29 PM
norajitr added a subscriber: norajitr.Oct 1 2014, 5:33 PM

The problem is located in the OnBinaryPropertyChanged() method, which is called only upon unchecking the segmentation binary property. The patient image uninentionally goes to the segmentation image selector due to its binary property. Then, the function returns prior to consideration of the segmentation image binary property swap.

• git-user added a subscriber: • git-user.Sep 30 2015, 2:35 PM

User brehler has pushed new remote branch:

bug-18167-InconsistentStateOfImageSelector
• brehler added a subscriber: • brehler.Sep 30 2015, 2:38 PM

[2c4d38]: Merge branch 'bug-18167-InconsistentStateOfImageSelector'

Merged commits:

2015-09-30 14:33:32 Michael Brehler [875f39]
removed isBinary from if condition that avoids the correct addition of the property observer

• hering added a subscriber: • hering.Oct 8 2015, 1:34 PM

Reopen: The current solution leads to a crash when a planar figure node is inserted into the DatStorage.

Reproduce:

• hering added a comment.Oct 8 2015, 1:36 PM

Reopen: The current solution leads to a crash when a planar figure node is inserted into the DatStorage.

Reproduce:

  • open an image
  • open both SegmentationView and Measurement
  • select measurement view and add some planar figure --> IMMEDIATE CRASH in the QmitkSegmentationView::NodeAdded method

It is because of the removal of the ( isBinary ) check in the if() condition for adding the observer.

• hering added a comment.Oct 14 2015, 4:53 PM

[595964]: Merge branch 'bug-18167-InconsistentImageSelectorState-REVERT'

Merged commits:

2015-10-14 16:49:13 Jan Hering [36f1a2]
Revert commit [875f39] merged on 30-09-2015

  • the removed "isBinary" check causes a multiple crashes when handling with non-image objects (planar figures, fibertracts etc.) while the SegmentationView is opened somewhare.
• hering added a comment.Oct 14 2015, 4:56 PM

Sorry, but I had to revert the change in QmitkSegmentationView since the initial fix makes the MITK Diffusion application unusable, and also as described above a crash in MITK Workbench with planar figures can be easily provoked.

• fetzer added a subscriber: • fetzer.Feb 9 2016, 3:26 PM

This bug seems to be unlikely to appear. If possible we should fix it for the upcoming release, however it is not a blocker

• git-user added a comment.Apr 13 2016, 3:23 PM

User heime has pushed new remote branch:

bug-18167-InconsistentImageSelectorState-Fix
• heime added a comment.Apr 18 2016, 5:34 PM

[4604ef]: Merge branch 'bug-18167-InconsistentImageSelectorState-Fix'

Merged commits:

2016-04-13 14:54:04 Eric Heim [288b9c]
Add observers only to images, binary and labelset images

kislinsk edited projects, added MITK (2016-03); removed MITK.Aug 1 2016, 10:49 PM
kislinsk edited projects, added MITK (2016-11); removed MITK (2016-03).Aug 26 2016, 12:47 PM
kislinsk edited projects, added MITK; removed MITK (2016-11).Feb 6 2017, 11:24 AM
kislinsk closed this task as Wontfix.May 26 2020, 11:17 AM
kislinsk added a project: Auto-closed.
kislinsk added a subscriber: kislinsk.

Hi there! 🙂

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑

Best wishes,
The MITK devs

MITK · MIC · IMSY · DKFZ