Page MenuHomePhabricator

Imagecropper resets colormap property
Closed, ResolvedPublic

Description

  1. Load image
  2. Set colormap to Jet.
  3. Use image cropper
  4. Colormap is reset to standard.

Event Timeline

User kirchnth has pushed new remote branch:

bug-18482-DataNodeSetDefaultPropertyFix

We found that the cropping result image replaces the original image data in the data node of the image to be cropped. The replacement is done by calling SetData(...) method of class DataNode. In this method the properties of the data node are set to default. Thus, the lookup table property is reset to default.

Prior set properties should be kept if previous data of the node already exists and has the same type as the new data to be set. Otherwise, the default properties should be used.

User eisenman has pushed new remote branch:

bug-18482-DataNodeSetDefaultPropertyFix-Integration

[878196]: Merge branch 'bug-18482-DataNodeSetDefaultPropertyFix-Integration'

Merged commits:

2015-06-03 16:18:05 Matthias Eisenmann [c7013b]
Merge remote-tracking branch 'origin/bug-18482-DataNodeSetDefaultPropertyFix' into bug-18482-DataNodeSetDefaultPropertyFix-Integration


2015-01-21 17:00:31 Thomas Kirchner [7ea123]
cleanup


2015-01-21 16:46:11 Thomas Kirchner [33a22a]
orthography


2015-01-21 16:34:53 Thomas Kirchner [2c5fbe]
Added Test and clearing of the propertylist if other datatype is loaded


2015-01-21 13:47:46 Thomas Kirchner [10b37b]
Core Change instead of workaround in plugin ... also cleanup

User eisenman has pushed new remote branch:

bug-18482-DataNodeSetDefaultPropertyFixUpdate

[16a6a7]: Merge branch 'bug-18482-DataNodeSetDefaultPropertyFixUpdate'

Merged commits:

2015-06-25 14:18:38 Matthias Eisenmann [8fdf0b]
Adapted documentation of SetData method.


2015-06-25 14:17:36 Matthias Eisenmann [34a4d3]
Refactoring.


2015-06-24 19:58:08 Matthias Eisenmann [3b0269]
Added check for nullptr before accessing baseData.
Only clear property list if data types differ but base data is not null.


2015-06-24 19:56:48 Matthias Eisenmann [87592e]
Added check for nullptr before accessing baseData.
Only clear property list if data types differ but base data is not null.

Create a integration branch for the 2015.05.2 release based on all the changes which are already merged to the master.

User metzger has pushed new remote branch:

bug-18482-IntegrationBranchForBugFixRelease2015.05.2

Integrated bug-18482-IntegrationBranchForBugFixRelease2015.05.2 into 2015.05.2.