Page MenuHomePhabricator

Segmentation warnings replace each other
Closed, InvalidPublic

Description

To reproduce:

  1. load two images
  2. create a segmentation for each one
  3. Select in the combo boxes image one and the segmentation for image two

-> The warning label tells you they do not fit, and buttons are disabled

  1. make the segmentation invisible

-> The warning label tells it is invisible, and buttons are disabled

  1. make the segmentation visible again

-> The warning label is gone, and buttons are disabled

Ideally the warning label should either display all current problems or the most pressing one. But they should not overwrite each other so that if the last one is solved previous ones are gone.

Event Timeline

kalali added a subscriber: kalali.

We are now using a different approach but this should be verified with the new widgets.

kalali closed this task as Invalid.EditedJan 19 2021, 2:35 PM
  1. The new selection concept automatically removes non-matching segmentation nodes if the reference image was changed. A warning is shown Select or create a segmentation (Tools disabled)
  2. The new selection concept does not allow to select a non-matching segmentation node
  3. Selecting a matching segmentation node that is invisible results in the warning: The selected segmentation is currently not visible! (Tools disabled)
  4. Showing the invisible segmentation node results in the warning: Please perform a reinit on the segmentation image! (Tools disabled)
  5. Performing a reinit on the matching segmentation node enables the tools (no warning shown)

So the described bug does not occur anymore. However, I found another bug, dealing with a similar issue, which is described here: T28180