Can not reproduce on windows.

Even the workflow:

1. Select display tab -> open context help
2. Hit F1
3. Close Editor

does not crash on windows (but it does on linux).

Console log on windows:

First F1 press:
BlueBerry: Context help url invalid: qthelp://org.blueberry.ui.qt.help/bundle/org_blueberry_editors_help.html

Second F1 press:
BlueBerry ERROR: Problem detected with part org.blueberry.editors.help(class = berry::HelpEditor): Editor is not firing a PROP_INPUT event in response to IReusableEditor.setInput(...)

Every Subsequent F1 presses:
BlueBerry: Context help url invalid: qthelp://org.blueberry.ui.qt.help/bundle/org_blueberry_editors_help.html

This bug still occurs under Linux.

The workbench crashes due to a segmentation fault during a dynamic cast in the comparison operator of the class DataStorageEditorInput.

The above mentioned steps don't exactly describe the way to reproduce this bug on my Linux system.

Here's the update:

• Press F1
• Close help window
• Press F1 twice
• Close help window

--> Workbench crashes

berry::WorkbenchSourceProvider is the class from which the comparison (newShowInInput != lastShowInInput) leading to the segmentation fault is triggered.

if (newShowInInput != lastShowInInput)
{
  sources |= ISources::ACTIVE_SITE();
  lastShowInInput = newShowInInput.GetPointer();
}

The comparison is only used to manage the sources variable. Maybe there's an alternative way for managing that? If this check is omitted, I cannot reproduce this bug anymore.

This bug can be solved by using a SmartPointer for member variable lastShowInInput instead of a standard pointer.

Pushed new branch T19055-CrashOnF1Hit.